public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL
@ 2022-11-22 14:05 ro at gcc dot gnu.org
2022-11-22 14:05 ` [Bug libstdc++/107817] " ro at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: ro at gcc dot gnu.org @ 2022-11-22 14:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
Bug ID: 107817
Summary: std/format/functions/format.cc etc. FAIL
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: ro at gcc dot gnu.org
Target Milestone: ---
Target: *-*-solaris2.11, x86_64-unknown-freebsd12.4,
powerpc64le-unknown-linux-gnu
The std/format/functions/format.cc and std/format/functions/format_to_n.cc
tests FAIL on Solaris (32 and 64-bit, sparc and x86):
+FAIL: std/format/functions/format.cc (test for excess errors)
+UNRESOLVED: std/format/functions/format.cc compilation failed to produce
executable
Excess errors:
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:508:
error: 'static constexpr std::__format::_Spec<_CharT>::iterator
std::__format::_Spec<_CharT>::_S_parse_width_or_precision(iterator, iterator,
short unsigned int&, bool&, std::basic_format_parse_context<_CharT>&) [with
_CharT = char; iterator = const char*]' called in a constant expression
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:468:
error: call to non-'constexpr' function 'int std::isdigit(int)'
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:508:
error: 'static constexpr std::__format::_Spec<_CharT>::iterator
std::__format::_Spec<_CharT>::_S_parse_width_or_precision(iterator, iterator,
short unsigned int&, bool&, std::basic_format_parse_context<_CharT>&) [with
_CharT = char; iterator = const char*]' called in a constant expression
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:508:
error: 'static constexpr std::__format::_Spec<_CharT>::iterator
std::__format::_Spec<_CharT>::_S_parse_width_or_precision(iterator, iterator,
short unsigned int&, bool&, std::basic_format_parse_context<_CharT>&) [with
_CharT = char; iterator = const char*]' called in a constant expression
and many more
+FAIL: std/format/functions/format_to_n.cc (test for excess errors)
+UNRESOLVED: std/format/functions/format_to_n.cc compilation failed to produce
executable
Excess errors:
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:508:
error: 'static constexpr std::__format::_Spec<_CharT>::iterator
std::__format::_Spec<_CharT>::_S_parse_width_or_precision(iterator, iterator,
short unsigned int&, bool&, std::basic_format_parse_context<_CharT>&) [with
_CharT = char; iterator = const char*]' called in a constant expression
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:468:
error: call to non-'constexpr' function 'int std::isdigit(int)'
/var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstdc++-v3/include/format:508:
error: 'static constexpr std::__format::_Spec<_CharT>::iterator
std::__format::_Spec<_CharT>::_S_parse_width_or_precision(iterator, iterator,
short unsigned int&, bool&, std::basic_format_parse_context<_CharT>&) [with
_CharT = wchar_t; iterator = const wchar_t*]' called in a constant expression
and many more
since 20221114. FreeBSD and (maybe, if that's not an older issue since fixed)
Linux/powerpc64le are equally affected.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
@ 2022-11-22 14:05 ` ro at gcc dot gnu.org
2022-11-22 17:12 ` redi at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ro at gcc dot gnu.org @ 2022-11-22 14:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
Rainer Orth <ro at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
2022-11-22 14:05 ` [Bug libstdc++/107817] " ro at gcc dot gnu.org
@ 2022-11-22 17:12 ` redi at gcc dot gnu.org
2022-11-22 17:16 ` redi at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-22 17:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Last reconfirmed| |2022-11-22
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
2022-11-22 14:05 ` [Bug libstdc++/107817] " ro at gcc dot gnu.org
2022-11-22 17:12 ` redi at gcc dot gnu.org
@ 2022-11-22 17:16 ` redi at gcc dot gnu.org
2022-11-22 17:54 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-22 17:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target|*-*-solaris2.11, |*-*-solaris2.11,
|x86_64-unknown-freebsd12.4, |x86_64-unknown-freebsd12.4,
|powerpc64le-unknown-linux-g |
|nu |
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Rainer Orth from comment #0)
> FreeBSD and (maybe, if that's not an older issue since
> fixed)
> Linux/powerpc64le are equally affected.
Linux/powerpc64le was PR107720 and is unrelated to this.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
` (2 preceding siblings ...)
2022-11-22 17:16 ` redi at gcc dot gnu.org
@ 2022-11-22 17:54 ` cvs-commit at gcc dot gnu.org
2022-11-22 18:12 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-11-22 17:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:dfc1ea414e0cebccfcffc771ebcefa3d24c9754c
commit r13-4243-gdfc1ea414e0cebccfcffc771ebcefa3d24c9754c
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 22 17:39:43 2022 +0000
libstdc++: Replace std::isdigit and std::isxdigit in <format> [PR107817]
These functions aren't usable in constant expressions. Provide our own
implementations, based on __from_chars_alnum_to_val from <charconv>.
libstdc++-v3/ChangeLog:
PR libstdc++/107817
* include/std/charconv (__from_chars_alnum_to_val): Add
constexpr for C++20.
* include/std/format (__is_digit, __is_xdigit): New functions.
(_Spec::_S_parse_width_or_precision): Use __is_digit.
(__formatter_fp::parse): Use __is_xdigit.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
` (3 preceding siblings ...)
2022-11-22 17:54 ` cvs-commit at gcc dot gnu.org
@ 2022-11-22 18:12 ` redi at gcc dot gnu.org
2022-11-22 21:35 ` redi at gcc dot gnu.org
2022-11-24 8:59 ` ro at CeBiTec dot Uni-Bielefeld.DE
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-22 18:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This should be fixed now. I'm doing a Solaris build to check.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
` (4 preceding siblings ...)
2022-11-22 18:12 ` redi at gcc dot gnu.org
@ 2022-11-22 21:35 ` redi at gcc dot gnu.org
2022-11-24 8:59 ` ro at CeBiTec dot Uni-Bielefeld.DE
6 siblings, 0 replies; 8+ messages in thread
From: redi at gcc dot gnu.org @ 2022-11-22 21:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Native configuration is sparc-sun-solaris2.11
=== libstdc++ tests ===
Schedule of variations:
unix
Running target unix
Running
/export/home/jwakely/src/gcc/libstdc++-v3/testsuite/libstdc++-dg/conformance.exp
...
PASS: std/format/arguments/args.cc (test for excess errors)
PASS: std/format/arguments/args.cc execution test
PASS: std/format/error.cc (test for excess errors)
PASS: std/format/error.cc execution test
PASS: std/format/formatter/concept.cc (test for excess errors)
PASS: std/format/formatter/requirements.cc (test for excess errors)
PASS: std/format/formatter/requirements.cc execution test
PASS: std/format/functions/format.cc (test for excess errors)
PASS: std/format/functions/format.cc execution test
PASS: std/format/functions/format_to_n.cc (test for excess errors)
PASS: std/format/functions/format_to_n.cc execution test
PASS: std/format/functions/size.cc (test for excess errors)
PASS: std/format/functions/size.cc execution test
PASS: std/format/functions/vformat_to.cc (test for excess errors)
PASS: std/format/functions/vformat_to.cc execution test
PASS: std/format/parse_ctx.cc (test for excess errors)
PASS: std/format/parse_ctx.cc execution test
PASS: std/format/string.cc (test for excess errors)
PASS: std/format/string.cc execution test
PASS: std/format/string_neg.cc (test for errors, line )
PASS: std/format/string_neg.cc (test for excess errors)
=== libstdc++ Summary ===
# of expected passes 21
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug libstdc++/107817] std/format/functions/format.cc etc. FAIL
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
` (5 preceding siblings ...)
2022-11-22 21:35 ` redi at gcc dot gnu.org
@ 2022-11-24 8:59 ` ro at CeBiTec dot Uni-Bielefeld.DE
6 siblings, 0 replies; 8+ messages in thread
From: ro at CeBiTec dot Uni-Bielefeld.DE @ 2022-11-24 8:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107817
--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> Native configuration is sparc-sun-solaris2.11
[...]
> PASS: std/format/functions/format.cc (test for excess errors)
> PASS: std/format/functions/format.cc execution test
> PASS: std/format/functions/format_to_n.cc (test for excess errors)
> PASS: std/format/functions/format_to_n.cc execution test
Same on i386-pc-solaris2.11. Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-11-24 8:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 14:05 [Bug libstdc++/107817] New: std/format/functions/format.cc etc. FAIL ro at gcc dot gnu.org
2022-11-22 14:05 ` [Bug libstdc++/107817] " ro at gcc dot gnu.org
2022-11-22 17:12 ` redi at gcc dot gnu.org
2022-11-22 17:16 ` redi at gcc dot gnu.org
2022-11-22 17:54 ` cvs-commit at gcc dot gnu.org
2022-11-22 18:12 ` redi at gcc dot gnu.org
2022-11-22 21:35 ` redi at gcc dot gnu.org
2022-11-24 8:59 ` ro at CeBiTec dot Uni-Bielefeld.DE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).