[Bug lto/107829] New: Trivial compile time tracking code

[Bug lto/107829] New: Trivial compile time tracking code

[fxue at os dot amperecomputing.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107829

            Bug ID: 107829
           Summary: Trivial compile time tracking code
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fxue at os dot amperecomputing.com
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---

In the function "materialize_cgraph" of lto.cc:


  /* Start the appropriate timer depending on the mode that we are
     operating in.  */
  lto_timer = (flag_wpa) ? TV_WHOPR_WPA
              : (flag_ltrans) ? TV_WHOPR_LTRANS
              : TV_LTO;
  timevar_push (lto_timer);

  current_function_decl = NULL;
  set_cfun (NULL);

  if (!quiet_flag)
    fprintf (stderr, "\n");

  timevar_pop (lto_timer);


Execution of code enclosed by time-variable "lto_timer" is expected to be of
zero time. Adding time tracking here seems to be superfluous.

[Bug lto/107829] Trivial compile time tracking code

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107829

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
            Version|unknown                     |13.0
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-11-23
   Target Milestone|---                         |13.0

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Sure, it's bad, lemme send a patch for it.

[Bug lto/107829] Trivial compile time tracking code

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107829

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Patch candidate:
https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607100.html

[Bug lto/107829] Trivial compile time tracking code

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107829

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:2b3a3d7fe3420b6b49810b2a7f5d120c53310335

commit r13-4296-g2b3a3d7fe3420b6b49810b2a7f5d120c53310335
Author: Martin Liska <mliska@suse.cz>
Date:   Wed Nov 23 10:38:54 2022 +0100

    lto: fix usage of timer in materialize_cgraph

            PR lto/107829

    gcc/lto/ChangeLog:

            * lto.cc (materialize_cgraph): Call timevar_push before
              materialization starts.

[Bug lto/107829] Trivial compile time tracking code

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107829

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed for master.