[Bug testsuite/107830] New: [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[Bug testsuite/107830] New: [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

            Bug ID: 107830
           Summary: [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at
                    ./insn-opinit.h:813
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code, openmp
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: aarch64-linux-gnu

gcc 13.0.0 20221120 snapshot (g:a16a5460447eaaff0b4468064e4d7b1cc8fc42eb) ICEs
when compiling the following testcase, reduced from
libgomp/testsuite/libgomp.c-c++-common/for-15.c, w/ -march=armv9-a -Os
-fopenmp:

void
f2 (int *a)
{
  unsigned int i;

#pragma omp simd
  for (i = 0; i < 4; ++i)
    a[i / 3] -= 4;
}

% aarch64-linux-gnu-gcc-13 -march=armv9-a -Os -fopenmp -c t3uokd3k.c
during RTL pass: expand
t3uokd3k.c: In function 'f2':
t3uokd3k.c:8:9: internal compiler error: in gen_aarch64_bitmask_udiv3, at
./insn-opinit.h:813
    8 |     a[i / 3] -= 4;
      |       ~~^~~
0x7e5c72 gen_aarch64_bitmask_udiv3(machine_mode, rtx_def*, rtx_def*, rtx_def*)
        ./insn-opinit.h:813
0x7e5c72 gen_aarch64_bitmask_udiv3(machine_mode, rtx_def*, rtx_def*, rtx_def*)
        ./insn-opinit.h:810
0x7e5c72 aarch64_vectorize_can_special_div_by_constant(tree_code, tree_node*,
generic_wide_int<wide_int_storage>, rtx_def**, rtx_def*, rtx_def*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/config/aarch64/aarch64.cc:24339
0xb26cca expand_divmod(int, tree_code, machine_mode, tree_node*, tree_node*,
rtx_def*, rtx_def*, rtx_def*, int, optab_methods)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/expmed.cc:4383
0xb2a706 expand_expr_divmod
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/expr.cc:9198
0xb349ab expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/expr.cc:9868
0xa0eac0 expand_gimple_stmt_1
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/cfgexpand.cc:3983
0xa0eac0 expand_gimple_stmt
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/cfgexpand.cc:4044
0xa14e2e expand_gimple_basic_block
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/cfgexpand.cc:6096
0xa16817 execute
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221120/work/gcc-13-20221120/gcc/cfgexpand.cc:6822

[Bug target/107830] [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktkachov at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-11-23

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Likely started with r13-4028-gd758d1908899cf.

[Bug target/107830] [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[ktkachov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tnfchris at gcc dot gnu.org

--- Comment #2 from ktkachov at gcc dot gnu.org ---
I think it's more likely Tamar's recent patches for that optab

[Bug target/107830] [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
hmm Indeed, it seems it crashes at -Os. Will take a look.

[Bug target/107830] [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/107830] [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:71f3036b8a83da7fb559923bc80687ea1dabe14a

commit r13-4303-g71f3036b8a83da7fb559923bc80687ea1dabe14a
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Fri Nov 25 12:57:24 2022 +0000

    sve2: Fix expansion of division [PR107830]

    SVE has an actual division optab, and when using -Os we don't
    optimize the division away.  This means that we need to distinguish
    between a div which we can optimize and one we cannot even during
    expansion.

    gcc/ChangeLog:

            PR target/107830
            * config/aarch64/aarch64.cc
            (aarch64_vectorize_can_special_div_by_constant): Check validity
during
            codegen phase as well.

    gcc/testsuite/ChangeLog:

            PR target/107830
            * gcc.target/aarch64/sve2/pr107830-1.c: New test.
            * gcc.target/aarch64/sve2/pr107830-2.c: New test.

[Bug target/107830] [13 Regression] ICE in gen_aarch64_bitmask_udiv3, at ./insn-opinit.h:813

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107830

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Fixed, thanks for the report.