public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107852] [12/13 Regression] Spurious warnings stringop-overflow and array-bounds copying data as bytes into vector
Date: Tue, 29 Nov 2022 16:50:18 +0000	[thread overview]
Message-ID: <bug-107852-4-NzUgHLLRB1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107852-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107852

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
With that compiler patch for the missed-optimization one of the two bogus
warnings goes away. The second one goes away with this change:

--- a/libstdc++-v3/include/bits/stl_vector.h
+++ b/libstdc++-v3/include/bits/stl_vector.h
@@ -374,8 +374,19 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER
       pointer
       _M_allocate(size_t __n)
       {
-       typedef __gnu_cxx::__alloc_traits<_Tp_alloc_type> _Tr;
-       return __n != 0 ? _Tr::allocate(_M_impl, __n) : pointer();
+        pointer __p = pointer();
+        if (__n != 0)
+          {
+            typedef __gnu_cxx::__alloc_traits<_Tp_alloc_type> _Tr;
+            const pointer __s = _M_impl._M_start;
+            const pointer __f = _M_impl._M_finish;
+            const pointer __e = _M_impl._M_end_of_storage;
+            __p = _Tr::allocate(_M_impl, __n);
+            if (__s != _M_impl._M_start || __f != _M_impl._M_finish
+               || __e != _M_impl._M_end_of_storage)
+              __builtin_unreachable();
+          }
+        return __p;
       }

       _GLIBCXX20_CONSTEXPR

  parent reply	other threads:[~2022-11-29 16:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 23:24 [Bug tree-optimization/107852] New: " cuzdav at gmail dot com
2022-11-23 23:31 ` [Bug tree-optimization/107852] " pinskia at gcc dot gnu.org
2022-11-24  1:12 ` pinskia at gcc dot gnu.org
2022-11-24  7:07 ` rguenth at gcc dot gnu.org
2022-11-24  7:08 ` [Bug tree-optimization/107852] [12/13 Regression] " rguenth at gcc dot gnu.org
2022-11-29 11:46 ` rguenth at gcc dot gnu.org
2022-11-29 11:47 ` [Bug libstdc++/107852] " rguenth at gcc dot gnu.org
2022-11-29 12:01 ` redi at gcc dot gnu.org
2022-11-29 12:26 ` rguenth at gcc dot gnu.org
2022-11-29 13:30 ` cvs-commit at gcc dot gnu.org
2022-11-29 13:31 ` rguenth at gcc dot gnu.org
2022-11-29 16:50 ` redi at gcc dot gnu.org [this message]
2022-11-29 17:14 ` cvs-commit at gcc dot gnu.org
2023-03-19 10:31 ` [Bug libstdc++/107852] [12 " dvirtz at gmail dot com
2023-04-20 13:57 ` cvs-commit at gcc dot gnu.org
2023-04-27 11:44 ` rguenth at gcc dot gnu.org
2023-05-01 13:12 ` pinskia at gcc dot gnu.org
2023-06-29 18:08 ` rogerio.souza at gmail dot com
2023-06-29 18:12 ` rogerio.souza at gmail dot com
2023-06-29 19:16 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107852-4-NzUgHLLRB1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).