public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/107852] [12/13 Regression] Spurious warnings stringop-overflow and array-bounds copying data as bytes into vector
Date: Tue, 29 Nov 2022 13:30:50 +0000	[thread overview]
Message-ID: <bug-107852-4-QJAb9NoNrt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-107852-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107852

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:fd8dd6c0384969170e594be34da278a072d5eb76

commit r13-4389-gfd8dd6c0384969170e594be34da278a072d5eb76
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Nov 29 12:56:22 2022 +0100

    tree-optimization/107852 - missed optimization with PHIs

    The following deals with the situation where we have

    <bb 2> [local count: 1073741824]:
    _5 = bytes.D.25336._M_impl.D.24643._M_start;
    _6 = bytes.D.25336._M_impl.D.24643._M_finish;
    pretmp_66 = bytes.D.25336._M_impl.D.24643._M_end_of_storage;
    if (_5 != _6)
      goto <bb 3>; [70.00%]
    else
      goto <bb 4>; [30.00%]

    ...

    <bb 6> [local count: 329045359]:
    _89 = operator new (4);
    _43 = bytes.D.25336._M_impl.D.24643._M_start;
    _Num_44 = _137 - _43;
    if (_Num_44 != 0)

    but fail to see that _137 is equal to _5 and thus eventually _Num_44
    is zero if not operator new would possibly clobber the global
    bytes variable.

    The following resolves this in value-numbering by using the
    predicated values for _5 == _6 recorded for the dominating
    condition.

            PR tree-optimization/107852
            * tree-ssa-sccvn.cc (visit_phi): Use equivalences recorded
            as predicated values to elide more redundant PHIs.

            * gcc.dg/tree-ssa/ssa-fre-101.c: New testcase.

  parent reply	other threads:[~2022-11-29 13:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 23:24 [Bug tree-optimization/107852] New: " cuzdav at gmail dot com
2022-11-23 23:31 ` [Bug tree-optimization/107852] " pinskia at gcc dot gnu.org
2022-11-24  1:12 ` pinskia at gcc dot gnu.org
2022-11-24  7:07 ` rguenth at gcc dot gnu.org
2022-11-24  7:08 ` [Bug tree-optimization/107852] [12/13 Regression] " rguenth at gcc dot gnu.org
2022-11-29 11:46 ` rguenth at gcc dot gnu.org
2022-11-29 11:47 ` [Bug libstdc++/107852] " rguenth at gcc dot gnu.org
2022-11-29 12:01 ` redi at gcc dot gnu.org
2022-11-29 12:26 ` rguenth at gcc dot gnu.org
2022-11-29 13:30 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-29 13:31 ` rguenth at gcc dot gnu.org
2022-11-29 16:50 ` redi at gcc dot gnu.org
2022-11-29 17:14 ` cvs-commit at gcc dot gnu.org
2023-03-19 10:31 ` [Bug libstdc++/107852] [12 " dvirtz at gmail dot com
2023-04-20 13:57 ` cvs-commit at gcc dot gnu.org
2023-04-27 11:44 ` rguenth at gcc dot gnu.org
2023-05-01 13:12 ` pinskia at gcc dot gnu.org
2023-06-29 18:08 ` rogerio.souza at gmail dot com
2023-06-29 18:12 ` rogerio.souza at gmail dot com
2023-06-29 19:16 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-107852-4-QJAb9NoNrt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).