public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
@ 2022-11-27 18:59 pinskia at gcc dot gnu.org
2022-11-27 19:15 ` [Bug tree-optimization/107887] " pinskia at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-27 18:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Bug ID: 107887
Summary: (bool0 > bool1) | bool1 is not optimized to bool0 |
bool1
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Keywords: missed-optimization
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
Target Milestone: ---
Take:
```
_Bool max(_Bool aa, _Bool bb)
{
bool t = aa > bb;
return t | bb;
}
```
This should be optimized to just `return aa | bb;`
I accidently found this while working on PR 101805 .
The original testcase which I found it:
```
int ii(_Bool aa, _Bool bb)
{
int c;
int a = aa;
int b = bb;
if (a > b)
c = a;
else
c = b;
if (c)
return 100;
return c;
}
```
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
@ 2022-11-27 19:15 ` pinskia at gcc dot gnu.org
2022-11-28 2:33 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-27 19:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
2022-11-27 19:15 ` [Bug tree-optimization/107887] " pinskia at gcc dot gnu.org
@ 2022-11-28 2:33 ` pinskia at gcc dot gnu.org
2022-11-28 2:51 ` pinskia at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-28 2:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Last reconfirmed| |2022-11-28
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
See Also| |https://gcc.gnu.org/bugzill
| |a/show_bug.cgi?id=107881
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
There is some discussion about this in bug 107881 comment #6 on how to
implement this inside reassociation .
I am going to try to figure out how to handle this there.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
2022-11-27 19:15 ` [Bug tree-optimization/107887] " pinskia at gcc dot gnu.org
2022-11-28 2:33 ` pinskia at gcc dot gnu.org
@ 2022-11-28 2:51 ` pinskia at gcc dot gnu.org
2023-08-28 20:36 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-11-28 2:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |NEW
Assignee|pinskia at gcc dot gnu.org |unassigned at gcc dot gnu.org
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Hmm, the code of reassociation is somewhat hard to follow. So I am not going to
work on this.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2022-11-28 2:51 ` pinskia at gcc dot gnu.org
@ 2023-08-28 20:36 ` pinskia at gcc dot gnu.org
2023-08-28 21:30 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-28 20:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Bug 107887 depends on bug 107881, which changed state.
Bug 107881 Summary: (a <= b) == (b >= a) should be optimized to (a == b)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107881
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |DUPLICATE
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
` (3 preceding siblings ...)
2023-08-28 20:36 ` pinskia at gcc dot gnu.org
@ 2023-08-28 21:30 ` pinskia at gcc dot gnu.org
2023-09-12 15:03 ` pinskia at gcc dot gnu.org
2023-09-24 4:57 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-08-28 21:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Bug 107887 depends on bug 107881, which changed state.
Bug 107881 Summary: (a <= b) == (b >= a) should be optimized to (a == b)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107881
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |ASSIGNED
Resolution|DUPLICATE |---
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
` (4 preceding siblings ...)
2023-08-28 21:30 ` pinskia at gcc dot gnu.org
@ 2023-09-12 15:03 ` pinskia at gcc dot gnu.org
2023-09-24 4:57 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-09-12 15:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
Bug 107887 depends on bug 107881, which changed state.
Bug 107881 Summary: (a <= b) == (b >= a) should be optimized to (a == b)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107881
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug tree-optimization/107887] (bool0 > bool1) | bool1 is not optimized to bool0 | bool1
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
` (5 preceding siblings ...)
2023-09-12 15:03 ` pinskia at gcc dot gnu.org
@ 2023-09-24 4:57 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-09-24 4:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107887
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The bigger question on this is canonical form here, is it `a < b` or `~a & b`.
If it is `a < b` then we need the ability to match `a < b` as `~a < b` but that
might get complex with bitwise_inverted_equal_p ...
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-09-24 4:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 18:59 [Bug tree-optimization/107887] New: (bool0 > bool1) | bool1 is not optimized to bool0 | bool1 pinskia at gcc dot gnu.org
2022-11-27 19:15 ` [Bug tree-optimization/107887] " pinskia at gcc dot gnu.org
2022-11-28 2:33 ` pinskia at gcc dot gnu.org
2022-11-28 2:51 ` pinskia at gcc dot gnu.org
2023-08-28 20:36 ` pinskia at gcc dot gnu.org
2023-08-28 21:30 ` pinskia at gcc dot gnu.org
2023-09-12 15:03 ` pinskia at gcc dot gnu.org
2023-09-24 4:57 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).