public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/107897] [13 Regression] mangling conflicts with a previous mangle since r13-3601 Date: Thu, 30 Mar 2023 11:23:55 +0000 [thread overview] Message-ID: <bug-107897-4-EIGL9dfcFN@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-107897-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107897 --- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>: https://gcc.gnu.org/g:a23b33a1bdeff7bc2289d9ebb7cb7b7ec0a605f5 commit r13-6944-ga23b33a1bdeff7bc2289d9ebb7cb7b7ec0a605f5 Author: Jason Merrill <jason@redhat.com> Date: Mon Mar 6 15:33:45 2023 -0500 c++: lambda mangling alias issues [PR107897] In 107897, by the time we are looking at the mangling clash, the alias has already been removed from the symbol table by analyze_functions, so we can't look at n->cpp_implicit_alias. So just assume that it's an alias if it's internal. In 108887 the problem is that removing the mangling alias from the symbol table confuses analyze_functions, because it ended up as first_analyzed somehow, so it becomes a dangling pointer. So instead we call reset() to neutralize the alias. To make this work for variables, I needed to move reset() from cgraph_node to symtab_node. PR c++/107897 PR c++/108887 gcc/ChangeLog: * cgraph.h: Move reset() from cgraph_node to symtab_node. * cgraphunit.cc (symtab_node::reset): Adjust. Also call remove_from_same_comdat_group. gcc/cp/ChangeLog: * decl2.cc (record_mangling): Use symtab_node::reset. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/concepts-lambda3.C: Use -flto if supported. * g++.dg/cpp0x/lambda/lambda-mangle7.C: New test.
next prev parent reply other threads:[~2023-03-30 11:23 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-11-28 17:56 [Bug c++/107897] New: [13 Regression] ICE in verify_curr_properties, at passes.cc:2201 gscfq@t-online.de 2022-11-28 18:06 ` [Bug c++/107897] " pinskia at gcc dot gnu.org 2022-11-29 7:43 ` rguenth at gcc dot gnu.org 2022-11-29 9:26 ` cvs-commit at gcc dot gnu.org 2022-11-29 9:27 ` [Bug c++/107897] [13 Regression] mangling conflicts with a previous mangle rguenth at gcc dot gnu.org 2022-12-01 15:39 ` [Bug c++/107897] [13 Regression] mangling conflicts with a previous mangle since r13-3601 jakub at gcc dot gnu.org 2022-12-21 9:53 ` rguenth at gcc dot gnu.org 2023-02-02 16:12 ` jakub at gcc dot gnu.org 2023-03-06 20:01 ` jason at gcc dot gnu.org 2023-03-09 21:59 ` jason at gcc dot gnu.org 2023-03-30 11:23 ` cvs-commit at gcc dot gnu.org [this message] 2023-03-30 12:13 ` jason at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-107897-4-EIGL9dfcFN@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).