[Bug fortran/107922] New: ICE in gfc_simplify_unpack, at fortran/simplify.cc:8473

[Bug fortran/107922] New: ICE in gfc_simplify_unpack, at fortran/simplify.cc:8473

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107922

            Bug ID: 107922
           Summary: ICE in gfc_simplify_unpack, at
                    fortran/simplify.cc:8473
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to at least r5 :


$ cat z1.f90
program p
   type t
   end type
   integer, parameter :: a(2) = 1
   type(t), parameter :: b(2) = unpack(a,[.false.,.true.,.false.],a)
end


$ cat z2.f90
program p
   type t
   end type
   integer, parameter :: a(2) = 1
   type(t), parameter :: b(3) = unpack(a,[.false.,.true.,.false.],a)
end


$ gfortran-13-20221127 -c z1.f90
f951: internal compiler error: Segmentation fault
0xda00af crash_signal
        ../../gcc/toplev.cc:314
0x85b088 gfc_simplify_unpack(gfc_expr*, gfc_expr*, gfc_expr*)
        ../../gcc/fortran/simplify.cc:8473
0x7d2b3a do_simplify
        ../../gcc/fortran/intrinsic.cc:4677
0x7dda1a gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.cc:5056
0x833fe8 resolve_unknown_f
        ../../gcc/fortran/resolve.cc:2990
0x833fe8 resolve_function
        ../../gcc/fortran/resolve.cc:3347
0x833fe8 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7195
0x7c2704 gfc_reduce_init_expr(gfc_expr*)
        ../../gcc/fortran/expr.cc:3168
0x7c5690 gfc_match_init_expr(gfc_expr**)
        ../../gcc/fortran/expr.cc:3216
0x7af4fb variable_decl
        ../../gcc/fortran/decl.cc:3028
0x7af4fb gfc_match_data_decl()
        ../../gcc/fortran/decl.cc:6331
0x81bf43 match_word
        ../../gcc/fortran/parse.cc:67
0x81bf43 decode_statement
        ../../gcc/fortran/parse.cc:378
0x81d98a next_free
        ../../gcc/fortran/parse.cc:1402
0x81d98a next_statement
        ../../gcc/fortran/parse.cc:1634
0x81f3cb parse_spec
        ../../gcc/fortran/parse.cc:4190
0x8225dc parse_progunit
        ../../gcc/fortran/parse.cc:6237
0x823ca1 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6782
0x871bef gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

[Bug fortran/107922] ICE in gfc_simplify_unpack, at fortran/simplify.cc:8473

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107922

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-11-29
     Ever confirmed|0                           |1

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.

Potential patch:

diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc
index b6184181f26..24a3a9a1e90 100644
--- a/gcc/fortran/simplify.cc
+++ b/gcc/fortran/simplify.cc
@@ -8485,7 +8486,13 @@ gfc_simplify_unpack (gfc_expr *vector, gfc_expr *mask,
gfc_expr *field)
            }
        }
       else if (field->expr_type == EXPR_ARRAY)
-       e = gfc_copy_expr (field_ctor->expr);
+       if (field_ctor)
+         e = gfc_copy_expr (field_ctor->expr);
+       else
+         {
+           gfc_free_expr (result);
+           return &gfc_bad_expr;
+         }
       else
        e = gfc_copy_expr (field);

[Bug fortran/107922] ICE in gfc_simplify_unpack, at fortran/simplify.cc:8473

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107922

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2022-December/058563.html

[Bug fortran/107922] ICE in gfc_simplify_unpack, at fortran/simplify.cc:8473

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107922

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:24b9337d1f1b5197b6498dceb9074319be003449

commit r13-4486-g24b9337d1f1b5197b6498dceb9074319be003449
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Dec 1 21:16:46 2022 +0100

    Fortran: error recovery simplifying UNPACK for insufficient FIELD
[PR107922]

    gcc/fortran/ChangeLog:

            PR fortran/107922
            * simplify.cc (gfc_simplify_unpack): Terminate simplification when
            array-valued argument FIELD does not provide enough elements.

    gcc/testsuite/ChangeLog:

            PR fortran/107922
            * gfortran.dg/unpack_field_1.f90: New test.

[Bug fortran/107922] ICE in gfc_simplify_unpack, at fortran/simplify.cc:8473

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107922

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |13.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-13.  Closing.

Thanks for the report!