* [Bug tree-optimization/107946] [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
@ 2022-12-01 15:19 ` rguenth at gcc dot gnu.org
2022-12-01 15:45 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-12-01 15:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Nope, it wasn't supposed to speedup the benchmark but it indeed (with -Ofast)
causes the hot loop kernels to be unswitched.
Btw, do we know if train and ref data align up in these loops?
Btw, with -Ofast on znver2 I didn't observe any change when benchmarking this.
I'm trying to reproduce.
OK, so with -O2 -flto -march=znver2 and FDO I get a runtime of 173s while
adding -fno-unswitch-loops gets me 188s. There's currently no knob to
specifically disable outer loop unswitching so I have to instead patch
that up. With -O2 -flto -funswitch-loops (w/o FDO) I get 178s. I'm going
to add a --param to allow easier reproduction.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
2022-12-01 15:19 ` [Bug tree-optimization/107946] " rguenth at gcc dot gnu.org
@ 2022-12-01 15:45 ` rguenth at gcc dot gnu.org
2022-12-02 7:04 ` cvs-commit at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-12-01 15:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
So with --param max-unswitch-depth=1 and -O2 -flto -march=znver2 + FDO I get
176s which is slower than with unswitching outer loops.
Means I cannot reproduce (at least with this specific feature, aka this
revision).
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
2022-12-01 15:19 ` [Bug tree-optimization/107946] " rguenth at gcc dot gnu.org
2022-12-01 15:45 ` rguenth at gcc dot gnu.org
@ 2022-12-02 7:04 ` cvs-commit at gcc dot gnu.org
2022-12-02 14:40 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-12-02 7:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:5b50850c3c6f2eceb8012dcc8d3cd5ddd94fac6c
commit r13-4458-g5b50850c3c6f2eceb8012dcc8d3cd5ddd94fac6c
Author: Richard Biener <rguenther@suse.de>
Date: Thu Dec 1 16:14:14 2022 +0100
Add --param max-unswitch-depth
The following adds a --param to limit the depth of unswitched loop
nests. One can use --param max-unswitch-depth=1 to disable unswitching
of outer loops (the innermost loop will then be unswitched).
PR tree-optimization/107946
* params.opt (-param=max-unswitch-depth=): New.
* doc/invoke.texi (--param=max-unswitch-depth): Document.
* tree-ssa-loop-unswitch.cc (init_loop_unswitch_info): Honor
--param=max-unswitch-depth
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
` (2 preceding siblings ...)
2022-12-02 7:04 ` cvs-commit at gcc dot gnu.org
@ 2022-12-02 14:40 ` rguenth at gcc dot gnu.org
2023-04-26 6:57 ` [Bug tree-optimization/107946] [13/14 " rguenth at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-12-02 14:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
The data found for other machines/flags is also rather inconclusive with ups
and downs.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13/14 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
` (3 preceding siblings ...)
2022-12-02 14:40 ` rguenth at gcc dot gnu.org
@ 2023-04-26 6:57 ` rguenth at gcc dot gnu.org
2023-07-27 9:24 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-04-26 6:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|13.0 |13.2
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.1 is being released, retargeting bugs to GCC 13.2.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13/14 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
` (4 preceding siblings ...)
2023-04-26 6:57 ` [Bug tree-optimization/107946] [13/14 " rguenth at gcc dot gnu.org
@ 2023-07-27 9:24 ` rguenth at gcc dot gnu.org
2024-01-26 18:06 ` jamborm at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-07-27 9:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|13.2 |13.3
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.2 is being released, retargeting bugs to GCC 13.3.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13/14 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
` (5 preceding siblings ...)
2023-07-27 9:24 ` rguenth at gcc dot gnu.org
@ 2024-01-26 18:06 ` jamborm at gcc dot gnu.org
2024-03-08 15:40 ` law at gcc dot gnu.org
2024-05-21 9:13 ` [Bug tree-optimization/107946] [13/14/15 " jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jamborm at gcc dot gnu.org @ 2024-01-26 18:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2024-01-26
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #7 from Martin Jambor <jamborm at gcc dot gnu.org> ---
This regression is still there (as the graphs linked in the summary show).
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13/14 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
` (6 preceding siblings ...)
2024-01-26 18:06 ` jamborm at gcc dot gnu.org
@ 2024-03-08 15:40 ` law at gcc dot gnu.org
2024-05-21 9:13 ` [Bug tree-optimization/107946] [13/14/15 " jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: law at gcc dot gnu.org @ 2024-03-08 15:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
Jeffrey A. Law <law at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |law at gcc dot gnu.org
Priority|P3 |P2
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug tree-optimization/107946] [13/14/15 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0
2022-12-01 13:40 [Bug tree-optimization/107946] New: [13 Regression] 507.cactuBSSN_r regresses by ~9% on znver3 with PGO since r13-3875-g9e11ceef165bc0 marxin at gcc dot gnu.org
` (7 preceding siblings ...)
2024-03-08 15:40 ` law at gcc dot gnu.org
@ 2024-05-21 9:13 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-05-21 9:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107946
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|13.3 |13.4
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 13.3 is being released, retargeting bugs to GCC 13.4.
^ permalink raw reply [flat|nested] 10+ messages in thread