public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
@ 2022-12-05 20:30 seurer at gcc dot gnu.org
2022-12-05 20:32 ` [Bug libstdc++/107979] " seurer at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-12-05 20:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
Bug ID: 107979
Summary: [13 regression] r13-4391-g0ded30b361d2b1 causes excess
errors in 17_intro/names.cc on big endian
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: seurer at gcc dot gnu.org
Target Milestone: ---
g:0ded30b361d2b1e43048b640e9ad6fef161fe9a9, r13-4391-g0ded30b361d2b1
make -k check RUNTESTFLAGS="--target_board=unix'{-m64}'
conformance.exp=17_intro/names.cc"
FAIL: 17_intro/names.cc (test for excess errors)
# of unexpected failures 1
I am seeing this failure on powerpc64 BE systems.
spawn -ignore SIGHUP /home/seurer/gcc/git/build/gcc-test/./gcc/xg++
-shared-libgcc -B/home/seurer/gcc/git/build/gcc-test/./gcc -nostdinc++
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-B/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-test/powerpc64-unknown-linux-gnu/sys-include
-B/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/./libstdc++-v3/src/.libs
-fmessage-length=0 -fno-show-column -ffunction-sections -fdata-sections -g -O2
-D_GNU_SOURCE -DLOCALEDIR="." -nostdinc++
-I/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/include/powerpc64-unknown-linux-gnu
-I/home/seurer/gcc/git/build/gcc-test/powerpc64-unknown-linux-gnu/libstdc++-v3/include
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/libsupc++
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/include/backward
-I/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/util
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/17_intro/names.cc -m64
-D__GLIBCXX__=99999999 -fdiagnostics-plain-output -S -o names.s^M
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/17_intro/names.cc:135:
error: expected ';' at end of member declaration^M
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/17_intro/names.cc:135:
error: 'be' does not name a type; did you mean 'e'?^M
compiler exited with status 1
FAIL: 17_intro/names.cc (test for excess errors)
Excess errors:
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/17_intro/names.cc:135:
error: expected ';' at end of member declaration
/home/seurer/gcc/git/gcc-test/libstdc++-v3/testsuite/17_intro/names.cc:135:
error: 'be' does not name a type; did you mean 'e'?
commit 0ded30b361d2b1e43048b640e9ad6fef161fe9a9
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Mon Nov 28 20:48:55 2022 +0000
libstdc++: Do not use __used or __packed as identifiers
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
@ 2022-12-05 20:32 ` seurer at gcc dot gnu.org
2022-12-05 20:43 ` pinskia at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-12-05 20:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
--- Comment #1 from seurer at gcc dot gnu.org ---
Oh, also these:
FAIL: experimental/names.cc (test for excess errors)
FAIL: experimental/names.cc (test for excess errors)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
2022-12-05 20:32 ` [Bug libstdc++/107979] " seurer at gcc dot gnu.org
@ 2022-12-05 20:43 ` pinskia at gcc dot gnu.org
2022-12-05 20:45 ` pinskia at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-12-05 20:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note only glibc 2.19 and above no longer use __unused:
* The public headers no longer use __unused nor __block. This change is to
support compiling programs that are derived from BSD sources and use
__unused internally, and to support compiling with Clang's -fblock
extension which uses __block.
My bet is that this is an older glibc and we include a header glibc file which
used __unused ...
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
2022-12-05 20:32 ` [Bug libstdc++/107979] " seurer at gcc dot gnu.org
2022-12-05 20:43 ` pinskia at gcc dot gnu.org
@ 2022-12-05 20:45 ` pinskia at gcc dot gnu.org
2022-12-05 21:22 ` seurer at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-12-05 20:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
https://sourceware.org/git/?p=glibc.git;a=commit;h=d1d9eaf478b7d3a11a599c120498b79fe5629a61
was the change in glibc.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
` (2 preceding siblings ...)
2022-12-05 20:45 ` pinskia at gcc dot gnu.org
@ 2022-12-05 21:22 ` seurer at gcc dot gnu.org
2022-12-05 21:28 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-12-05 21:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
--- Comment #4 from seurer at gcc dot gnu.org ---
These systems are pretty old. So, just ignore it?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
` (3 preceding siblings ...)
2022-12-05 21:22 ` seurer at gcc dot gnu.org
@ 2022-12-05 21:28 ` redi at gcc dot gnu.org
2022-12-05 21:45 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2022-12-05 21:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2022-12-05
Status|UNCONFIRMED |NEW
--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
No need to ignore it, this should work:
--- a/libstdc++-v3/testsuite/17_intro/names.cc
+++ b/libstdc++-v3/testsuite/17_intro/names.cc
@@ -241,6 +241,11 @@
#undef y
#endif
+#if defined __GLIBC_PREREQ && ! __GLIBC_PREREQ(2, 19)
+// Glibc defines this prior to 2.19
+#undef __unused
+#endif
+
#if __has_include(<newlib.h>)
// newlib's <sys/cdefs.h> defines these as macros.
#undef __lockable
Interesting that the comment Andrew posted also mentions __block, because we
use that as a variable name in a few places. It hasn't failed so far :-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
` (4 preceding siblings ...)
2022-12-05 21:28 ` redi at gcc dot gnu.org
@ 2022-12-05 21:45 ` redi at gcc dot gnu.org
2022-12-06 21:40 ` cvs-commit at gcc dot gnu.org
2022-12-06 21:42 ` redi at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2022-12-05 21:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Status|NEW |ASSIGNED
Keywords| |testsuite-fail
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
` (5 preceding siblings ...)
2022-12-05 21:45 ` redi at gcc dot gnu.org
@ 2022-12-06 21:40 ` cvs-commit at gcc dot gnu.org
2022-12-06 21:42 ` redi at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-12-06 21:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:2a23b93f944fa78d4284eb5687051c224e5ab08f
commit r13-4528-g2a23b93f944fa78d4284eb5687051c224e5ab08f
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Mon Dec 5 21:44:26 2022 +0000
libstdc++: Fix test that fails due to name clash with old glibc [PR107979]
This test was recently modified to check that the library doesn't use
__unused anywhere, because that's a macro in newlib. But it's also a
macro in old versions of glibc, so the test now fails for those targets.
Disable that check for those targets as well as for newlib.
libstdc++-v3/ChangeLog:
PR libstdc++/107979
* testsuite/17_intro/names.cc: Do not check __unused on old
Glibc versions.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/107979] [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
` (6 preceding siblings ...)
2022-12-06 21:40 ` cvs-commit at gcc dot gnu.org
@ 2022-12-06 21:42 ` redi at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2022-12-06 21:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107979
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
This should be fixed now, I hope. Please reopen if not.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-12-06 21:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-05 20:30 [Bug libstdc++/107979] New: [13 regression] r13-4391-g0ded30b361d2b1 causes excess errors in 17_intro/names.cc on big endian seurer at gcc dot gnu.org
2022-12-05 20:32 ` [Bug libstdc++/107979] " seurer at gcc dot gnu.org
2022-12-05 20:43 ` pinskia at gcc dot gnu.org
2022-12-05 20:45 ` pinskia at gcc dot gnu.org
2022-12-05 21:22 ` seurer at gcc dot gnu.org
2022-12-05 21:28 ` redi at gcc dot gnu.org
2022-12-05 21:45 ` redi at gcc dot gnu.org
2022-12-06 21:40 ` cvs-commit at gcc dot gnu.org
2022-12-06 21:42 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).