[Bug c/107993] New: ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[Bug c/107993] New: ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

            Bug ID: 107993
           Summary: ICE: tree check: expected string_cst, have integer_cst
                    in get_target_clone_attr_len, at tree.cc:14872
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r6 :
(gcc configured with --enable-checking=yes)


$ cat z1.c
typedef union {} u;
__attribute__((target_clones("arch=alderlake",!"default")))
int f (u *x) {}


$ gcc-13-20221204 -c z1.c
z1.c:3:1: internal compiler error: tree check: expected string_cst, have
integer_cst in get_target_clone_attr_len, at tree.cc:14872
    3 | int f (u *x) {}
      | ^~~
0x6b3c56 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        ../../gcc/tree.cc:8822
0x121b83e tree_check(tree_node*, char const*, int, char const*, tree_code)
        ../../gcc/tree.h:3528
0x121b83e get_target_clone_attr_len(tree_node*)
        ../../gcc/tree.cc:14872
0x8fbf87 handle_target_clones_attribute
        ../../gcc/c-family/c-attribs.cc:5594
0x7b4a87 decl_attributes(tree_node**, tree_node*, int, tree_node*)
        ../../gcc/attribs.cc:878
0x7db93d start_function(c_declspecs*, c_declarator*, tree_node*)
        ../../gcc/c/c-decl.cc:10089
0x852e8e c_parser_declaration_or_fndef
        ../../gcc/c/c-parser.cc:2751
0x85e30f c_parser_external_declaration
        ../../gcc/c/c-parser.cc:1925
0x85ec4d c_parser_translation_unit
        ../../gcc/c/c-parser.cc:1779
0x85ec4d c_parse_file()
        ../../gcc/c/c-parser.cc:24596
0x8d85e1 c_common_parse_file()
        ../../gcc/c-family/c-opts.cc:1248

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=100504
   Last reconfirmed|                            |2022-12-06

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
So the fix for PR 100504 only checks the first arg and missed the rest ...

Confirmed.

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Mine then.

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Patch candidate:
https://gcc.gnu.org/pipermail/gcc-patches/2022-December/609060.html

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #3)
> Patch candidate:
> https://gcc.gnu.org/pipermail/gcc-patches/2022-December/609060.html

Belongs to a different PR.

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Patch candidate:
https://gcc.gnu.org/pipermail/gcc-patches/2022-December/609219.html

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:befd29d5fe15c09638f73eeeb1f8a9e62ce569ee

commit r13-5063-gbefd29d5fe15c09638f73eeeb1f8a9e62ce569ee
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Dec 27 16:31:57 2022 +0100

    c: check if target_clone attrs are all string

            PR c/107993

    gcc/c-family/ChangeLog:

            * c-attribs.cc (handle_target_clones_attribute): Check for
            string constant for all target_clone attribute values.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr107993.c: New test.

[Bug c/107993] ICE: tree check: expected string_cst, have integer_cst in get_target_clone_attr_len, at tree.cc:14872

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107993

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed for master, not planning to do a backport.