[Bug analyzer/108065] New: [13 Regression] ICE in make, at analyzer/store.cc:132

[Bug analyzer/108065] New: [13 Regression] ICE in make, at analyzer/store.cc:132

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108065

            Bug ID: 108065
           Summary: [13 Regression] ICE in make, at analyzer/store.cc:132
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc 13.0.0 20221211 snapshot (g:8f72249ff4cbd0a5c701b99ee8aa1ca9d82df046) ICEs
when compiling gcc/testsuite/gfortran.dg/bounds_check_23.f90,
gcc/testsuite/gfortran.dg/pr69739.f90,
gcc/testsuite/gfortran.dg/allocate_with_source_8.f08, and perhaps some other
Fortran testcases w/ -fanalyzer:

% aarch64-linux-gnu-gfortran-13 -fanalyzer -c
gcc/testsuite/gfortran.dg/bounds_check_23.f90
during IPA pass: analyzer
gcc/testsuite/gfortran.dg/bounds_check_23.f90:13:43:

   13 |     c = [ ( text(i:i), i = 1, len(text) ) ]
      |                                           ^
internal compiler error: in make, at analyzer/store.cc:132
0x81937b ana::binding_key::make(ana::store_manager*, ana::region const*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/store.cc:132
0x144acb1 ana::binding_cluster::maybe_get_simple_value(ana::store_manager*)
const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/store.cc:2165
0x144acb1 ana::binding_cluster::maybe_get_simple_value(ana::store_manager*)
const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/store.cc:2155
0x144d00a ana::binding_cluster::get_any_binding(ana::store_manager*,
ana::region const*) const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/store.cc:1613
0x144d00a ana::binding_cluster::get_any_binding(ana::store_manager*,
ana::region const*) const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/store.cc:1601
0x13f249e ana::region_model::get_store_value(ana::region const*,
ana::region_model_context*) const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/region-model.cc:2336
0x13f249e ana::region_model::get_store_value(ana::region const*,
ana::region_model_context*) const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/region-model.cc:2321
0x13f4a7c ana::region_model::get_rvalue(ana::path_var,
ana::region_model_context*) const
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/region-model.cc:2226
0x13f89b9 ana::region_model::on_assignment(gassign const*,
ana::region_model_context*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/region-model.cc:1100
0x13ca7d7 ana::exploded_node::on_stmt(ana::exploded_graph&, ana::supernode
const*, gimple const*, ana::program_state*, ana::uncertainty_t*,
ana::path_context*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/engine.cc:1452
0x13cd695 ana::exploded_graph::process_node(ana::exploded_node*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/engine.cc:4044
0x13ce3f2 ana::exploded_graph::process_worklist()
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/engine.cc:3447
0x13d0956 ana::impl_run_checkers(ana::logger*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/engine.cc:6098
0x13d1a26 ana::run_checkers()
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/engine.cc:6186
0x13c08d8 execute
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221211/work/gcc-13-20221211/gcc/analyzer/analyzer-pass.cc:87

[Bug analyzer/108065] [13 Regression] ICE in make, at analyzer/store.cc:132

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108065

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |13.0

[Bug analyzer/108065] [13 Regression] ICE in make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108065

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |make, at                    |make, at
                   |analyzer/store.cc:132       |analyzer/store.cc:132 since
                   |                            |r13-4529-gdfe2ef7f2b6cac70
   Last reconfirmed|                            |2022-12-12
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-4529-gdfe2ef7f2b6cac70.

[Bug analyzer/108065] [13 Regression] ICE in make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108065

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:41faa1d7beb90b235858c8a692be926642ad5559

commit r13-4710-g41faa1d7beb90b235858c8a692be926642ad5559
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Wed Dec 14 16:03:30 2022 -0500

    analyzer: don't call binding_key::make on empty regions [PR108065]

    gcc/analyzer/ChangeLog:
            PR analyzer/108065
            * region.cc (decl_region::get_svalue_for_initializer): Bail out to
            avoid calling binding_key::make with an empty region.
            * store.cc (binding_map::apply_ctor_val_to_range): Likewise.
            (binding_map::apply_ctor_pair_to_child_region): Likewise.
            (binding_cluster::bind): Likewise.
            (binding_cluster::purge_region): Likewise.
            (binding_cluster::maybe_get_compound_binding): Likewise.
            (binding_cluster::maybe_get_simple_value): Likewise.

    gcc/testsuite/ChangeLog:
            PR analyzer/108065
            * gfortran.dg/analyzer/pr108065.f90: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/108065] [13 Regression] ICE in binding_key::make with empty region since r13-4529-gdfe2ef7f2b6cac70

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108065

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |make, at                    |binding_key::make with
                   |analyzer/store.cc:132 since |empty region since
                   |r13-4529-gdfe2ef7f2b6cac70  |r13-4529-gdfe2ef7f2b6cac70
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for filing this bug, and for bisecting it.

Should be fixed by the above commit.