[Bug sanitizer/108106] New: [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[Bug sanitizer/108106] New: [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

            Bug ID: 108106
           Summary: [13 Regression] /usr/bin/ld:
                    .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32
                    against symbol `__interceptor_sigsetjmp' can not be
                    used when making a shared object; recompile with -fPIC
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tschwinge at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org,
                    liuhongt at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu
             Build: x86_64-pc-linux-gnu

Doing a standard native x86_64-pc-linux-gnu bootstrap using an oldish Ubuntu
14.04.6 '/usr/bin/ld' ("GNU ld (GNU Binutils for Ubuntu) 2.24"), I'm getting a
build failure as of recent commit
r13-4576-g2996b5c053d38d4543c9491258b051d6c032a011 "Enable hwasan for x86-64":

    /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against
symbol `__interceptor_sigsetjmp' can not be used when making a shared object;
recompile with -fPIC
    /usr/bin/ld: final link failed: Bad value
    collect2: error: ld returned 1 exit status
    make[4]: *** [libhwasan.la] Error 1
    make[4]: Leaving directory
`[...]/build-gcc/x86_64-pc-linux-gnu/libsanitizer/hwasan'
    make[3]: *** [all-recursive] Error 1
    make[3]: Leaving directory
`[...]/build-gcc/x86_64-pc-linux-gnu/libsanitizer'
    make[2]: *** [all] Error 2
    make[2]: Leaving directory
`[...]/build-gcc/x86_64-pc-linux-gnu/libsanitizer'
    make[1]: *** [all-target-libsanitizer] Error 2

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-12-15
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
We need to add a check to disable hwasan for older linkers.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 54104
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54104&action=edit
A patch

Please try this.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #3 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Comment on attachment 54104
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54104
A patch

I'm confirming the checking to work for the case reported;
'build-gcc/x86_64-pc-linux-gnu/libsanitizer/config.log':

    configure:15883: checking linker protected symbol support
    configure:15895: [...]/build-gcc/./gcc/xgcc [...] -fchecking=1 -shared
-nostartfiles -nodefaultlibs -o conftest.so conftest.s 1>&5
    /usr/bin/ld: /tmp/ccEJLiUq.o: relocation R_X86_64_PC32 against protected
symbol `foo' can not be used when making a shared object
    /usr/bin/ld: final link failed: Bad value
    collect2: error: ld returned 1 exit status
    configure:15898: $? = 1
    configure:15906: result: no

..., however, the libsanitizer build eventually still fails:

    [...]
    make[4]: Leaving directory
`[...]/build-gcc/x86_64-pc-linux-gnu/libsanitizer/tsan'
    Making all in hwasan
    /bin/bash: line 20: cd: hwasan: No such file or directory
    make[3]: *** [all-recursive] Error 1
    make[3]: Leaving directory
`[...]/build-gcc/x86_64-pc-linux-gnu/libsanitizer'
    make[2]: *** [all] Error 2
    make[2]: Leaving directory
`[...]/build-gcc/x86_64-pc-linux-gnu/libsanitizer'
    make[1]: *** [all-target-libsanitizer] Error 2
    make[1]: Leaving directory `[...]/build-gcc'
    make: *** [all] Error 2

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54104|0                           |1
        is obsolete|                            |

--- Comment #4 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 54106
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54106&action=edit
An updated patch

Try this one.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
protected visibility is almost always a bad answer for anything.
Wouldn't it be better to get rid of it in libhwasan and use something
different?
Say an hidden alias to an exported function?

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #6 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Comment on attachment 54106
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54106
An updated patch

Yes, that does resolve the the libsanitizer/HWASan build failure.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
It is about -mshared:

[hjl@gnu-cfl-3 tmp]$ cat foo.s
        jmp   __interceptor_sigsetjmp

        .globl __interceptor_sigsetjmp
__interceptor_sigsetjmp:
        nop
[hjl@gnu-cfl-3 tmp]$ as -o foo.o foo.s
[hjl@gnu-cfl-3 tmp]$ readelf -rW foo.o

There are no relocations in this file.
[hjl@gnu-cfl-3 tmp]$ as -o foo.o foo.s -mshared
[hjl@gnu-cfl-3 tmp]$ readelf -rW foo.o

Relocation section '.rela.text' at offset 0xc8 contains 1 entry:
    Offset             Info             Type               Symbol's Value 
Symbol's Name + Addend
0000000000000001  0000000100000004 R_X86_64_PLT32         0000000000000005
__interceptor_sigsetjmp - 4
[hjl@gnu-cfl-3 tmp]$ 

The assembler option:

'-mno-shared'
     On ELF target, the assembler normally optimizes out non-PLT
     relocations against defined non-weak global branch targets with
     default visibility.  The '-mshared' option tells the assembler to
     generate code which may go into a shared library where all non-weak
     global branch targets with default visibility can be preempted.
     The resulting code is slightly bigger.  This option only affects
     the handling of branch instructions.

The older assembler generates R_X86_64_PC32 relocation.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54106|0                           |1
        is obsolete|                            |

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 54114
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54114&action=edit
Add __interceptor_sigsetjmp_internal

Try this one.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #9 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Comment on attachment 54114
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54114
Add __interceptor_sigsetjmp_internal

Voilà:

    $ size
build-gcc/x86_64-pc-linux-gnu/libsanitizer/hwasan/.libs/libhwasan.so.0.0.0
       text    data     bss     dec     hex filename
     445414   16620 5381552 5843586  592a82
build-gcc/x86_64-pc-linux-gnu/libsanitizer/hwasan/.libs/libhwasan.so.0.0.0

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #10 from H.J. Lu <hjl.tools at gmail dot com> ---
A patch is posted at

https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608672.html

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:a9fbc6687faa09bf045c0fcee7960b7fef796fcc

commit r13-5610-ga9fbc6687faa09bf045c0fcee7960b7fef796fcc
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Jan 31 14:34:00 2023 -0800

    libsanitizer: cherry-pick commit 742bcbf685bc from upstream

    cherry-pick:

    742bcbf685bc compiler-rt/lib: Add .Linterceptor_sigsetjmp

            PR sanitizer/108106
            * hwasan/hwasan_setjmp_x86_64.S (__interceptor_setjmp): Jump
            to .Linterceptor_sigsetjmp instead of __interceptor_sigsetjmp.
            (__interceptor_sigsetjmp): Add a local alias,
            .Linterceptor_sigsetjmp.

[Bug sanitizer/108106] [13 Regression] /usr/bin/ld: .libs/hwasan_setjmp_x86_64.o: relocation R_X86_64_PC32 against symbol `__interceptor_sigsetjmp' can not be used when making a shared object; recompile with -fPIC

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108106

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |hjl at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
           See Also|                            |https://github.com/llvm/llv
                   |                            |m-project/issues/60426

--- Comment #12 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Thanks, H.J. Lu!