[Bug modula2/108135] New: Modula2 meets clang

[Bug modula2/108135] New: Modula2 meets clang

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

            Bug ID: 108135
           Summary: Modula2 meets clang
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

A build of gcc trunk with clang produces the following:

./../../../trunk.d1/libgm2/libm2min/../../gcc/m2/gm2-libs-min/libc.c:27:6:
warning: conflicting types for built-in function ‘abort’; expected ‘void(void)’
[-Wbuiltin-declaration-mismatch]
../../trunk.d1/gcc/m2/gm2-gcc/m2statement.cc:88:1: warning: function
'gm2_gimplify_function_node' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
../../trunk.d1/gcc/m2/m2.flex:135:45: warning: misleading indentation;
statement is not part of the previous 'else' [-Wmisleading-indentation]
../../trunk.d1/gcc/m2/m2pp.cc:554:1: warning: function 'hextree' is not needed
and will not be emitted [-Wunneeded-internal-declaration]
../../trunk.d1/gcc/m2/mc-boot/GDynamicStrings.c:1877:44: warning:
self-comparison always evaluates to false [-Wtautological-compare]
../../trunk.d1/gcc/m2/mc-boot/GDynamicStrings.c:1882:44: warning:
self-comparison always evaluates to false [-Wtautological-compare]
../../trunk.d1/gcc/m2/pge-boot/GDynamicStrings.c:1880:44: warning:
self-comparison always evaluates to false [-Wtautological-compare]
../../trunk.d1/gcc/m2/pge-boot/GDynamicStrings.c:1885:44: warning:
self-comparison always evaluates to false [-Wtautological-compare]
m2/gm2-compiler-boot/M2GCCDeclare.c:5403:13: warning: function 'AddSymToWatch'
is not needed and will not be emitted [-Wunneeded-internal-declaration]
m2/gm2-compiler-boot/M2Quads.c:10267:16: warning: variable 'Dim' set but not
used [-Wunused-but-set-variable]
m2/gm2-compiler-boot/M2Quads.c:18370:54: warning: unused parameter 'withTok'
[-Wunused-parameter]
m2/gm2-libs-boot/DynamicStrings.c:1877:44: warning: self-comparison always
evaluates to false [-Wtautological-compare]
m2/gm2-libs-boot/DynamicStrings.c:1882:44: warning: self-comparison always
evaluates to false [-Wtautological-compare]

[Bug modula2/108135] Modula2 meets clang

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-12-15
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

[Bug modula2/108135] Modula2 meets clang

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Verified these bugs and have git committed/pushed a patch.

[Bug modula2/108135] Modula2 meets clang

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing as bugfix has been git pushed.  Thanks for reporting the clang warnings
and bug.

[Bug modula2/108135] Modula2 meets clang

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Thanks for the fix. However, I still see some Clang warnings related to M2:

./m2/gm2config.h:56:9: warning: 'PACKAGE_NAME' macro redefined
[-Wmacro-redefined]
./m2/gm2config.h:59:9: warning: 'PACKAGE_STRING' macro redefined
[-Wmacro-redefined]
./m2/gm2config.h:62:9: warning: 'PACKAGE_TARNAME' macro redefined
[-Wmacro-redefined]
./m2/gm2config.h:68:9: warning: 'PACKAGE_VERSION' macro redefined
[-Wmacro-redefined]
m2/gm2-compiler-boot/M2GCCDeclare.c:5404:13: warning: function 'AddSymToWatch'
is not needed and will not be emitted [-Wunneeded-internal-declaration]
m2/gm2-compiler-boot/M2Quads.c:10291:16: warning: variable 'Dim' set but not
used [-Wunused-but-set-variable]
m2/gm2-compiler-boot/M2Quads.c:18420:54: warning: unused parameter 'withTok'
[-Wunused-parameter]

Please fix the as well.

[Bug modula2/108135] Modula2 meets clang

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaius at gcc dot gnu.org

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 54343
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54343&action=edit
Potential fix for remaining clang warnings

Here is a patch which fixes the parameter withTok, unused variable Dim and
removes all redefinitions of PACKAGE macros.

[Bug modula2/108135] Modula2 meets clang

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing as bugfixes has been git pushed.  Thanks for reporting the clang
warnings - the WITH statement has been improved from the user debugging
perspective.

[Bug modula2/108135] Modula2 meets clang

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Thanks for the fixes. However, there are still some leftovers:

/buildworker/marxinbox-gcc-clang/build/gcc/m2/gm2-lang.cc:333:15: warning:
unused variable 'opt' [-Wunused-variable]
/buildworker/marxinbox-gcc-clang/build/gcc/m2/gm2spec.cc:132:20: warning:
unused function 'add_include' [-Wunused-function]
/buildworker/marxinbox-gcc-clang/build/gcc/m2/gm2spec.cc:153:20: warning:
unused variable 'full_libraries' [-Wunused-variable]
/buildworker/marxinbox-gcc-clang/build/gcc/m2/gm2spec.cc:245:1: warning: unused
function 'concat_option' [-Wunused-function]

m2/gm2-compiler-boot/M2Preprocess.c:156:30: warning: unused function 'BaseName'
[-Wunused-function]
m2/gm2-compiler-boot/M2Search.c:131:13: warning: unused function 'DSdbEnter'
[-Wunused-function]
m2/gm2-compiler-boot/M2Search.c:141:13: warning: unused function 'DSdbExit'
[-Wunused-function]

[Bug modula2/108135] Modula2 meets clang

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:d5f933d2c046478c05b463be23021875d08dc647

commit r13-5723-gd5f933d2c046478c05b463be23021875d08dc647
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Feb 6 21:14:32 2023 +0000

    Modula2 meets clang [PR108135]

    Remove unused function (and build warnings).

    gcc/m2/ChangeLog:

            * gm2-compiler/M2Search.mod (DSdbEnter): Comment out.
            (DSdbExit): Comment out.

            PR modula2/108135

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/108135] Modula2 meets clang

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing as all unused variables and functions have been removed.

[Bug modula2/108135] Modula2 meets clang

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108135

--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Thank you for the fix, I can confirm all Modula-2-related issues are gone now.