public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug modula2/108142] New: Many empty directories created in the build directory
@ 2022-12-16 9:57 jakub at gcc dot gnu.org
2022-12-21 15:05 ` [Bug modula2/108142] " ebotcazou at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-16 9:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
Bug ID: 108142
Summary: Many empty directories created in the build directory
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: modula2
Assignee: gaius at gcc dot gnu.org
Reporter: jakub at gcc dot gnu.org
Target Milestone: ---
Seems a lot of new empty directories are created in the build directory during
toplevel configure:
stage{1,2,3,4}/m2
m2/ (lots of subdirectories)
They are created regardless of whether m2 is in --enable-languages= or not,
both when
using absolute pathnames and relative (/whatever/configure
--enable-languages=m2 or
../configure --enable-languages=m2 or ../configure --enable-languages=c etc.)
and from what I can see, they remain empty (don't contain any non-directories)
for the whole duration of build or bootstrap.
Can we get rid of those, or create them only before they'd be actually used?
And, preferably without those stage{1,2,3,4} toplevel directories at least (say
move the stages into m2/ or even gcc/m2 subdirectory of the build directory).
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
@ 2022-12-21 15:05 ` ebotcazou at gcc dot gnu.org
2022-12-22 4:27 ` gaius at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2022-12-21 15:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Target Milestone|--- |13.0
Last reconfirmed| |2022-12-21
Ever confirmed|0 |1
CC| |ebotcazou at gcc dot gnu.org
--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Seconded.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
2022-12-21 15:05 ` [Bug modula2/108142] " ebotcazou at gcc dot gnu.org
@ 2022-12-22 4:27 ` gaius at gcc dot gnu.org
2022-12-22 4:28 ` gaius at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-12-22 4:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 54145
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54145&action=edit
m2 remove empty directories from top build
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
2022-12-21 15:05 ` [Bug modula2/108142] " ebotcazou at gcc dot gnu.org
2022-12-22 4:27 ` gaius at gcc dot gnu.org
@ 2022-12-22 4:28 ` gaius at gcc dot gnu.org
2022-12-22 9:41 ` jakub at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-12-22 4:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thanks for the bug report - here is a proposed fix. I've moved all m2 related
directories into gcc/m2 and directories are now created as required.
Bootstrapped on GNU/Linux x86_64, due to the asynchronous nature of the builds
I'll test on a variety of machines before posting patches to the mailing list.
Anyway the work in progress patch follows as an attachment.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
` (2 preceding siblings ...)
2022-12-22 4:28 ` gaius at gcc dot gnu.org
@ 2022-12-22 9:41 ` jakub at gcc dot gnu.org
2022-12-22 11:59 ` gaius at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2022-12-22 9:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think pretty much nothing but m2 uses mkdir -p directly, other makefiles use
$(mkinstalldirs) (unless only a single directory needs to be created, for that
mkdir dir
is fine).
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
` (3 preceding siblings ...)
2022-12-22 9:41 ` jakub at gcc dot gnu.org
@ 2022-12-22 11:59 ` gaius at gcc dot gnu.org
2022-12-22 12:37 ` gaius at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-12-22 11:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
--- Comment #5 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Ah thanks, I'll change all uses of mkdir -p to $(mkinstalldirs).
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
` (4 preceding siblings ...)
2022-12-22 11:59 ` gaius at gcc dot gnu.org
@ 2022-12-22 12:37 ` gaius at gcc dot gnu.org
2023-01-10 1:51 ` gaius at gcc dot gnu.org
2023-01-10 18:01 ` gaius at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: gaius at gcc dot gnu.org @ 2022-12-22 12:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
--- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 54149
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54149&action=edit
m2 remove empty directories from top build (using mkinstalldirs)
The same patch as before but now using mkinstalldirs instead of mkdir -p.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
` (5 preceding siblings ...)
2022-12-22 12:37 ` gaius at gcc dot gnu.org
@ 2023-01-10 1:51 ` gaius at gcc dot gnu.org
2023-01-10 18:01 ` gaius at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-01-10 1:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
--- Comment #7 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Updated patch posted to list.
^ permalink raw reply [flat|nested] 9+ messages in thread* [Bug modula2/108142] Many empty directories created in the build directory
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
` (6 preceding siblings ...)
2023-01-10 1:51 ` gaius at gcc dot gnu.org
@ 2023-01-10 18:01 ` gaius at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-01-10 18:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108142
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #8 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Patch applied and closing.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-01-10 18:01 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-16 9:57 [Bug modula2/108142] New: Many empty directories created in the build directory jakub at gcc dot gnu.org
2022-12-21 15:05 ` [Bug modula2/108142] " ebotcazou at gcc dot gnu.org
2022-12-22 4:27 ` gaius at gcc dot gnu.org
2022-12-22 4:28 ` gaius at gcc dot gnu.org
2022-12-22 9:41 ` jakub at gcc dot gnu.org
2022-12-22 11:59 ` gaius at gcc dot gnu.org
2022-12-22 12:37 ` gaius at gcc dot gnu.org
2023-01-10 1:51 ` gaius at gcc dot gnu.org
2023-01-10 18:01 ` gaius at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).