[Bug target/108145] New: [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[Bug target/108145] New: [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

            Bug ID: 108145
           Summary: [13 regression] ICE in from_reg_br_prob_base, at
                    profile-count.h:259
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: i386-pc-solaris2.11

Between 20221214 (330b9a8d87dd73e10539da618496ad4964fee26d) and 20221216
(711e0acdbb2645f5a8aa89014488c24e89ccb0f7), Solaris/x86 bootstrap broke
building
the 64-bit gmon.o.

$ cc1 -fpreprocessed gmon.i -quiet -m64 -mtune=generic -march=x86-64 -O2 -o
gmon.s
[...]
during RTL pass: expand
/vol/gcc/src/hg/master/local/libgcc/config/sol2/gmon.c: In function
‘monstartup’:
/vol/gcc/src/hg/master/local/libgcc/config/sol2/gmon.c:150:1: internal compiler
error: in from_reg_br_prob_base, at profile-count.h:259
  150 | }
      | ^

Thread 2 hit Breakpoint 1, 0x0a514206 in fancy_abort(char const*, int, char
const*) ()
(gdb) bt
#0  0x0a514206 in fancy_abort(char const*, int, char const*) ()
#1  0x0926e3b4 in profile_probability::from_reg_br_prob_base(int) [clone
.part.0] ()
#2  0x0926ed0e in guess_outgoing_edge_probabilities(basic_block_def*) [clone
.cold] ()
#3  0x0a225ee3 in find_many_sub_basic_blocks(simple_bitmap_def*) ()
#4  0x08dca2e2 in (anonymous namespace)::pass_expand::execute(function*) ()
#5  0x0923de4f in execute_one_pass(opt_pass*) ()
#6  0x0923e795 in execute_pass_list_1(opt_pass*) ()
#7  0x0923e7de in execute_pass_list(function*, opt_pass*) ()
#8  0x08e10c74 in cgraph_node::expand() ()
#9  0x08e121a9 in symbol_table::compile() [clone .part.0] ()
#10 0x08e14b96 in symbol_table::finalize_compilation_unit() ()
#11 0x09346fe1 in compile_file() ()
#12 0x0934a28e in toplev::main(int, char**) ()
#13 0x0a4f0761 in main ()

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 54111
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54111&action=edit
preprocessed input

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at gcc dot gnu.org

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
A reghunt identified this patch

commit 12abd5a7d13209f79664ea603b3f3517f71b8c4f
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Thu Dec 15 14:11:05 2022 -0500

    IRA: Check that reg classes contain a hard reg of given mode in reg move
cost calculation

as the culprit.

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Vladimir Makarov <vmakarov@gcc.gnu.org>:

https://gcc.gnu.org/g:b50fe16a3b2214c418ecc5febc0bb21bc17912b7

commit r13-4749-gb50fe16a3b2214c418ecc5febc0bb21bc17912b7
Author: Vladimir N. Makarov <vmakarov@redhat.com>
Date:   Fri Dec 16 13:16:31 2022 -0500

    Revert "IRA: Check that reg classes contain a hard reg of given mode in reg
move cost calculation"

    The patch resulted in new PRs:

            PR target/108145
            PR testsuite/108141

    So I am reverting the patch.

    This reverts commit 12abd5a7d13209f79664ea603b3f3517f71b8c4f.

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed by reversion.

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zhendong.su at inf dot ethz.ch

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
*** Bug 108148 has been marked as a duplicate of this bug. ***

[Bug target/108145] [13 regression] ICE in from_reg_br_prob_base, at profile-count.h:259

[vmakarov at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108145

--- Comment #6 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
FYI, I think my patch did not cause this problem.

I've just check fresh trunk (w/o my patch and the compilation still fails).

So the PR probably should be still open.