[Bug analyzer/108171] New: [13 Regression] ICE in binding_key::make, at analyzer/store.cc:132

[Bug analyzer/108171] New: [13 Regression] ICE in binding_key::make, at analyzer/store.cc:132

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

            Bug ID: 108171
           Summary: [13 Regression] ICE in binding_key::make, at
                    analyzer/store.cc:132
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

Created attachment 54123
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54123&action=edit
Testcase

gcc 13.0.0 20221211 snapshot (g:fd69977febf399d1992bbf8d66ae9170e0a4dc9f) ICEs
when compiling test/f90_correct/src/wa02.f90 from the flang test suite w/
-fanalyzer:

% gfortran-13 -fanalyzer -c flang/test/f90_correct/src/wa02.f90
during IPA pass: analyzer
flang/test/f90_correct/src/wa02.f90:17:23:

   17 |         s = (/ ( i, i=1,n ) /)
      |                              ^
internal compiler error: in make, at analyzer/store.cc:132
0x7c016f ana::binding_key::make(ana::store_manager*, ana::region const*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/store.cc:132
0x1397f04 ana::binding_cluster::get_binding(ana::store_manager*, ana::region
const*) const
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/store.cc:1554
0x1398167 ana::binding_cluster::get_binding_recursive(ana::store_manager*,
ana::region const*) const
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/store.cc:1591
0x139a1b5 ana::binding_cluster::get_any_binding(ana::store_manager*,
ana::region const*) const
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/store.cc:1614
0x133ea16 ana::region_model::get_store_value(ana::region const*,
ana::region_model_context*) const
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/region-model.cc:2337
0x1340ddc ana::region_model::get_rvalue(ana::path_var,
ana::region_model_context*) const
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/region-model.cc:2227
0x1344b77 ana::region_model::on_assignment(gassign const*,
ana::region_model_context*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/region-model.cc:1101
0x1316bd4 ana::exploded_node::on_stmt(ana::exploded_graph&, ana::supernode
const*, gimple const*, ana::program_state*, ana::uncertainty_t*,
ana::path_context*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/engine.cc:1452
0x1319cb5 ana::exploded_graph::process_node(ana::exploded_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/engine.cc:4044
0x131ac6a ana::exploded_graph::process_worklist()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/engine.cc:3447
0x131d3e4 ana::impl_run_checkers(ana::logger*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/engine.cc:6098
0x131e3e6 ana::run_checkers()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/engine.cc:6186
0x130cda8 execute
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/analyzer/analyzer-pass.cc:87

[Bug analyzer/108171] [13 Regression] ICE in binding_key::make, at analyzer/store.cc:132

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
           Priority|P3                          |P4

[Bug analyzer/108171] [13 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |binding_key::make, at       |binding_key::make, at
                   |analyzer/store.cc:132       |analyzer/store.cc:132 since
                   |                            |r13-4529-gdfe2ef7f2b6cac70
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-12-19
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-4529-gdfe2ef7f2b6cac70.

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.0                        |13.2

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.1 is being released, retargeting bugs to GCC 13.2.

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[arsen at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

Arsen Arsenović <arsen at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arsen at gcc dot gnu.org

--- Comment #3 from Arsen Arsenović <arsen at gcc dot gnu.org> ---
I believe the following test case is of the same issue:

struct nl_context {
  void *cmd_private
};
struct sfeatures_context {
  int a;
  int req_mask[0]
};
set_sf_req_mask_idx;
fill_sfeatures_bitmap(struct nl_context *nlctx) {
  while (nlctx) {
    fill_legacy_flag();
    struct nl_context __trans_tmp_1 = *nlctx;
    struct sfeatures_context *sfctx = __trans_tmp_1.cmd_private;
    sfctx->req_mask[set_sf_req_mask_idx] |= 1;
  }
}
nl_sfeatures() {
  struct nl_context nlctx;
  struct sfeatures_context *sfctx;
  nlctx.cmd_private = &sfctx;
  sfctx = 0;
  fill_sfeatures_bitmap(&nlctx);
}

note that making req_mask a C99 FAM by dropping the zero makes the ICE go away

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.2                        |13.3

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 13.2 is being released, retargeting bugs to GCC 13.3.

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Possibly a dupe of PR analyzer/110882

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:f80efa49b7a1639b0d6e9bcea8cf38850d037a02

commit r14-2957-gf80efa49b7a1639b0d6e9bcea8cf38850d037a02
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu Aug 3 10:47:22 2023 -0400

    testsuite, analyzer: add test case [PR108171]

    The ICE in PR analyzer/108171 appears to be a dup of the recently fixed
    PR analyzer/110882 and is likewise fixed by it; adding this test case.

    gcc/testsuite/ChangeLog:
            PR analyzer/108171
            * gcc.dg/analyzer/pr108171.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for filing this; marking it as a duplicate.

*** This bug has been marked as a duplicate of bug 110882 ***

[Bug analyzer/108171] [13/14 Regression] ICE in binding_key::make, at analyzer/store.cc:132 since r13-4529-gdfe2ef7f2b6cac70

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108171

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by David Malcolm
<dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:44968a0e00f656e9bb3e504bb2fa1a8282002015

commit r13-8748-g44968a0e00f656e9bb3e504bb2fa1a8282002015
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Thu May 9 13:09:28 2024 -0400

    testsuite, analyzer: add test case [PR108171]

    The ICE in PR analyzer/108171 appears to be a dup of the recently fixed
    PR analyzer/110882 and is likewise fixed by it; adding this test case.

    gcc/testsuite/ChangeLog:
            PR analyzer/108171
            * gcc.dg/analyzer/pr108171.c: New test.

    (cherry picked from commit r14-2957-gf80efa49b7a163)

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>