[Bug target/108172] New: [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087

[Bug target/108172] New: [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

            Bug ID: 108172
           Summary: [13 Regression] ICE in emit_move_multi_word, at
                    expr.cc:4087
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: aarch64-linux-gnu

gcc 13.0.0 20221211 snapshot (g:fd69977febf399d1992bbf8d66ae9170e0a4dc9f) ICEs
when compiling gcc/testsuite/gcc.target/i386/pr102230.c (specifically,
v2hf_test ()):

% aarch64-linux-gnu-gcc-13 -c gcc/testsuite/gcc.target/i386/pr102230.c
during RTL pass: expand
gcc/testsuite/gcc.target/i386/pr102230.c: In function 'v2hf_test':
gcc/testsuite/gcc.target/i386/pr102230.c:34:10: internal compiler error: in
emit_move_multi_word, at expr.cc:4087
   34 |   return b;
      |          ^
0x6f51eb emit_move_multi_word
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/expr.cc:4087
0xb40d1f emit_move_insn(rtx_def*, rtx_def*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/expr.cc:4342
0xb49375 store_expr(tree_node*, rtx_def*, int, bool, bool)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/expr.cc:6519
0xb4bff8 expand_assignment(tree_node*, tree_node*, bool)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/expr.cc:6051
0xa0ff4c expand_gimple_stmt_1
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cfgexpand.cc:3946
0xa0ff4c expand_gimple_stmt
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cfgexpand.cc:4044
0xa16c5e expand_gimple_basic_block
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cfgexpand.cc:6096
0xa18647 execute
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/cfgexpand.cc:6822

[Bug target/108172] [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/108172] [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087 since r13-4616-g2cba118e538ba0

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-12-19
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |tnfchris at gcc dot gnu.org
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |emit_move_multi_word, at    |emit_move_multi_word, at
                   |expr.cc:4087                |expr.cc:4087 since
                   |                            |r13-4616-g2cba118e538ba0

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-4616-g2cba118e538ba0.

[Bug target/108172] [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087 since r13-4616-g2cba118e538ba0

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug target/108172] [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087 since r13-4616-g2cba118e538ba0

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |ktkachov at gcc dot gnu.org,
                   |                            |rearnsha at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think the problem is that while movv8hf and movv4hf expanders have just
TARGET_FLOAT
condition, movv2hf has TARGET_FLOAT && TARGET_SIMD_F16INST condition.
But aarch64_classify_vector_mode enables V2HFmode whenever TARGET_FLOAT.

So, IMHO (but what do I know about aarch64), either we need:
--- gcc/config/aarch64/aarch64.cc.jj    2022-12-14 20:30:40.492312699 +0100
+++ gcc/config/aarch64/aarch64.cc       2023-01-06 13:17:53.475412480 +0100
@@ -3634,8 +3634,9 @@ aarch64_classify_vector_mode (machine_mo
     case E_V8BFmode:
     case E_V4SFmode:
     case E_V2DFmode:
-    case E_V2HFmode:
       return TARGET_FLOAT ? VEC_ADVSIMD : 0;
+    case E_V2HFmode:
+      return TARGET_FLOAT && TARGET_SIMD_F16INST ? VEC_ADVSIMD : 0;

     default:
       return 0;
(which fixes the ICE but haven't tested it in any way further) or movv2hf needs
to work even for plain TARGET_FLOAT && !TARGET_SIMD_F16INST.

[Bug target/108172] [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087 since r13-4616-g2cba118e538ba0

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |tnfchris at gcc dot gnu.org

--- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
A patch was already submitted for this, I just need to respin it.

[Bug target/108172] [13 Regression] ICE in emit_move_multi_word, at expr.cc:4087 since r13-4616-g2cba118e538ba0

[tnfchris at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108172

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Actually I don't really have the time right now for what the reviewer wanted.
so reverted with g:a40c22c377c7cc657b0feaf0119d84d0d142a318 and will resubmit
next year.