[Bug target/108174] New: ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[Bug target/108174] New: ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

            Bug ID: 108174
           Summary: ICE: tree check: expected function_type or
                    method_type, have ggc_freed in
                    aarch64_resolve_overloaded_memtag, at
                    config/aarch64/aarch64-builtins.cc:3349
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: aarch64-linux-gnu

gcc 13.0.0 20221211 snapshot (g:fd69977febf399d1992bbf8d66ae9170e0a4dc9f) ICEs
when compiling gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c w/
-march=armv9-a+memtag -std=c2x -fopenmp -g --param ggc-min-expand=3 --param
ggc-min-heapsize=1 (but these options seem to be host or target-dependent).
Full compiler output with Valgrind report is attached, as it is a bit bulky to
post it inline. I've tried to reduce the testcase, but could remove only a
couple of lines.

% aarch64-linux-gnu-gcc-13 -march=armv9-a+memtag -std=c2x -fopenmp -g -w
--param ggc-min-expand=3 --param ggc-min-heapsize=1 -c
gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c
<diagnostics trimmed>
gcc/testsuite/gcc.target/aarch64/acle/memtag_2.c:67:3: internal compiler error:
tree check: expected function_type or method_type, have ggc_freed in
aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349
   67 |   __arm_mte_ptrdiff(no_decl2, 0);       /* { dg-error {} } */
      |   ^~~~~~~~~~~~~~~~~
0x7c8d41 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/tree.cc:8822
0x7ef700 tree_check2(tree_node*, char const*, int, char const*, tree_code,
tree_code)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/tree.h:3547
0x7ef700 aarch64_resolve_overloaded_memtag
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/config/aarch64/aarch64-builtins.cc:3349
0x7ef700 aarch64_resolve_overloaded_builtin_general(unsigned int, tree_node*,
void*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/config/aarch64/aarch64-builtins.cc:3432
0x9b95ce aarch64_resolve_overloaded_builtin
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/config/aarch64/aarch64-c.cc:317
0x8d51c7 c_build_function_call_vec(unsigned int, vec<unsigned int, va_heap,
vl_ptr> const&, tree_node*, vec<tree_node*, va_gc, vl_embed>*, vec<tree_node*,
va_gc, vl_embed>*)
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-typeck.cc:3383
0x8f6511 c_parser_postfix_expression_after_primary
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:11245
0x8ec4d4 c_parser_postfix_expression
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:10857
0x8f09da c_parser_unary_expression
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:8840
0x8f257b c_parser_cast_expression
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:8681
0x8f2872 c_parser_binary_expression
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:8449
0x8f3d0e c_parser_conditional_expression
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:8147
0x8f4557 c_parser_expr_no_commas
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:8061
0x8f4821 c_parser_expression
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:11385
0x8f4feb c_parser_expression_conv
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:11425
0x8e9957 c_parser_statement_after_labels
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:6790
0x8ebeb4 c_parser_compound_statement_nostart
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:6305
0x912224 c_parser_compound_statement
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:6114
0x9143d1 c_parser_declaration_or_fndef
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:2850
0x91bf53 c_parser_external_declaration
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-13.0.0_p20221218/work/gcc-13-20221218/gcc/c/c-parser.cc:1925

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #1 from Arseny Solokha <asolokha at gmx dot com> ---
Created attachment 54124
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54124&action=edit
Full compiler log with Valgrind report

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Please attach pre-processed source file.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #3 from Arseny Solokha <asolokha at gmx dot com> ---
Created attachment 54127
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54127&action=edit
Preprocessed testcase

Though for that to ICE, I have to change an argument to --param ggc-min-expand
from 3 to 1.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Arseny Solokha from comment #3)
> Created attachment 54127 [details]
> Preprocessed testcase
> 
> Though for that to ICE, I have to change an argument to --param
> ggc-min-expand from 3 to 1.

Right, most likely a variable or some source is not marked with GTY.
Usually `--param ggc-min-expand=0 --param ggc-min-heapsize=0` Will always cause
the ICE; though this can be slow as gc is a mark and sweep and marking can be
slow.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |14.0

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This still fails ...

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-02-29
             Status|UNCONFIRMED                 |NEW

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Reduced testcase:
```
void g(void)
{
  const char *c;
  __builtin_aarch64_memtag_inc_tag(c , 0 );
}
void h(void)
{
  const char *c;
  __builtin_aarch64_memtag_inc_tag( c,0);
}

```

Compile with `-march=armv9-a+memtag  --param ggc-min-expand=0 --param
ggc-min-heapsize=0`.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code,        |ice-on-valid-code
                   |needs-reduction             |
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
3705      tree inittype = aarch64_memtag_builtin_data[
3706                        fcode - AARCH64_MEMTAG_BUILTIN_START - 1].ftype;
3707      unsigned arg_num = list_length (TYPE_ARG_TYPES (inittype)) - 1;


/* Initialize the memory tagging extension (MTE) builtins.  */
struct
{
  tree ftype;
  enum insn_code icode;
} aarch64_memtag_builtin_data[AARCH64_MEMTAG_BUILTIN_END -
                              AARCH64_MEMTAG_BUILTIN_START - 1];


Yes this is definitely missing a GTY on it ...

Mine.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It should also be static too.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #8)
> It should also be static too.

Well the struct is anonymous so it will be static linkage by C++ rules.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #9)
> (In reply to Andrew Pinski from comment #8)
> > It should also be static too.
> 
> Well the struct is anonymous so it will be static linkage by C++ rules.

But that static is needed for GTY marking :).

So the fix is:
```
diff --git a/gcc/config/aarch64/aarch64-builtins.cc
b/gcc/config/aarch64/aarch64-builtins.cc
index 9b23b6b8c33..2bead96cbd6 100644
--- a/gcc/config/aarch64/aarch64-builtins.cc
+++ b/gcc/config/aarch64/aarch64-builtins.cc
@@ -1839,7 +1839,7 @@ aarch64_init_prefetch_builtin (void)
 }

 /* Initialize the memory tagging extension (MTE) builtins.  */
-struct
+static GTY(()) struct GTY(())
 {
   tree ftype;
   enum insn_code icode;

```

Will commit in a few minutes.

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:5ec7740496a6908b32cd058c0520a2bd5a689bb5

commit r14-9235-g5ec7740496a6908b32cd058c0520a2bd5a689bb5
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Wed Feb 28 22:39:32 2024 -0800

    aarch64: Fix memtag builtins vs GC [PR108174]

    The memtag builtins were being GC'ed away so we end up
    with a crash sometimes (maybe even wrong code).
    This fixes that issue by adding GTY on the variable/struct
    aarch64_memtag_builtin_data.

    Committed as obvious after a build/test for aarch64-linux-gnu.

            PR target/108174

    gcc/ChangeLog:

            * config/aarch64/aarch64-builtins.cc (aarch64_memtag_builtin_data):
Make
            static and mark with GTY.

    gcc/testsuite/ChangeLog:

            * gcc.target/aarch64/acle/memtag_4.c: New test.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:df00dc3f38749cf2e3ca39632f97c1ff5d50d810

commit r13-8369-gdf00dc3f38749cf2e3ca39632f97c1ff5d50d810
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Wed Feb 28 22:39:32 2024 -0800

    aarch64: Fix memtag builtins vs GC [PR108174]

    The memtag builtins were being GC'ed away so we end up
    with a crash sometimes (maybe even wrong code).
    This fixes that issue by adding GTY on the variable/struct
    aarch64_memtag_builtin_data.

    Committed as obvious after a build/test for aarch64-linux-gnu.

            PR target/108174

    gcc/ChangeLog:

            * config/aarch64/aarch64-builtins.cc (aarch64_memtag_builtin_data):
Make
            static and mark with GTY.

    gcc/testsuite/ChangeLog:

            * gcc.target/aarch64/acle/memtag_4.c: New test.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
    (cherry picked from commit 5ec7740496a6908b32cd058c0520a2bd5a689bb5)

[Bug target/108174] ICE: tree check: expected function_type or method_type, have ggc_freed in aarch64_resolve_overloaded_memtag, at config/aarch64/aarch64-builtins.cc:3349

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108174

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #13 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed for 13.3.0 and 14.1.0.