public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug target/108184] New: rs6000: Use optimize_function_for_speed_p too early @ 2022-12-20 3:01 linkw at gcc dot gnu.org 2022-12-20 3:04 ` [Bug target/108184] " linkw at gcc dot gnu.org ` (3 more replies) 0 siblings, 4 replies; 5+ messages in thread From: linkw at gcc dot gnu.org @ 2022-12-20 3:01 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108184 Bug ID: 108184 Summary: rs6000: Use optimize_function_for_speed_p too early Product: gcc Version: 13.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: target Assignee: unassigned at gcc dot gnu.org Reporter: linkw at gcc dot gnu.org Target Milestone: --- In the review of patch [1] for PR105818, Honza pointed out "I think we should generally avoid doing decisions about size/speed optimizations so early since the setting may change due to attributes or profile feedback..." I agreed that the current uses of optimize_function_for_speed_p in function rs6000_option_override_internal are too early and can be inaccurate. I tried to make the below test case to demonstrate it. Compiled with -mdejagnu-tune=power8 -O3: __attribute__ ((cold)) int fusion_short (short *p) { return p[0x12345]; } Since the function is attributed with cold, it's considered not to optimize for speed, so we shouldn't break the sign extended loads and fuse it with the addis, that is it's unexpected to see extsh generated but we have: addis 3,3,0x2 lhz 3,18058(3) extsh 3,3 [1] https://gcc.gnu.org/pipermail/gcc-patches/2022-November/607527.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/108184] rs6000: Use optimize_function_for_speed_p too early 2022-12-20 3:01 [Bug target/108184] New: rs6000: Use optimize_function_for_speed_p too early linkw at gcc dot gnu.org @ 2022-12-20 3:04 ` linkw at gcc dot gnu.org 2023-04-26 6:57 ` rguenth at gcc dot gnu.org ` (2 subsequent siblings) 3 siblings, 0 replies; 5+ messages in thread From: linkw at gcc dot gnu.org @ 2022-12-20 3:04 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108184 Kewen Lin <linkw at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target| |powerpc*-linux-gnu Ever confirmed|0 |1 CC| |bergner at gcc dot gnu.org, | |hubicka at gcc dot gnu.org, | |segher at gcc dot gnu.org Assignee|unassigned at gcc dot gnu.org |linkw at gcc dot gnu.org Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2022-12-20 Target Milestone|--- |13.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/108184] rs6000: Use optimize_function_for_speed_p too early 2022-12-20 3:01 [Bug target/108184] New: rs6000: Use optimize_function_for_speed_p too early linkw at gcc dot gnu.org 2022-12-20 3:04 ` [Bug target/108184] " linkw at gcc dot gnu.org @ 2023-04-26 6:57 ` rguenth at gcc dot gnu.org 2023-07-27 9:24 ` rguenth at gcc dot gnu.org 2024-05-21 9:13 ` jakub at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: rguenth at gcc dot gnu.org @ 2023-04-26 6:57 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108184 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|13.0 |13.2 --- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> --- GCC 13.1 is being released, retargeting bugs to GCC 13.2. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/108184] rs6000: Use optimize_function_for_speed_p too early 2022-12-20 3:01 [Bug target/108184] New: rs6000: Use optimize_function_for_speed_p too early linkw at gcc dot gnu.org 2022-12-20 3:04 ` [Bug target/108184] " linkw at gcc dot gnu.org 2023-04-26 6:57 ` rguenth at gcc dot gnu.org @ 2023-07-27 9:24 ` rguenth at gcc dot gnu.org 2024-05-21 9:13 ` jakub at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: rguenth at gcc dot gnu.org @ 2023-07-27 9:24 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108184 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|13.2 |13.3 --- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> --- GCC 13.2 is being released, retargeting bugs to GCC 13.3. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/108184] rs6000: Use optimize_function_for_speed_p too early 2022-12-20 3:01 [Bug target/108184] New: rs6000: Use optimize_function_for_speed_p too early linkw at gcc dot gnu.org ` (2 preceding siblings ...) 2023-07-27 9:24 ` rguenth at gcc dot gnu.org @ 2024-05-21 9:13 ` jakub at gcc dot gnu.org 3 siblings, 0 replies; 5+ messages in thread From: jakub at gcc dot gnu.org @ 2024-05-21 9:13 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108184 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|13.3 |13.4 --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> --- GCC 13.3 is being released, retargeting bugs to GCC 13.4. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-21 9:13 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-12-20 3:01 [Bug target/108184] New: rs6000: Use optimize_function_for_speed_p too early linkw at gcc dot gnu.org 2022-12-20 3:04 ` [Bug target/108184] " linkw at gcc dot gnu.org 2023-04-26 6:57 ` rguenth at gcc dot gnu.org 2023-07-27 9:24 ` rguenth at gcc dot gnu.org 2024-05-21 9:13 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).