[Bug c/108224] New: Suggest stdlib.h header for rand

[Bug c/108224] New: Suggest stdlib.h header for rand

[jg at jguk dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

            Bug ID: 108224
           Summary: Suggest stdlib.h header for rand
           Product: gcc
           Version: 12.2.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jg at jguk dot org
  Target Milestone: ---

Would be great if the suggestions could suggest <stdlib.h> for rand()
Same in C and C++

[Bug c/108224] Suggest stdlib.h header for rand

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

[Bug c/108224] Suggest stdlib.h header for rand

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-12-25
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
Simple testcase:
int f(void)
{
  return rand();
}

[Bug c/108224] Suggest stdlib.h header for rand

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
diff --git a/gcc/c-family/known-headers.cc b/gcc/c-family/known-headers.cc
index 9c256173b82..dd4c23e5923 100644
--- a/gcc/c-family/known-headers.cc
+++ b/gcc/c-family/known-headers.cc
@@ -171,6 +171,8 @@ get_stdlib_header_for_name (const char *name, enum stdlib
lib)
     {"getenv", {"<stdlib.h>", "<cstdlib>"} },
     {"malloc", {"<stdlib.h>", "<cstdlib>"} },
     {"realloc", {"<stdlib.h>", "<cstdlib>"} },
+    {"rand", {"<stdlib.h>", "<cstdlib>"} },
+    {"srand", {"<stdlib.h>", "<cstdlib>"} },

     /* <string.h> and <cstring>.  */
     {"memchr", {"<string.h>", "<cstring>"} },


Should be enough for both C and C++.

[Bug c/108224] Suggest stdlib.h header for rand

[jg at jguk dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

--- Comment #3 from Jonny Grant <jg at jguk dot org> ---
Great! I just saw it is the same for random(), srandom(), initstate(),
setstate()

Is there an easy way to add them all based on the C API to save opening
separate tickets?

I added those :

From 6ff344979af46dbcd739dd9068d6d595547e4c27 Mon Sep 17 00:00:00 2001
From: Jonathan Grant <jg@jguk.org>
Date: Sun, 25 Dec 2022 22:38:44 +0000
Subject: [PATCH] add srandom random initstate setstate

---
 gcc/c-family/known-headers.cc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gcc/c-family/known-headers.cc b/gcc/c-family/known-headers.cc
index 9c256173b82..ade9fa2dcc0 100644
--- a/gcc/c-family/known-headers.cc
+++ b/gcc/c-family/known-headers.cc
@@ -171,6 +171,10 @@ get_stdlib_header_for_name (const char *name, enum stdlib
lib)
     {"getenv", {"<stdlib.h>", "<cstdlib>"} },
     {"malloc", {"<stdlib.h>", "<cstdlib>"} },
     {"realloc", {"<stdlib.h>", "<cstdlib>"} },
+    {"random", {"<stdlib.h>", "<cstdlib>"} },
+    {"srandom", {"<stdlib.h>", "<cstdlib>"} },
+    {"initstate", {"<stdlib.h>", "<cstdlib>"} },
+    {"setstate", {"<stdlib.h>", "<cstdlib>"} },

     /* <string.h> and <cstring>.  */
     {"memchr", {"<string.h>", "<cstring>"} },
-- 
2.37.2

[Bug c/108224] Suggest stdlib.h header for rand

[sam at gentoo dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

Sam James <sam at gentoo dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sam at gentoo dot org

--- Comment #4 from Sam James <sam at gentoo dot org> ---
(In reply to Jonny Grant from comment #3)
> Great! I just saw it is the same for random(), srandom(), initstate(),
> setstate()
> 
> Is there an easy way to add them all based on the C API to save opening
> separate tickets?
> 
> I added those :

Could you send the patch to gcc-patches (the mailing list)? Thanks.

[Bug c/108224] Suggest stdlib.h header for rand

[jg at jguk dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

--- Comment #5 from Jonny Grant <jg at jguk dot org> ---
(In reply to Sam James from comment #4)
> (In reply to Jonny Grant from comment #3)
> > Great! I just saw it is the same for random(), srandom(), initstate(),
> > setstate()
> > 
> > Is there an easy way to add them all based on the C API to save opening
> > separate tickets?
> > 
> > I added those :
> 
> Could you send the patch to gcc-patches (the mailing list)? Thanks.

Sure, just sent :-)

[Bug c/108224] Suggest stdlib.h header for rand

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108224

Sam James <sjames at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmalcolm at gcc dot gnu.org

--- Comment #6 from Sam James <sjames at gcc dot gnu.org> ---
https://inbox.sourceware.org/gcc-patches/881e795d-34c8-0445-74cf-cb68192d2dfe@jguk.org/