[Bug rtl-optimization/108263] New: [13 Regression] ICE building Linux kernel on ppc64le

[Bug rtl-optimization/108263] New: [13 Regression] ICE building Linux kernel on ppc64le

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108263

            Bug ID: 108263
           Summary: [13 Regression] ICE building Linux kernel on ppc64le
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

int v, *p;

void
foo (void)
{
  int i;
  for (i = 0;; i++)
    {
      if (v)
        {
          __label__ l1;
          asm goto ("" : : : : l1);
        l1:
          return;
        }
      if (p[i])
        break;
    }
  asm goto ("" : : "r" (i) : : l2);
l2:
}

ICEs with -O2 on powerpc64le-linux:
kernel-ice.i: In function ‘foo’:
kernel-ice.i:21:1: error: in basic block 9:
   21 | }
      | ^
kernel-ice.i:21:1: error: flow control insn inside a basic block
(jump_insn 84 3 87 9 (parallel [
            (asm_operands/v ("") ("") 0 [
                    (reg/v:SI 10 10 [orig:120 i ] [120])
                ]
                 [
                    (asm_input:SI ("r") kernel-ice.i:19)
                ]
                 [
                    (label_ref:DI 42)
                ] kernel-ice.i:19)
            (clobber (reg:SI 98 ca))
        ]) "kernel-ice.i":19:3 -1
     (expr_list:REG_DEAD (reg/v:SI 10 10 [orig:120 i ] [120])
        (expr_list:REG_UNUSED (reg:SI 98 ca)
            (nil)))
 -> 42)
during RTL pass: bbro
kernel-ice.i:21:1: internal compiler error: in rtl_verify_bb_insns, at
cfgrtl.cc:2797

[Bug rtl-optimization/108263] [13 Regression] ICE building Linux kernel on ppc64le

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108263

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
           Priority|P3                          |P1

[Bug rtl-optimization/108263] [13 Regression] ICE building Linux kernel on ppc64le

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108263

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-01-02

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54174
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54174&action=edit
gcc13-pr108263.patch

Untested fix.

[Bug rtl-optimization/108263] [13 Regression] ICE building Linux kernel on ppc64le

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108263

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:4fb639a7fee5df32a2d1e7afa40fdf31d280464b

commit r13-4974-g4fb639a7fee5df32a2d1e7afa40fdf31d280464b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 3 12:12:35 2023 +0100

    cfgrtl: Don't try to redirect asm goto to EXIT [PR108263]

    The following testcase distilled from Linux kernel on ppc64le ICEs,
    because fixup_reorder_chain sees a bb with a single fallthru edge
    falling into a bb with simple return and decides to redirect
    that fallthru edge to EXIT.  That is possible if the bb ending
    in the fallthru edge doesn't end with a jump or ends with a normal
    unconditional jump, but not when the bb ends with asm goto which can
despite
    a single fallthru have multiple labels to the fallthrough basic block.

    The following patch makes sure we never try to redirect such cases to EXIT.

    2023-01-03  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/108263
            * cfgrtl.cc (fixup_reorder_chain): Avoid trying to redirect
            asm goto to EXIT.

            * gcc.dg/pr108263.c: New test.

[Bug rtl-optimization/108263] [13 Regression] ICE building Linux kernel on ppc64le

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108263

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.