[Bug libstdc++/108265] New: chrono::hh_mm_ss can't be constructed from unsigned durations

[Bug libstdc++/108265] New: chrono::hh_mm_ss can't be constructed from unsigned durations

[mwd at md5i dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

            Bug ID: 108265
           Summary: chrono::hh_mm_ss can't be constructed from unsigned
                    durations
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mwd at md5i dot com
  Target Milestone: ---

chrono::hh_mm_ss can't be constructed from unsigned durations.

For example:

  #include <chrono>

  int main()
  {
    std::chrono::duration<unsigned> dur{};
    auto hms = std::chrono::hh_mm_ss(dur);
  }

This fails because the hh_mm_ss constructor calls chrono::abs on the passed in
duration, and chrono::abs doesn't participate in overload resolution when the
duration is unsigned.

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
   Last reconfirmed|                            |2023-01-04
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Target Milestone|---                         |11.4

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:e36e57b032b2d70eaa1294d5921e4fd8ce12a74d

commit r13-5002-ge36e57b032b2d70eaa1294d5921e4fd8ce12a74d
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jan 4 16:43:51 2023 +0000

    libstdc++: Fix std::chrono::hh_mm_ss with unsigned rep [PR108265]

    libstdc++-v3/ChangeLog:

            PR libstdc++/108265
            * include/std/chrono (hh_mm_ss): Do not use chrono::abs if
            duration rep is unsigned.
            * testsuite/std/time/hh_mm_ss/1.cc: Check unsigned rep.

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk so far.

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:ebb1f6d14c2fef2e4e4aab30525279524c8f9145

commit r12-9030-gebb1f6d14c2fef2e4e4aab30525279524c8f9145
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jan 4 16:43:51 2023 +0000

    libstdc++: Fix std::chrono::hh_mm_ss with unsigned rep [PR108265]

    libstdc++-v3/ChangeLog:

            PR libstdc++/108265
            * include/std/chrono (hh_mm_ss): Do not use chrono::abs if
            duration rep is unsigned. Remove incorrect noexcept-specifier.
            * testsuite/std/time/hh_mm_ss/1.cc: Check unsigned rep. Check
            floating-point representations. Check default construction.

    (cherry picked from commit e36e57b032b2d70eaa1294d5921e4fd8ce12a74d)

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
and for 12.3

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:126ffcee89cf3f252c0c89125a64fbe1b0b9255e

commit r11-10767-g126ffcee89cf3f252c0c89125a64fbe1b0b9255e
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jan 4 16:43:51 2023 +0000

    libstdc++: Fix std::chrono::hh_mm_ss with unsigned rep [PR108265]

    libstdc++-v3/ChangeLog:

            PR libstdc++/108265
            * include/std/chrono (hh_mm_ss): Do not use chrono::abs if
            duration rep is unsigned. Remove incorrect noexcept-specifier.
            * testsuite/std/time/hh_mm_ss/1.cc: Check unsigned rep. Check
            floating-point representations. Check default construction.

    (cherry picked from commit e36e57b032b2d70eaa1294d5921e4fd8ce12a74d)

[Bug libstdc++/108265] chrono::hh_mm_ss can't be constructed from unsigned durations

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108265

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
And now for 11.4 too.