[Bug target/108272] New: [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[Bug target/108272] New: [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

            Bug ID: 108272
           Summary: [13 Regression] ICE in gen_movxo, at
                    config/rs6000/mma.md:339
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
                CC: linkw at gcc dot gnu.org
  Target Milestone: ---
            Target: powerpc-*-linux-gnu

This issue was originally reported in PR106736 comment 14.

gcc 13.0.0 20221225 snapshot (g:febb58d28bfa4b544ec7ffec2d61f46d25205ff0) ICEs
when compiling gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c:

% powerpc-e300c3-linux-gnu-gcc-13 -c
gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c
gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c: In function 'foo1':
gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c:20:10: warning: GCC vector
returned by reference: non-standard ABI extension with no compatibility
guarantee [-Wpsabi]
   20 |   vec[1] = __builtin_vsx_xvcvspbf16 (vec[0]);
      |   ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
during RTL pass: expand
gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c: In function 'foo0':
gcc/testsuite/gcc.target/powerpc/mma-builtin-3.c:9:3: internal compiler error:
in gen_movxo, at config/rs6000/mma.md:339
    9 |   asm ("#..." : "=d" (acc));
      |   ^~~
0x780433 gen_movxo(rtx_def*, rtx_def*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/config/rs6000/mma.md:339
0xa767b7 rtx_insn* insn_gen_fn::operator()<rtx_def*, rtx_def*>(rtx_def*,
rtx_def*) const
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/recog.h:407
0xa767b7 emit_move_insn_1(rtx_def*, rtx_def*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/expr.cc:4172
0xa76bbf emit_move_insn(rtx_def*, rtx_def*)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/expr.cc:4342
0xa7ef4e store_expr(tree_node*, rtx_def*, int, bool, bool)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/expr.cc:6519
0xa81703 expand_assignment(tree_node*, tree_node*, bool)
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/expr.cc:6051
0x9479f7 expand_asm_stmt
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/cfgexpand.cc:3345
0x94bd29 expand_gimple_stmt_1
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/cfgexpand.cc:3877
0x94bd29 expand_gimple_stmt
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/cfgexpand.cc:4044
0x951d4e expand_gimple_basic_block
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/cfgexpand.cc:6096
0x953866 execute
       
/var/tmp/portage/cross-powerpc-e300c3-linux-gnu/gcc-13.0.0_p20221225/work/gcc-13-20221225/gcc/cfgexpand.cc:6822

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-01-03
                 CC|                            |segher at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |linkw at gcc dot gnu.org
   Target Milestone|---                         |13.0

--- Comment #1 from Kewen Lin <linkw at gcc dot gnu.org> ---
Confirmed!  Thanks for reporting!  Need to teach function
rs6000_opaque_type_invalid_use_p about gasm, as the failed case shows, there is
this kind of actual test case to use opaque type in inline asm statement.

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #2 from Kewen Lin <linkw at gcc dot gnu.org> ---
Created attachment 54192
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54192&action=edit
untested patch

Hi @Arseny, I hope this patch can help to clear all the ICEs about unexpected
uses of MMA opaque types in inline asm, that is to filter those noises
duplicated to this bug.

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #3 from Arseny Solokha <asolokha at gmx dot com> ---
(In reply to Kewen Lin from comment #2)
> Created attachment 54192 [details]
> untested patch
> 
> Hi @Arseny, I hope this patch can help to clear all the ICEs about
> unexpected uses of MMA opaque types in inline asm, that is to filter those
> noises duplicated to this bug.

Indeed, I haven't seen such ICEs w/ the patch applied so far. Still get an ICE
in gen_movoo, at config/rs6000/mma.md:292 when compiling
gcc/testsuite/gcc.target/powerpc/pr96506-1.c w/ -m32, though. Do you want me to
file another PR for that one?

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #4 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Arseny Solokha from comment #3)
> (In reply to Kewen Lin from comment #2)
> > Created attachment 54192 [details]
> > untested patch
> > 
> > Hi @Arseny, I hope this patch can help to clear all the ICEs about
> > unexpected uses of MMA opaque types in inline asm, that is to filter those
> > noises duplicated to this bug.
> 
> Indeed, I haven't seen such ICEs w/ the patch applied so far. Still get an
> ICE in gen_movoo, at config/rs6000/mma.md:292 when compiling
> gcc/testsuite/gcc.target/powerpc/pr96506-1.c w/ -m32, though. Do you want me
> to file another PR for that one?

Thanks @Arseny!  Yes, please file a new one. Thanks again.

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #5 from Arseny Solokha <asolokha at gmx dot com> ---
(In reply to Kewen Lin from comment #4)
> Yes, please file a new one. Thanks again.

I've filed PR108348 for that.

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:074b0c03eabeb8e9c8de813c81bf87a1f88fdb65

commit r13-5184-g074b0c03eabeb8e9c8de813c81bf87a1f88fdb65
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Mon Jan 16 02:15:39 2023 -0600

    rs6000: Teach rs6000_opaque_type_invalid_use_p about inline asm [PR108272]

    As PR108272 shows, there are some invalid uses of MMA opaque
    types in inline asm statements.  This patch is to teach the
    function rs6000_opaque_type_invalid_use_p for inline asm,
    check and error any invalid use of MMA opaque types in input
    and output operands.

            PR target/108272

    gcc/ChangeLog:

            * config/rs6000/rs6000.cc (rs6000_opaque_type_invalid_use_p): Add
the
            support for invalid uses in inline asm, factor out the checking and
            erroring to lambda function check_and_error_invalid_use.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/pr108272-1.c: New test.
            * gcc.target/powerpc/pr108272-2.c: New test.
            * gcc.target/powerpc/pr108272-3.c: New test.
            * gcc.target/powerpc/pr108272-4.c: New test.

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:e5a63c986978699a25f4bfb9b58a0111951e7d43

commit r12-9168-ge5a63c986978699a25f4bfb9b58a0111951e7d43
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Mon Jan 16 02:15:39 2023 -0600

    rs6000: Teach rs6000_opaque_type_invalid_use_p about inline asm [PR108272]

    As PR108272 shows, there are some invalid uses of MMA opaque
    types in inline asm statements.  This patch is to teach the
    function rs6000_opaque_type_invalid_use_p for inline asm,
    check and error any invalid use of MMA opaque types in input
    and output operands.

            PR target/108272

    gcc/ChangeLog:

            * config/rs6000/rs6000.cc (rs6000_opaque_type_invalid_use_p): Add
the
            support for invalid uses in inline asm, factor out the checking and
            erroring to lambda function check_and_error_invalid_use.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/pr108272-1.c: New test.
            * gcc.target/powerpc/pr108272-2.c: New test.
            * gcc.target/powerpc/pr108272-3.c: New test.
            * gcc.target/powerpc/pr108272-4.c: New test.

    (cherry picked from commit 074b0c03eabeb8e9c8de813c81bf87a1f88fdb65)

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:79a81d526babb6ffb6d85b4a05b29269470ab49d

commit r11-10521-g79a81d526babb6ffb6d85b4a05b29269470ab49d
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Mon Jan 16 02:15:39 2023 -0600

    rs6000: Teach rs6000_opaque_type_invalid_use_p about inline asm [PR108272]

    As PR108272 shows, there are some invalid uses of MMA opaque
    types in inline asm statements.  This patch is to teach the
    function rs6000_opaque_type_invalid_use_p for inline asm,
    check and error any invalid use of MMA opaque types in input
    and output operands.

            PR target/108272

    gcc/ChangeLog:

            * config/rs6000/rs6000.c (rs6000_opaque_type_invalid_use_p): Add
the
            support for invalid uses in inline asm, factor out the checking and
            erroring to lambda function check_and_error_invalid_use.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/pr108272-1.c: New test.
            * gcc.target/powerpc/pr108272-2.c: New test.
            * gcc.target/powerpc/pr108272-3.c: New test.
            * gcc.target/powerpc/pr108272-4.c: New test.

    (cherry picked from commit 074b0c03eabeb8e9c8de813c81bf87a1f88fdb65)

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:ec4d91aa885297c3b5bb4bbfb3133ffe2e5e6a2f

commit r10-11211-gec4d91aa885297c3b5bb4bbfb3133ffe2e5e6a2f
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Sun Feb 12 09:35:27 2023 -0600

    rs6000: Teach rs6000_opaque_type_invalid_use_p about inline asm [PR108272]

    As PR108272 shows, there are some invalid uses of MMA opaque
    types in inline asm statements.  This patch is to teach the
    function rs6000_opaque_type_invalid_use_p for inline asm,
    check and error any invalid use of MMA opaque types in input
    and output operands.

            PR target/108272

    gcc/ChangeLog:

            * config/rs6000/rs6000.c (rs6000_opaque_type_invalid_use_p): Add
the
            support for invalid uses in inline asm, factor out the checking and
            erroring to lambda function check_and_error_invalid_use.

    gcc/testsuite/ChangeLog:

            * gcc.target/powerpc/pr108272-1.c: New test.
            * gcc.target/powerpc/pr108272-2.c: New test.
            * gcc.target/powerpc/pr108272-3.c: New test.
            * gcc.target/powerpc/pr108272-4.c: New test.

    (cherry picked from commit 074b0c03eabeb8e9c8de813c81bf87a1f88fdb65)

[Bug target/108272] [13 Regression] ICE in gen_movxo, at config/rs6000/mma.md:339

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108272

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Kewen Lin <linkw at gcc dot gnu.org> ---
Fixed on trunk and backported to related branches.