[Bug c++/108321] New: [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[Bug c++/108321] New: [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

            Bug ID: 108321
           Summary: [13 regression]
                    g++.dg/contracts/contracts-tmpl-spec2.C fails after
                    r13-4160-g2efb237ffc68ec
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:2efb237ffc68ec9bb17982434f5941bfa14f8b50, r13-4160-g2efb237ffc68ec

make  -k check-gcc
RUNTESTFLAGS="dg.exp=g++.dg/contracts/contracts-tmpl-spec2.C"
FAIL: g++.dg/contracts/contracts-tmpl-spec2.C   output pattern test
# of expected passes            2
# of unexpected failures        1

There was one other failure with this revision, too:

FAIL: compiler driver --help=c++ option(s): "^ +-.*[^:.]$" absent from output:
"  -fcontract-build-level=[off|default|audit] Specify max contract level to
generate runtime checks for"


commit 2efb237ffc68ec9bb17982434f5941bfa14f8b50 (HEAD, refs/bisect/bad)
Author: Jeff Chapman II <jchapman@lock3software.com>
Date:   Tue Jun 29 16:52:56 2021 -0400

    c++: implement P1492 contracts

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
> FAIL: compiler driver --help=c++ option(s): "^ +-.*[^:.]$" absent from
> output: "  -fcontract-build-level=[off|default|audit] Specify max contract
> level to generate runtime checks for"

This is fixed after r13-4290-g138ee8f7453ffd.

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testsuite-fail
   Target Milestone|---                         |13.0

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
so fixed

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED
   Last reconfirmed|                            |2023-05-18
     Ever confirmed|0                           |1

--- Comment #3 from seurer at gcc dot gnu.org ---
The problem with g++.dg/contracts/contracts-tmpl-spec2.C has never been fixed
as far as I can tell.  It definitely occurs with the current r13.

I believe the "This is fixed after r13-4290-g138ee8f7453ffd" was referring to
the other mentioned issue.


g:f48c546902802cf640c4f2802543acfdc702404f, r13-7354-gf48c546902802c
make  -k check-gcc
RUNTESTFLAGS="dg.exp=g++.dg/contracts/contracts-tmpl-spec2.C"
FAIL: g++.dg/contracts/contracts-tmpl-spec2.C   output pattern test
# of expected passes            2
# of unexpected failures        1


FAIL: g++.dg/contracts/contracts-tmpl-spec2.C   output pattern test
Output was:
contract violation in function body<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:9: a > 0
[continue:on]
-2
contract violation in function body<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:17: a > 1
[continue:on]
-3
contract violation in function none<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:25: a > 0
[continue:on]
1
contract violation in function none<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:32: a > 1
[continue:on]
-101
contract violation in function arg0<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:39: t > 0
[continue:on]
-9
contract violation in function arg0<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:46: t > 1
[continue:on]
11
contract violation in function arg1<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:53: a > 0
[continue:on]
contract violation in function arg1<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:54: t > 0
[continue:on]
-3
contract violation in function arg1<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:61: a > 1
[continue:on]
contract violation in function arg1<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:62: t > 1
[continue:on]
14
contract violation in function ret<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:69: a > 0
[continue:on]
1
contract violation in function ret<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:76: a > 1
[continue:on]
3
contract violation in function ret<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:76: a > 1
[continue:on]
3.300000
contract violation in function g1<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:83: t > 0
[continue:on]
-1
-1
contract violation in function g2<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:97: t > 0
[continue:on]
-1
contract violation in function g2<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:107: t < 0
[continue:on]
1
contract violation in function g2<char> at
g++.dg/contracts/contracts-tmpl-spec2.C:114: t < 'c'
[continue:on]
100
contract violation in function G3<double, double>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:124: t > 0
[continue:on]
contract violation in function G3<double, double>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:125: s > 0
[continue:on]
G3 general T S
contract violation in function G3<int, int>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:139: t > 1
[continue:on]
contract violation in function G3<int, int>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:140: s > 1
[continue:on]
G3 partial int S
contract violation in function G3<int, double>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:147: t > 2
[continue:on]
contract violation in function G3<int, double>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:148: s > 2
[continue:on]
G3 full int double
G3 general T S
contract violation in function G3<int, char>::f at
g++.dg/contracts/contracts-tmpl-spec2.C:139: t > 1
[continue:on]
G3 partial int S
G3 full int C
G3 full int C
contract violation in function G4<int, int>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:173: t > 0
[continue:on]
contract violation in function G4<int, int>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:174: s > 0
[continue:on]
G4 general T S
contract violation in function G4<int, int>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:175: x > 0
[continue:on]
G4 full double double
contract violation in function G4<double, char>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:206: a > 0
[continue:on]
contract violation in function G4<double, char>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:207: b > 'b'
[continue:on]
G4 full double char
contract violation in function G4<double, char>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:208: x > 1
[continue:on]
contract violation in function G4<char, int>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:187: t > 'c'
[continue:on]
contract violation in function G4<char, int>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:188: s > 3
[continue:on]
G4 partial char S
contract violation in function G4<char, int>::G4 at
g++.dg/contracts/contracts-tmpl-spec2.C:189: x2 > 3
[continue:on]
contract violation in function G5<int, int>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:220: t > 0
[continue:on]
contract violation in function G5<int, int>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:221: s > 0
[continue:on]
contract violation in function G5<int, int>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:222: r > 0
[continue:on]
G5 gen T S, f gen R
contract violation in function G5<int, int>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:220: t > 0
[continue:on]
contract violation in function G5<int, int>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:221: s > 0
[continue:on]
contract violation in function G5<int, int>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:222: r > 0
[continue:on]
G5 gen T S, f gen R
contract violation in function G5<char, int>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:233: x > 'z'
[continue:on]
contract violation in function G5<char, int>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:234: y > 1
[continue:on]
contract violation in function G5<char, int>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:235: z > 1
[continue:on]
G5 partial char S, f gen R
contract violation in function G5<char, int>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:233: x > 'z'
[continue:on]
contract violation in function G5<char, int>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:234: y > 1
[continue:on]
contract violation in function G5<char, int>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:235: z > 1
[continue:on]
G5 partial char S, f gen R
contract violation in function G5<double, double>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:244: a > 2
[continue:on]
contract violation in function G5<double, double>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:245: b > 2
[continue:on]
contract violation in function G5<double, double>::f<int> at
g++.dg/contracts/contracts-tmpl-spec2.C:246: c > 2
[continue:on]
G5 full double double, f gen R
contract violation in function G5<double, double>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:244: a > 2
[continue:on]
contract violation in function G5<double, double>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:245: b > 2
[continue:on]
contract violation in function G5<double, double>::f<double> at
g++.dg/contracts/contracts-tmpl-spec2.C:246: c > 2
[continue:on]
G5 full double double, f gen R

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

--- Comment #4 from seurer at gcc dot gnu.org ---
*** Bug 107915 has been marked as a duplicate of this bug. ***

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[ewlu at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

--- Comment #5 from Edwin Lu <ewlu at rivosinc dot com> ---
(In reply to seurer from comment #3)

This also appears in GCC 14 for riscv64 targets with the same output pattern
above. After a quick comparison with the expected output, this output is
missing

> contract violation in function G3<int, double>::f at
> g++.dg/contracts/contracts-tmpl-spec2.C:147: t > 2
> [continue:on]
> contract violation in function G3<int, double>::f at
> g++.dg/contracts/contracts-tmpl-spec2.C:148: s > 2
> [continue:on]
> G3 full int double
contract violation in function G3<char, char>::f at .*:124: t > 0
[continue:on]
contract violation in function G3<char, char>::f at .*:125: s > 0
[continue:on]
> G3 general T S
> contract violation in function G3<int, char>::f at
> g++.dg/contracts/contracts-tmpl-spec2.C:139: t > 1
> [continue:on]
contract violation in function G3<int, char>::f at .*:140: s > 1
[continue:on]
> G3 partial int S
> G3 full int C
> G3 full int C
> contract violation in function G4<int, int>::G4 at
> g++.dg/contracts/contracts-tmpl-spec2.C:173: t > 0

[Bug c++/108321] [13 regression] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I am almost positive this is due to plain char being unsigned by default on
both powerpc and aarch64.  Maybe the testcase should cheat and just use
-fsigned-char ....

[Bug c++/108321] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|13.0                        |---
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org
            Summary|[13 regression]             |g++.dg/contracts/contracts-
                   |g++.dg/contracts/contracts- |tmpl-spec2.C fails after
                   |tmpl-spec2.C fails after    |r13-4160-g2efb237ffc68ec
                   |r13-4160-g2efb237ffc68ec    |
             Status|REOPENED                    |ASSIGNED

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Yes adding -fsigned-char fixes the failure on aarch64. I am going to submit
that.

That is:
```
diff --git a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
index 82117671b2d..fd3a25bd051 100644
--- a/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
+++ b/gcc/testsuite/g++.dg/contracts/contracts-tmpl-spec2.C
@@ -1,6 +1,6 @@
 // basic test to ensure contracts work for class and member specializations
 // { dg-do run }
-// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on" }
+// { dg-options "-std=c++2a -fcontracts -fcontract-continuation-mode=on
-fsigned-char" }
 #include <cstdio>

 // template specializations can have differing contracts

```

[Bug c++/108321] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:6e15e4e1abed02443a27a69455f4bfa49457c99e

commit r14-5848-g6e15e4e1abed02443a27a69455f4bfa49457c99e
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Thu Nov 23 18:55:30 2023 -0800

    Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by
default

    Since contracts-tmpl-spec2.C is just testing contracts, I thought it would
be better
    to just add `-fsigned-char` to the options rather than change the testcase
to support
    both cases.

    Committed after testing on aarch64-linux-gnu.

    gcc/testsuite/ChangeLog:

            PR testsuite/108321
            * g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char
            to options.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

[Bug c++/108321] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed on the trunk.

[Bug c++/108321] g++.dg/contracts/contracts-tmpl-spec2.C fails after r13-4160-g2efb237ffc68ec

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108321

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Torbjorn Svensson
<azoff@gcc.gnu.org>:

https://gcc.gnu.org/g:0cdb04629641c51498f099db04021e8de51adedb

commit r13-8297-g0cdb04629641c51498f099db04021e8de51adedb
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Thu Nov 23 18:55:30 2023 -0800

    Fix contracts-tmpl-spec2.C on targets where plain char is unsigned by
default

    Since contracts-tmpl-spec2.C is just testing contracts, I thought it would
be better
    to just add `-fsigned-char` to the options rather than change the testcase
to support
    both cases.

    Committed after testing on aarch64-linux-gnu.

    gcc/testsuite/ChangeLog:

            PR testsuite/108321
            * g++.dg/contracts/contracts-tmpl-spec2.C: Add -fsigned-char
            to options.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

    (cherry picked from commit 6e15e4e1abed02443a27a69455f4bfa49457c99e)