public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly
@ 2023-01-10 15:24 hewillk at gmail dot com
2023-01-13 0:19 ` [Bug libstdc++/108362] " redi at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: hewillk at gmail dot com @ 2023-01-10 15:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
Bug ID: 108362
Summary: views::istream is SFINAE-unfriendly
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: hewillk at gmail dot com
Target Milestone: ---
Similar issue with https://github.com/microsoft/STL/pull/3335.
#include <ranges>
#include <iostream>
template<class T>
concept can_istream_view = requires {
std::views::istream<T>(std::cin);
};
struct S { };
static_assert(!can_istream_view<S>);
https://godbolt.org/z/b3W1KsPWd
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libstdc++/108362] views::istream is SFINAE-unfriendly
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
@ 2023-01-13 0:19 ` redi at gcc dot gnu.org
2023-03-07 21:04 ` ppalka at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: redi at gcc dot gnu.org @ 2023-01-13 0:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
Last reconfirmed| |2023-01-13
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libstdc++/108362] views::istream is SFINAE-unfriendly
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
2023-01-13 0:19 ` [Bug libstdc++/108362] " redi at gcc dot gnu.org
@ 2023-03-07 21:04 ` ppalka at gcc dot gnu.org
2023-03-09 18:35 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ppalka at gcc dot gnu.org @ 2023-03-07 21:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |ppalka at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot gnu.org
--- Comment #1 from Patrick Palka <ppalka at gcc dot gnu.org> ---
views::iota and views::single too
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libstdc++/108362] views::istream is SFINAE-unfriendly
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
2023-01-13 0:19 ` [Bug libstdc++/108362] " redi at gcc dot gnu.org
2023-03-07 21:04 ` ppalka at gcc dot gnu.org
@ 2023-03-09 18:35 ` cvs-commit at gcc dot gnu.org
2023-03-09 18:35 ` ppalka at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-09 18:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:95827e1b9f7d5dd5a697bd60292e3876a7e8c15c
commit r13-6560-g95827e1b9f7d5dd5a697bd60292e3876a7e8c15c
Author: Patrick Palka <ppalka@redhat.com>
Date: Thu Mar 9 13:35:04 2023 -0500
libstdc++: Make views::single/iota/istream SFINAE-friendly [PR108362]
PR libstdc++/108362
libstdc++-v3/ChangeLog:
* include/std/ranges (__detail::__can_single_view): New concept.
(_Single::operator()): Constrain it. Move [[nodiscard]] to the
end of the function declarator.
(__detail::__can_iota_view): New concept.
(_Iota::operator()): Constrain it. Move [[nodiscard]] to the
end of the function declarator.
(__detail::__can_istream_view): New concept.
(_Istream::operator()): Constrain it. Move [[nodiscard]] to the
end of the function declarator.
* testsuite/std/ranges/iota/iota_view.cc (test07): New test.
* testsuite/std/ranges/istream_view.cc (test08): New test.
* testsuite/std/ranges/single_view.cc (test07): New test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libstdc++/108362] views::istream is SFINAE-unfriendly
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
` (2 preceding siblings ...)
2023-03-09 18:35 ` cvs-commit at gcc dot gnu.org
@ 2023-03-09 18:35 ` ppalka at gcc dot gnu.org
2023-04-29 14:04 ` cvs-commit at gcc dot gnu.org
2023-04-29 14:05 ` ppalka at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: ppalka at gcc dot gnu.org @ 2023-03-09 18:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.3
--- Comment #3 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 13 so far
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libstdc++/108362] views::istream is SFINAE-unfriendly
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
` (3 preceding siblings ...)
2023-03-09 18:35 ` ppalka at gcc dot gnu.org
@ 2023-04-29 14:04 ` cvs-commit at gcc dot gnu.org
2023-04-29 14:05 ` ppalka at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-04-29 14:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:7d0cddced0ff101f5f59ceb2a45e7f145ff973ac
commit r12-9496-g7d0cddced0ff101f5f59ceb2a45e7f145ff973ac
Author: Patrick Palka <ppalka@redhat.com>
Date: Thu Mar 9 13:35:04 2023 -0500
libstdc++: Make views::single/iota/istream SFINAE-friendly [PR108362]
PR libstdc++/108362
libstdc++-v3/ChangeLog:
* include/std/ranges (__detail::__can_single_view): New concept.
(_Single::operator()): Constrain it. Move [[nodiscard]] to the
end of the function declarator.
(__detail::__can_iota_view): New concept.
(_Iota::operator()): Constrain it. Move [[nodiscard]] to the
end of the function declarator.
(__detail::__can_istream_view): New concept.
(_Istream::operator()): Constrain it. Move [[nodiscard]] to the
end of the function declarator.
* testsuite/std/ranges/iota/lwg3292_neg.cc: Prune "in
requirements" diagnostic.
* testsuite/std/ranges/iota/iota_view.cc (test07): New test.
* testsuite/std/ranges/istream_view.cc (test08): New test.
* testsuite/std/ranges/single_view.cc (test07): New test.
(cherry picked from commit 95827e1b9f7d5dd5a697bd60292e3876a7e8c15c)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug libstdc++/108362] views::istream is SFINAE-unfriendly
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
` (4 preceding siblings ...)
2023-04-29 14:04 ` cvs-commit at gcc dot gnu.org
@ 2023-04-29 14:05 ` ppalka at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: ppalka at gcc dot gnu.org @ 2023-04-29 14:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108362
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 12.3+
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-04-29 14:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-10 15:24 [Bug libstdc++/108362] New: views::istream is SFINAE-unfriendly hewillk at gmail dot com
2023-01-13 0:19 ` [Bug libstdc++/108362] " redi at gcc dot gnu.org
2023-03-07 21:04 ` ppalka at gcc dot gnu.org
2023-03-09 18:35 ` cvs-commit at gcc dot gnu.org
2023-03-09 18:35 ` ppalka at gcc dot gnu.org
2023-04-29 14:04 ` cvs-commit at gcc dot gnu.org
2023-04-29 14:05 ` ppalka at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).