[Bug tree-optimization/108387] New: [13 Regression] ICE: tree check: expected ssa_name, have integer_cst in VN_INFO, at tree-ssa-sccvn.cc:450 at -Os

[Bug tree-optimization/108387] New: [13 Regression] ICE: tree check: expected ssa_name, have integer_cst in VN_INFO, at tree-ssa-sccvn.cc:450 at -Os

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

            Bug ID: 108387
           Summary: [13 Regression] ICE: tree check: expected ssa_name,
                    have integer_cst in VN_INFO, at tree-ssa-sccvn.cc:450
                    at -Os
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 54258
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54258&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -Os testcase.c 
during GIMPLE pass: fre
testcase.c: In function 'foo':
testcase.c:6:1: internal compiler error: tree check: expected ssa_name, have
integer_cst in VN_INFO, at tree-ssa-sccvn.cc:450
    6 | foo (char c)
      | ^~~
0x8144d0 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        /repo/gcc-trunk/gcc/tree.cc:8854
0x7f8e10 tree_check(tree_node*, char const*, int, char const*, tree_code)
        /repo/gcc-trunk/gcc/tree.h:3530
0x7f8e10 VN_INFO(tree_node*)
        /repo/gcc-trunk/gcc/tree-ssa-sccvn.cc:450
0x15c7e55 vn_nary_op_insert_stmt
        /repo/gcc-trunk/gcc/tree-ssa-sccvn.cc:4610
0x15d3330 visit_nary_op
        /repo/gcc-trunk/gcc/tree-ssa-sccvn.cc:5408
0x15d4870 process_bb
        /repo/gcc-trunk/gcc/tree-ssa-sccvn.cc:7870
0x15d60c2 do_rpo_vn_1
        /repo/gcc-trunk/gcc/tree-ssa-sccvn.cc:8469
0x15d7a96 execute
        /repo/gcc-trunk/gcc/tree-ssa-sccvn.cc:8627
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-5122-20230112143021-gb073f2b098b-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/13.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-5122-20230112143021-gb073f2b098b-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20230112 (experimental) (GCC)

[Bug tree-optimization/108387] [13 Regression] ICE: tree check: expected ssa_name, have integer_cst in VN_INFO, at tree-ssa-sccvn.cc:450 at -Os

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug tree-optimization/108387] [13 Regression] ICE: tree check: expected ssa_name, have integer_cst in VN_INFO, at tree-ssa-sccvn.cc:450 at -Os

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Obvious caused by r13-5111-g98837d6e79dd27 .

[Bug tree-optimization/108387] [13 Regression] ICE in VN_INFO with multiple and shifts producing 0 at -O2/s/3

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roger at nextmovesoftware dot com
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-01-12
            Summary|[13 Regression] ICE: tree   |[13 Regression] ICE in
                   |check: expected ssa_name,   |VN_INFO with multiple and
                   |have integer_cst in         |shifts producing 0 at
                   |VN_INFO, at                 |-O2/s/3
                   |tree-ssa-sccvn.cc:450 at    |
                   |-O2/s/3                     |

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed. Here is a testcase without vectors Compile at -O2 -fno-tree-ccp to
produce the same issue:
```
void bar2 (unsigned char, unsigned char);

void
foo1 (char c)
{
  unsigned char t = c;
  t *= 2;
  unsigned char t1 = t << 7;
  bar2 (t, t1);
}
```

[Bug tree-optimization/108387] [13 Regression] ICE in VN_INFO with multiple and shifts producing 0 at -O2/s/3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/108387] [13 Regression] ICE in VN_INFO with multiple and shifts producing 0 at -O2/s/3

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:adbee4a197c7b735a3dd58cfac8933f70069f71d

commit r13-5136-gadbee4a197c7b735a3dd58cfac8933f70069f71d
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Jan 13 08:37:24 2023 +0100

    tree-optimization/108387 - ICE with VN handling of x << C as x * (1<<C)

    The following fixes unexpected simplification of x << C as
    x * (1<<C) to a constant.

            PR tree-optimization/108387
            * tree-ssa-sccvn.cc (visit_nary_op): Check for SSA_NAME
            value before inserting expression into the tables.

            * gcc.dg/pr108387.c: New testcase.

[Bug tree-optimization/108387] [13 Regression] ICE in VN_INFO with multiple and shifts producing 0 at -O2/s/3

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108387

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.