public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "carll at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/108396] [12/13 Regression] PPCLE: vec_vsubcuq missing since r12-5752-gd08236359eb229 Date: Thu, 05 Oct 2023 18:01:44 +0000 [thread overview] Message-ID: <bug-108396-4-A2t1kv9uRj@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108396-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108396 Carl Love <carll at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carll at gcc dot gnu.org --- Comment #9 from Carl Love <carll at gcc dot gnu.org> --- I made a copy of rs6000-overload.def and then with a series of emacs macros converted the list of builtins to a script to grep for the builtins in the test directory. Specifically from rs6000-overload.def: [BCDADD, __builtin_bcdadd, __builtin_vec_bcdadd] vsq __builtin_vec_bcdadd (vsq, vsq, const int); BCDADD_V1TI vuc __builtin_vec_bcdadd (vuc, vuc, const int); BCDADD_V16QI [BCDADD_EQ, __builtin_bcdadd_eq, __builtin_vec_bcdadd_eq] signed int __builtin_vec_bcdadd_eq (vsq, vsq, const int); BCDADD_EQ_V1TI signed int __builtin_vec_bcdadd_eq (vuc, vuc, const int); BCDADD_EQ_V16QI .... Was converted to the bash script: rm -f ../test1_not_found NOT_FOUND='0 0 0' check_name () { str1=$(grep -r $1 * | wc) # echo " output of command: $str1" if [[ "$str1" == *"$NOT_FOUND"* ]]; then echo "$1 not found" >> ../test1_not_found fi } check_name "__builtin_bcdadd" "__builtin_vec_bcdadd" check_name "__builtin_bcdadd_eq" "__builtin_vec_bcdadd_eq" .... The script is passed the user built-in name ($str1) and the internal built-in name ($str2). I ran the script in directory gcc/testsuite/gcc.target/powerpc and it identified two tests ($str1) as not showing up in a test file. The tests were: __builtin_bcdsub_ge and __builtin_bcdsub_le. I figure if the first builtin name has a test associated with it that should be sufficient. I will create a patch to add testcases for the two missing builtin-names. I did add to the script to see how many definitions have a test for the built-in name $1 but not the built-in name $2 doesn't show up in a test file. My script identified 86 of these cases. Not sure that we really need to add test cases for the internal builtin name ($str). Thoughts?
next prev parent reply other threads:[~2023-10-05 18:01 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-13 16:24 [Bug target/108396] New: PPCLE: vec_vsubcuq missing jens.seifert at de dot ibm.com 2023-01-13 19:00 ` [Bug target/108396] [12/13 Regression] " pinskia at gcc dot gnu.org 2023-01-16 7:38 ` rguenth at gcc dot gnu.org 2023-01-16 9:58 ` [Bug target/108396] [12/13 Regression] PPCLE: vec_vsubcuq missing since r12-5752-gd08236359eb229 linkw at gcc dot gnu.org 2023-01-16 16:35 ` segher at gcc dot gnu.org 2023-01-17 3:03 ` linkw at gcc dot gnu.org 2023-01-17 11:56 ` segher at gcc dot gnu.org 2023-01-18 8:35 ` cvs-commit at gcc dot gnu.org 2023-02-13 2:03 ` cvs-commit at gcc dot gnu.org 2023-02-13 2:21 ` linkw at gcc dot gnu.org 2023-10-05 18:01 ` carll at gcc dot gnu.org [this message] 2023-10-12 6:10 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108396-4-A2t1kv9uRj@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).