[Bug c++/108413] New: copyrights for gcc 2023

[Bug c++/108413] New: copyrights for gcc 2023

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

            Bug ID: 108413
           Summary: copyrights for gcc 2023
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

Copyrights information should be changed to 2023

https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/std/array

Take this as example

// Copyright (C) 2007-2022 Free Software Foundation, Inc.

should be changed to:

// Copyright (C) 2007-2023 Free Software Foundation, Inc.

[Bug libstdc++/108413] copyrights for gcc 2023

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c++                         |libstdc++

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Hmm, the automated update copyright script missed libstdc++, I wonder if it
missed other directories too ....

[Bug libstdc++/108413] copyrights for gcc 2023

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gaius at gcc dot gnu.org,
                   |                            |ibuclaw at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org,
                   |                            |redi at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
THe problem is with what I wrote on IRC:
gcc/m2/mc-boot/GmcOptions.c: unrecognised copyright: comment (f, (const char *)
"Copyright (C) ''2021'' Free Software Foundation, Inc.", 53);
gcc/m2/mc-boot/GmcOptions.c: unrecognised copyright: comment (f, (const char *)
"Copyright (C) ''2021'' Free Software Foundation, Inc.", 53);
gcc/testsuite/gm2/switches/pedantic-params/pass/Strings.mod: unrecognised
copyright holder: Faculty of Information Technology,
gcc/testsuite/gm2/switches/pedantic-params/pass/Strings2.mod: unrecognised
copyright holder: Faculty of Information Technology,
libphobos/libdruntime/__builtins.di: unrecognised copyright: * Copyright:
Copyright Digital Mars 2022
libstdc++-v3/src/c++17/fast_float/fast_float.h: unrecognised copyright holder:
The fast_float authors
libstdc++-v3/include/c_compatibility/stdatomic.h: unrecognised copyright
holder: The GCC developers
are the remaining errors from update-copyright.py --this-year, we need to deal
with those.
For the testsuite/gm2/ stuff I guess:
--- contrib/update-copyright.py 2023-01-06 10:01:50.217579023 +0100
+++ contrib/update-copyright.py 2023-01-16 10:28:01.584851122 +0100
@@ -596,6 +596,8 @@ class TestsuiteFilter (GenericFilter):
                 '.go',
                 '.inc',
                 '.java',
+                '.mod',
+                '.rs'
                 ])

     def skip_file (self, dir, filename):
but not sure about the rest.

[Bug other/108413] copyrights for gcc 2023

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d1c6a352cad473edbacecad5ceb49eaaa4e67a52

commit r13-5187-gd1c6a352cad473edbacecad5ceb49eaaa4e67a52
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Jan 16 11:03:30 2023 +0100

    contrib: Partial fix for failed update-copyright --this year [PR108413]

    As mentioned on IRC or in PR108413, the last update-copyright.py --this
year
    failed and that is why we are in a strange state where some copyrights have
    been updated and others have not.
    The full list of errors I got was I think:
    gcc/m2/mc-boot/GmcOptions.c: unrecognised copyright: comment (f, (const
char *) "Copyright (C) ''2021'' Free Software Foundation, Inc.", 53);
    gcc/m2/mc-boot/GmcOptions.c: unrecognised copyright: comment (f, (const
char *) "Copyright (C) ''2021'' Free Software Foundation, Inc.", 53);
    gcc/testsuite/gm2/switches/pedantic-params/pass/Strings.mod: unrecognised
copyright holder: Faculty of Information Technology,
    gcc/testsuite/gm2/switches/pedantic-params/pass/Strings2.mod: unrecognised
copyright holder: Faculty of Information Technology,
    libphobos/libdruntime/__builtins.di: unrecognised copyright: * Copyright:
Copyright Digital Mars 2022
    libstdc++-v3/src/c++17/fast_float/fast_float.h: unrecognised copyright
holder: The fast_float authors
    libstdc++-v3/include/c_compatibility/stdatomic.h: unrecognised copyright
holder: The GCC developers

    The following patch deals with the gcc/testsuite/gm2 ones and
    with the fast_float.h one, ok for trunk?

    Not really sure what we should do in the GmcOptions.c case
    (perhaps obfuscate it in the source somehow by splitting
    the string literals into different substrings
    Perhaps "Copy" "right (" "C) ''..." would do it?  Or do we want
    to bump there each year (manually or by the script)?
    E.g. in gcc.cc we have
          printf ("Copyright %s 2023 Free Software Foundation, Inc.\n",
                  _("(C)"));
    which also prints (C) nicer in Unicode if possible and is updated
    by hand each year.

    I have no idea about the libphobos case, we have tons of
    libphobos/src/std/format/spec.d:Copyright: Copyright The D Language
Foundation 2000-2013.
    libphobos/src/std/random.d:Copyright: Copyright Andrei Alexandrescu 2008 -
2009, Joseph Rushton Wakeling 2012.
    etc. lines and those aren't reported as errors.

    And the last one is that I think for The GCC developers we should treat it
    similarly like FSF and bump copyright on it.
    Would
            canon_gcc = 'The GCC developers'
            self.add_package_author ('The GCC developers', canon_gcc)
            self.add_package_author ('The GCC Developers', canon_gcc)
    or something similar do the trick?

    2023-01-16  Jakub Jelinek  <jakub@redhat.com>

            PR other/108413
            * update-copyright.py (TestsuiteFilter): Add .mod and .rs
extensions.
            (GCCCopyright): Add 'The fast_float authors' as external author.

[Bug other/108413] copyrights for gcc 2023

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> libstdc++-v3/src/c++17/fast_float/fast_float.h: unrecognised copyright
> holder: The fast_float authors

I think we need to add a special case for this. That is what it says in
https://github.com/fastfloat/fast_float/blob/main/LICENSE-MIT

> libstdc++-v3/include/c_compatibility/stdatomic.h: unrecognised copyright
> holder: The GCC developers

Oops, this one's wrong, I'll fix it.

[Bug other/108413] copyrights for gcc 2023

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c841bde5ac2bd8915ecc974ff7623c8954fc1cf3

commit r13-5188-gc841bde5ac2bd8915ecc974ff7623c8954fc1cf3
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Jan 16 11:22:09 2023 +0100

    riscv: Fix up Copyright lines [PR108413]

    These 2 files had incorrectly formatted Copyright lines (no space between
    Copyright and (C)) which makes update-copyright.py upset.

    2023-01-16  Jakub Jelinek  <jakub@redhat.com>

            PR other/108413
            * config/riscv/riscv-vsetvl.h: Add space in between Copyright and
(C).
            * config/riscv/riscv-vsetvl.cc: Likewise.

[Bug other/108413] copyrights for gcc 2023

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:fa16c7d899022d0e671407cd7188b66bb84fefe6

commit r13-5191-gfa16c7d899022d0e671407cd7188b66bb84fefe6
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Jan 16 10:15:41 2023 +0000

    libstdc++: Fix copyright notice to use usual form [PR108413]

    libstdc++-v3/ChangeLog:

            PR libstdc++/108413
            * include/c_compatibility/stdatomic.h: Change copyright line to
            be consistent with other headers contributed under DCO terms.
            * include/std/expected: Add full stop to copyright line.
            * src/c++20/tzdb.cc: Likewise.

[Bug other/108413] copyrights for gcc 2023

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:3e087d9ab8247fa866945f156cfe3aa6dc7039ff

commit r13-5192-g3e087d9ab8247fa866945f156cfe3aa6dc7039ff
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Jan 16 11:38:33 2023 +0100

    contrib: Yet another update-copyright.py tweak [PR108413]

    Ignore __builtins.di like object.d is already ignored.

    2023-01-16  Jakub Jelinek  <jakub@redhat.com>

            PR other/108413
            * update-copyright.py (LibPhobosFilter): Add __builtins.di to
            skipped files.

[Bug other/108413] copyrights for gcc 2023

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I've worked around the GmcOptions.c case with a local hack and committed
the copyright updates in r13-5197

[Bug other/108413] copyrights for gcc 2023

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #9 from Gaius Mulley <gaius at gcc dot gnu.org> ---
I've git pushed some fixes for gcc/m2/mc/mcOptions.mod to obfuscate the
copyright text.  The change to mcOptions.mod also includes the removal
of the 'YEAR' constant and it queries the system for the year.  A
summary of the ChangeLog:

gcc/m2/ChangeLog:

        * mc-boot/GmcOptions.c: Rebuilt.
        * mc/mcOptions.mod (displayVersion):
        Split first printf into three components
        * mc/mcOptions.mod (YEAR): Remove.
        (getYear): New procedure function.
        (displayVersion): Use result from getYear instead of YEAR.
        Emit boilerplate for GPL v3.
        (gplBody): Use result from getYear instead of YEAR.
        (glplBody): Use result from getYear instead of YEAR.

taken from gcc r13-5229 and gcc r13-5217

[Bug other/108413] copyrights for gcc 2023

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108413

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:83487e1f0c380859ed2dab2892afa8651d267fb3

commit r12-9327-g83487e1f0c380859ed2dab2892afa8651d267fb3
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Jan 16 10:15:41 2023 +0000

    libstdc++: Fix copyright notice to use usual form [PR108413]

    libstdc++-v3/ChangeLog:

            PR libstdc++/108413
            * include/c_compatibility/stdatomic.h: Change copyright line to
            be consistent with other headers contributed under DCO terms.
            * include/std/expected: Add full stop to copyright line.

    (cherry picked from commit fa16c7d899022d0e671407cd7188b66bb84fefe6)