[Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98

[Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

            Bug ID: 108420
           Summary: [13 Regression] ICE in check_charlen_present, at
                    fortran/iresolve.cc:98
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20221127 and 20221204 :


$ cat z1.f90
program p
   character :: c = 'c'
   print *, merge(transfer('a', 'b', 0), c, .true.)
end


$ gfortran-13-20230115 -c z1.f90
f951: internal compiler error: Segmentation fault
0xda7faf crash_signal
        ../../gcc/toplev.cc:314
0x7eb6dc check_charlen_present
        ../../gcc/fortran/iresolve.cc:98
0x7eecff gfc_resolve_merge(gfc_expr*, gfc_expr*, gfc_expr*, gfc_expr*)
        ../../gcc/fortran/iresolve.cc:1958
0x7d7635 resolve_intrinsic
        ../../gcc/fortran/intrinsic.cc:4577
0x7d7635 do_simplify
        ../../gcc/fortran/intrinsic.cc:4714
0x7e24fa gfc_intrinsic_func_interface(gfc_expr*, int)
        ../../gcc/fortran/intrinsic.cc:5056
0x839218 resolve_unknown_f
        ../../gcc/fortran/resolve.cc:2990
0x839218 resolve_function
        ../../gcc/fortran/resolve.cc:3347
0x839218 gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7195
0x83f4ac gfc_resolve_expr(gfc_expr*)
        ../../gcc/fortran/resolve.cc:7162
0x83f4ac gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.cc:11982
0x83dfdf gfc_resolve_blocks(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.cc:10980
0x83e338 gfc_resolve_code(gfc_code*, gfc_namespace*)
        ../../gcc/fortran/resolve.cc:11972
0x8410e7 resolve_codes
        ../../gcc/fortran/resolve.cc:17629
0x8411ae gfc_resolve(gfc_namespace*)
        ../../gcc/fortran/resolve.cc:17664
0x828f44 resolve_all_program_units
        ../../gcc/fortran/parse.cc:6656
0x828f44 gfc_parse_file()
        ../../gcc/fortran/parse.cc:6912
0x876eff gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-01-16
     Ever confirmed|0                           |1

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.

The following variation actually ICEs for me down to at least v7:

program p
  character :: c = 'c'
  logical   :: m = .true.
  print *, merge(transfer('a', 'b', 0), c, m)
end

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

--- Comment #2 from anlauf at gcc dot gnu.org ---
I'm regtesting the following patch which fixes both cases:

diff --git a/gcc/fortran/iresolve.cc b/gcc/fortran/iresolve.cc
index 711e9178ad4..33794f0a858 100644
--- a/gcc/fortran/iresolve.cc
+++ b/gcc/fortran/iresolve.cc
@@ -94,9 +94,12 @@ check_charlen_present (gfc_expr *source)
   else if (source->expr_type == EXPR_ARRAY)
     {
       gfc_constructor *c = gfc_constructor_first (source->value.constructor);
-      source->ts.u.cl->length
-               = gfc_get_int_expr (gfc_charlen_int_kind, NULL,
-                                   c->expr->value.character.length);
+      if (c)
+       source->ts.u.cl->length
+         = gfc_get_int_expr (gfc_charlen_int_kind, NULL,
+                             c->expr->value.character.length);
+      if (source->ts.u.cl->length == NULL)
+       gfc_internal_error ("check_charlen_present(): length not set");
     }
 }

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-January/058774.html

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
   Target Milestone|---                         |13.0

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |check_charlen_present, at   |check_charlen_present, at
                   |fortran/iresolve.cc:98      |fortran/iresolve.cc:98
                   |                            |since
                   |                            |r13-4394-g3832c6f7e672e76b

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-4394-g3832c6f7e672e76b.

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:e6669c0a50ed8aee9e5997d61e6271668d149218

commit r13-5311-ge6669c0a50ed8aee9e5997d61e6271668d149218
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 16 21:41:09 2023 +0100

    Fortran: fix ICE in check_charlen_present [PR108420]

    gcc/fortran/ChangeLog:

            PR fortran/108420
            * iresolve.cc (check_charlen_present): Preserve character length if
            there is no array constructor.

    gcc/testsuite/ChangeLog:

            PR fortran/108420
            * gfortran.dg/pr108420.f90: New test.

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:523ee9f5994961b27c61d46b27dbe064f68d0d76

commit r12-9077-g523ee9f5994961b27c61d46b27dbe064f68d0d76
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 16 21:41:09 2023 +0100

    Fortran: fix ICE in check_charlen_present [PR108420]

    gcc/fortran/ChangeLog:

            PR fortran/108420
            * iresolve.cc (check_charlen_present): Preserve character length if
            there is no array constructor.

    gcc/testsuite/ChangeLog:

            PR fortran/108420
            * gfortran.dg/pr108420.f90: New test.

    (cherry picked from commit e6669c0a50ed8aee9e5997d61e6271668d149218)

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:c3985fd624053502b0aad85132982b4f8970811a

commit r11-10501-gc3985fd624053502b0aad85132982b4f8970811a
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 16 21:41:09 2023 +0100

    Fortran: fix ICE in check_charlen_present [PR108420]

    gcc/fortran/ChangeLog:

            PR fortran/108420
            * iresolve.c (check_charlen_present): Preserve character length if
            there is no array constructor.

    gcc/testsuite/ChangeLog:

            PR fortran/108420
            * gfortran.dg/pr108420.f90: New test.

    (cherry picked from commit e6669c0a50ed8aee9e5997d61e6271668d149218)

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:b14dcf0c99fab065e11ec87984475580b649edeb

commit r10-11193-gb14dcf0c99fab065e11ec87984475580b649edeb
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Mon Jan 16 21:41:09 2023 +0100

    Fortran: fix ICE in check_charlen_present [PR108420]

    gcc/fortran/ChangeLog:

            PR fortran/108420
            * iresolve.c (check_charlen_present): Preserve character length if
            there is no array constructor.

    gcc/testsuite/ChangeLog:

            PR fortran/108420
            * gfortran.dg/pr108420.f90: New test.

    (cherry picked from commit e6669c0a50ed8aee9e5997d61e6271668d149218)

[Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|13.0                        |10.5

--- Comment #9 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!