[Bug target/108429] New: FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[Bug target/108429] New: FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

            Bug ID: 108429
           Summary: FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect
                    "LOOP VECTORIZED"
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

The testcase FAILs for me since recently.

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |13.0
             Target|                            |x86_64-*-*
            Summary|FAIL:                       |[13 Regression] FAIL:
                   |gcc.target/i386/pr89618.c   |gcc.target/i386/pr89618.c
                   |scan-tree-dump vect "LOOP   |scan-tree-dump vect "LOOP
                   |VECTORIZED"                 |VECTORIZED"
           Keywords|                            |missed-optimization,
                   |                            |testsuite-fail

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
/home/rguenther/src/trunk/gcc/testsuite/gcc.target/i386/pr89618.c:14:7: missed:
  unsupported emulated scatter.
/home/rguenther/src/trunk/gcc/testsuite/gcc.target/i386/pr89618.c:16:14:
missed:   not vectorized: relevant stmt not supported: *_26 = iftmp.0_39;

note the testcase enables -mavx512f but with generic tuning

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |53947

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
We now have X86_TUNE_USE_SCATTER_[{2,4}PARTS] but the vectorizer doesn't
have support to open-code 2- or 4- part scatter so the comment that open-coded
variants are consistently faster doesn't help vectorization.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53947
[Bug 53947] [meta-bug] vectorizer missed-optimizations

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-01-17
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r13-5202-g967592488c64a86f37bef3dabebb56364f14acdd

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |hubicka at gcc dot gnu.org

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I see this is scatter with generic tuning.  I actually did not intend to
disable it there without more testing, so I will revert that part of change.

In meantime I noticed that aocc sometimes seems to use scatters with some
degree of success even though scatters seems to be loss on all tsvc benchmarks
where GCC generates them. So I think we want to do more work on this (adding
open-coding etc.) next stage1.

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Honza - the test still fails.

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jan Hubicka <hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:b83acefb0409056b566133f66843ead6c04b8474

commit r13-6502-gb83acefb0409056b566133f66843ead6c04b8474
Author: Jan Hubicka <jh@suse.cz>
Date:   Mon Mar 6 11:08:26 2023 +0100

    Enable scatter for generic

    2023-03-06  Jan Hubicka  <hubicka@ucw.cz>

            PR target/108429
            * config/i386/x86-tune.def (X86_TUNE_USE_SCATTER_2PARTS): Enable
for
            generic.
            (X86_TUNE_USE_SCATTER_4PARTS): Likewise.
            (X86_TUNE_USE_SCATTER): Likewise.

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.

[Bug target/108429] [13 Regression] FAIL: gcc.target/i386/pr89618.c scan-tree-dump vect "LOOP VECTORIZED"

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108429

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jan Hubicka
<hubicka@gcc.gnu.org>:

https://gcc.gnu.org/g:27e02e9fc388d7dc86ec10bedc6b8f13ec94725a

commit r12-9251-g27e02e9fc388d7dc86ec10bedc6b8f13ec94725a
Author: Jan Hubicka <jh@suse.cz>
Date:   Mon Mar 6 11:08:26 2023 +0100

    Enable scatter for generic

    2023-03-06  Jan Hubicka  <hubicka@ucw.cz>

            PR target/108429
            * config/i386/x86-tune.def (X86_TUNE_USE_SCATTER_2PARTS): Enable
for
            generic.
            (X86_TUNE_USE_SCATTER_4PARTS): Likewise.
            (X86_TUNE_USE_SCATTER): Likewise.

    (cherry picked from commit b83acefb0409056b566133f66843ead6c04b8474)