public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/108430] [12 Regression] Wrong code with -msve-vector-bits=512 since r13-707-g68e0063397 Date: Mon, 03 Apr 2023 08:57:44 +0000 [thread overview] Message-ID: <bug-108430-4-y8Z5jzVBm5@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108430-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108430 --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>: https://gcc.gnu.org/g:33a69d0b0b772610463d1d586f3f0c9820fc969e commit r12-9378-g33a69d0b0b772610463d1d586f3f0c9820fc969e Author: Richard Sandiford <richard.sandiford@arm.com> Date: Mon Apr 3 09:57:06 2023 +0100 vect: Fix voluntarily-masked negative conditionals [PR108430] vectorizable_condition checks whether a COND_EXPR condition is used elsewhere with a loop mask. If so, it applies the loop mask to the COND_EXPR too, to reduce the number of live masks and to increase the chance of combining the AND with the comparison. There is also code to do this for inverted conditions. E.g. if we have a < b ? c : d and something else is conditional on !(a < b) (such as a load in d), we use !(a < b) ? d : c and apply the loop mask to !(a < b). This inversion relied on the function's bitop1/bitop2 mechanism. However, that mechanism is skipped if the condition is split out of the COND_EXPR as a separate statement. This meant that we could end up using the inverse of the intended condition. There is a separate way of negating the condition when a mask is being applied (which is also used for EXTRACT_LAST reductions). This patch uses that instead. As well as the testcase, this fixes aarch64/sve/vcond_{4,17}_run.c. gcc/ PR tree-optimization/108430 * tree-vect-stmts.cc (vectorizable_condition): Fix handling of inverted condition. gcc/testsuite/ PR tree-optimization/108430 * gcc.target/aarch64/sve/pr108430.c: New test. (cherry picked from commit 2a8ce4b52f5892a10a02b94d7be689e59a444ff6)
next prev parent reply other threads:[~2023-04-03 8:57 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-17 11:10 [Bug tree-optimization/108430] New: [13 " acoplan at gcc dot gnu.org 2023-01-17 12:14 ` [Bug tree-optimization/108430] " rguenth at gcc dot gnu.org 2023-02-09 9:45 ` rsandifo at gcc dot gnu.org 2023-02-21 13:02 ` rguenth at gcc dot gnu.org 2023-03-02 10:30 ` cvs-commit at gcc dot gnu.org 2023-03-02 11:03 ` rsandifo at gcc dot gnu.org 2023-03-15 9:49 ` [Bug tree-optimization/108430] [12 " rguenth at gcc dot gnu.org 2023-04-03 8:57 ` cvs-commit at gcc dot gnu.org [this message] 2023-04-03 9:00 ` rsandifo at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108430-4-y8Z5jzVBm5@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).