[Bug target/108442] New: arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[Bug target/108442] New: arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

            Bug ID: 108442
           Summary: arm: MVE's vld1* and vst1* do not work when
                    __ARM_MVE_PRESERVE_USER_NAMESPACE is defined
           Product: gcc
           Version: 10.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: avieira at gcc dot gnu.org
  Target Milestone: ---

When compiling:
$ cat t.c
#include <arm_mve.h>

uint32x4_t foo (uint32_t *p)
{
    return __arm_vld1q_u32 (p);
}

with:
$ arm-none-eabi-gcc -march=armv8.1-m.main+mve -mfloat-abi=hard
-D__ARM_MVE_PRESERVE_USER_NAMESPACE

it will fail to compile as __arm_vld1q_u32 is defined in arm_mve.h as calling
vldrwq_u32 which will not exist when __ARM_MVE_PRESERVE_USER_NAMESPACE is
defined.

[Bug target/108442] arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

--- Comment #1 from avieira at gcc dot gnu.org ---
This fails equally for any vld1* vstr1* intrinsic.

[Bug target/108442] arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-01-18
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
There was a patch posted for this earlier this year, but the discussion on it
died out.

[Bug target/108442] arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

--- Comment #3 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
https://gcc.gnu.org/pipermail/gcc-patches/2021-December/587296.html

[Bug target/108442] arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Earnshaw <rearnsha@gcc.gnu.org>:

https://gcc.gnu.org/g:f54e31ddefe3ea7146624eabcb75b1c90dc59f1a

commit r13-5239-gf54e31ddefe3ea7146624eabcb75b1c90dc59f1a
Author: Murray Steele <murray.steele@arm.com>
Date:   Wed Dec 22 15:55:58 2021 +0000

    arm: fix __arm_vld1q_z* and __arm_vst1q_p* intrinsics [PR108442]

    The MVE ACLE allows for __ARM_MVE_PRESERVE_USER_NAMESPACE to be defined,
    which removes definitions for intrinsic functions without the __arm_
    prefix. __arm_vld1q_z* and __arm_vst1q_p* are currently implemented via
    calls to vldr* and vstr*, which results in several compile-time errors when
    __ARM_MVE_PRESERVE_USER_NAMESPACE is defined. This patch replaces these
    with calls to their prefixed counterparts, __arm_vldr* and __arm_str*,
    and adds a test covering the definition of
__ARM_MVE_PRESERVE_USER_NAMESPACE.

    gcc/ChangeLog:

            PR target/108442
            * config/arm/arm_mve.h (__arm_vst1q_p_u8): Use prefixed intrinsic
            function.
            (__arm_vst1q_p_s8): Likewise.
            (__arm_vld1q_z_u8): Likewise.
            (__arm_vld1q_z_s8): Likewise.
            (__arm_vst1q_p_u16): Likewise.
            (__arm_vst1q_p_s16): Likewise.
            (__arm_vld1q_z_u16): Likewise.
            (__arm_vld1q_z_s16): Likewise.
            (__arm_vst1q_p_u32): Likewise.
            (__arm_vst1q_p_s32): Likewise.
            (__arm_vld1q_z_u32): Likewise.
            (__arm_vld1q_z_s32): Likewise.
            (__arm_vld1q_z_f16): Likewise.
            (__arm_vst1q_p_f16): Likewise.
            (__arm_vld1q_z_f32): Likewise.
            (__arm_vst1q_p_f32): Likewise.

    gcc/testsuite/ChangeLog:

            * gcc.target/arm/mve/general/preserve_user_namespace_1.c: New test.

[Bug target/108442] arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

--- Comment #5 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Fixed on master.  While this is not a regression, we should consider a
backport.

[Bug target/108442] arm: MVE's vld1* and vst1* do not work when __ARM_MVE_PRESERVE_USER_NAMESPACE is defined

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108442

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Stam Markianos-Wright
<stammark@gcc.gnu.org>:

https://gcc.gnu.org/g:60e54b99f597a594a9ad8deaa2af1ed66eb451c7

commit r12-9611-g60e54b99f597a594a9ad8deaa2af1ed66eb451c7
Author: Murray Steele <murray.steele@arm.com>
Date:   Wed Dec 22 15:55:58 2021 +0000

    arm: fix __arm_vld1q_z* and __arm_vst1q_p* intrinsics [PR108442]

    The MVE ACLE allows for __ARM_MVE_PRESERVE_USER_NAMESPACE to be defined,
    which removes definitions for intrinsic functions without the __arm_
    prefix. __arm_vld1q_z* and __arm_vst1q_p* are currently implemented via
    calls to vldr* and vstr*, which results in several compile-time errors when
    __ARM_MVE_PRESERVE_USER_NAMESPACE is defined. This patch replaces these
    with calls to their prefixed counterparts, __arm_vldr* and __arm_str*,
    and adds a test covering the definition of
__ARM_MVE_PRESERVE_USER_NAMESPACE.

    gcc/ChangeLog:

            PR target/108442
            * config/arm/arm_mve.h (__arm_vst1q_p_u8): Use prefixed intrinsic
            function.
            (__arm_vst1q_p_s8): Likewise.
            (__arm_vld1q_z_u8): Likewise.
            (__arm_vld1q_z_s8): Likewise.
            (__arm_vst1q_p_u16): Likewise.
            (__arm_vst1q_p_s16): Likewise.
            (__arm_vld1q_z_u16): Likewise.
            (__arm_vld1q_z_s16): Likewise.
            (__arm_vst1q_p_u32): Likewise.
            (__arm_vst1q_p_s32): Likewise.
            (__arm_vld1q_z_u32): Likewise.
            (__arm_vld1q_z_s32): Likewise.
            (__arm_vld1q_z_f16): Likewise.
            (__arm_vst1q_p_f16): Likewise.
            (__arm_vld1q_z_f32): Likewise.
            (__arm_vst1q_p_f32): Likewise.

    gcc/testsuite/ChangeLog:

            * gcc.target/arm/mve/general/preserve_user_namespace_1.c: New test.

    (cherry picked from commit f54e31ddefe3ea7146624eabcb75b1c90dc59f1a)