public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/108451] [13 Regression] ICE in check_complete_insertion, at hash-table.h:578
Date: Fri, 03 Feb 2023 13:50:54 +0000	[thread overview]
Message-ID: <bug-108451-4-7AwekaoWzL@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108451-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108451

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
2023-02-03  Jakub Jelinek  <jakub@redhat.com>

        PR fortran/108451
        * trans-decl.cc (gfc_trans_use_stmts): Call clear_slot before
        doing continue.

--- gcc/fortran/trans-decl.cc.jj        2023-01-16 11:52:16.146733136 +0100
+++ gcc/fortran/trans-decl.cc   2023-02-03 14:41:40.503322954 +0100
@@ -5350,7 +5350,11 @@ gfc_trans_use_stmts (gfc_namespace * ns)
              /* Sometimes, generic interfaces wind up being over-ruled by a
                 local symbol (see PR41062).  */
              if (!st->n.sym->attr.use_assoc)
-               continue;
+               {
+                 *slot = error_mark_node;
+                 entry->decls->clear_slot (slot);
+                 continue;
+               }

              if (st->n.sym->backend_decl
                  && DECL_P (st->n.sym->backend_decl)

fixes the regression (fairly obvious bug).  Am not adding testcase because
given #c1 I'm  really not sure if the testcase is valid or not.  Anyway, GCC 12
accept z1 and z2 and reject z3, so IMHO this bug should be split into the
checking ICE which the above patch should fix and any possible accepts-invalid
which doesn't look like a regression.

  parent reply	other threads:[~2023-02-03 13:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 18:24 [Bug fortran/108451] New: " gscfq@t-online.de
2023-01-18 18:25 ` [Bug fortran/108451] " gscfq@t-online.de
2023-01-19  7:47 ` rguenth at gcc dot gnu.org
2023-01-19 14:22 ` marxin at gcc dot gnu.org
2023-02-03 13:50 ` jakub at gcc dot gnu.org [this message]
2023-02-03 17:07 ` kargl at gcc dot gnu.org
2023-02-03 20:38 ` cvs-commit at gcc dot gnu.org
2023-02-03 20:41 ` jakub at gcc dot gnu.org
2023-02-10 17:46 ` cvs-commit at gcc dot gnu.org
2023-05-02 20:14 ` cvs-commit at gcc dot gnu.org
2023-05-03 15:21 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108451-4-7AwekaoWzL@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).