public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/108451] [13 Regression] ICE in check_complete_insertion, at hash-table.h:578 Date: Fri, 10 Feb 2023 17:46:37 +0000 [thread overview] Message-ID: <bug-108451-4-9mGKfnAxIl@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108451-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108451 --- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:f2731d1b9a52a7c97af9bbb6ea76603630cc11c2 commit r12-9151-gf2731d1b9a52a7c97af9bbb6ea76603630cc11c2 Author: Jakub Jelinek <jakub@redhat.com> Date: Fri Feb 3 21:37:27 2023 +0100 fortran: Fix up hash table usage in gfc_trans_use_stmts [PR108451] The first testcase in the PR (which I haven't included in the patch because it is unclear to me if it is supposed to be valid or not) ICEs since extra hash table checking has been added recently. The problem is that gfc_trans_use_stmts does tree *slot = entry->decls->find_slot_with_hash (rent->use_name, hash, INSERT); if (*slot == NULL) and later on doesn't store anything into *slot and continues. Another spot a few lines later correctly clears the slot if it decides not to use the slot, so the following patch does the same. 2023-02-03 Jakub Jelinek <jakub@redhat.com> PR fortran/108451 * trans-decl.cc (gfc_trans_use_stmts): Call clear_slot before doing continue. (cherry picked from commit 76f7f0eddcb7c418d1ec3dea3e2341ca99097301)
next prev parent reply other threads:[~2023-02-10 17:46 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-18 18:24 [Bug fortran/108451] New: " gscfq@t-online.de 2023-01-18 18:25 ` [Bug fortran/108451] " gscfq@t-online.de 2023-01-19 7:47 ` rguenth at gcc dot gnu.org 2023-01-19 14:22 ` marxin at gcc dot gnu.org 2023-02-03 13:50 ` jakub at gcc dot gnu.org 2023-02-03 17:07 ` kargl at gcc dot gnu.org 2023-02-03 20:38 ` cvs-commit at gcc dot gnu.org 2023-02-03 20:41 ` jakub at gcc dot gnu.org 2023-02-10 17:46 ` cvs-commit at gcc dot gnu.org [this message] 2023-05-02 20:14 ` cvs-commit at gcc dot gnu.org 2023-05-03 15:21 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108451-4-9mGKfnAxIl@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).