[Bug fortran/108453] New: [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361

[Bug fortran/108453] New: [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

            Bug ID: 108453
           Summary: [10/11/12/13 Regression] ICE in gfc_trans_use_stmts,
                    at fortran/trans-decl.cc:5361
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r6 :


$ cat z1.f90
module m
   type t
   end type
end
program p
   use m, only: t
   common t
end


$ cat z2.f90
module m
   type t
   end type
end
program p
   use m, only: t
   common /xc/ t
end


$ cat z3.f90
module m
   type t
   end type
end
program p
   use m
   common t
end


$ gfortran-5 -c z3.f90
z3.f90:7:11:

    common t
           1
Error: Cannot change attributes of USE-associated symbol t at (1)


$ gfortran-13-20230115 -c z3.f90
$
$ gfortran-13-20230115 -c z1.f90
z1.f90:6:7:

    6 |    use m, only: t
      |       1
internal compiler error: in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361
0x8a707e gfc_trans_use_stmts
        ../../gcc/fortran/trans-decl.cc:5360
0x8a783b gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.cc:7837
0x82968e translate_all_program_units
        ../../gcc/fortran/parse.cc:6721
0x82968e gfc_parse_file()
        ../../gcc/fortran/parse.cc:7027
0x876eff gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5
           Priority|P3                          |P4

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
            Summary|[10/11/12/13 Regression]    |[10/11/12/13 Regression]
                   |ICE in gfc_trans_use_stmts, |ICE in gfc_trans_use_stmts,
                   |at                          |at
                   |fortran/trans-decl.cc:5361  |fortran/trans-decl.cc:5361
                   |                            |since
                   |                            |r6-3704-g2b3f52a2d0fb22ba
   Last reconfirmed|                            |2023-01-19
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |mikael at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r6-3704-g2b3f52a2d0fb22ba.

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Patch:

diff --git a/gcc/fortran/match.cc b/gcc/fortran/match.cc
index 5e933c12931..f9393f189e0 100644
--- a/gcc/fortran/match.cc
+++ b/gcc/fortran/match.cc
@@ -5345,6 +5345,15 @@ gfc_match_common (void)
                goto cleanup;
            }

+         /* F2018:C8121: A variable-name shall not be a name made accessible
+            by use association.  */
+         if (sym->attr.use_assoc)
+           {
+             gfc_error ("Symbol %qs at %C is USE associated from module %qs "
+                        "and cannot occur in COMMON", sym->name, sym->module);
+             goto cleanup;
+           }
+
          /* Deal with an optional array specification after the
             symbol name.  */
          m = gfc_match_array_spec (&as, true, true);

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-January/058843.html

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:aba9ff8f30d4245294ea2583de1dc28f1c7ccf7b

commit r13-5478-gaba9ff8f30d4245294ea2583de1dc28f1c7ccf7b
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jan 28 17:59:23 2023 +0100

    Fortran: diagnose USE associated symbols in COMMON blocks [PR108453]

    gcc/fortran/ChangeLog:

            PR fortran/108453
            * match.cc (gfc_match_common): A USE associated name shall not
appear
            in a COMMON block (F2018:C8121).

    gcc/testsuite/ChangeLog:

            PR fortran/108453
            * gfortran.dg/common_27.f90: New test.

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:936fdf056944989c49dc4fff399ca5dc0d0213ee

commit r12-9101-g936fdf056944989c49dc4fff399ca5dc0d0213ee
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jan 28 17:59:23 2023 +0100

    Fortran: diagnose USE associated symbols in COMMON blocks [PR108453]

    gcc/fortran/ChangeLog:

            PR fortran/108453
            * match.cc (gfc_match_common): A USE associated name shall not
appear
            in a COMMON block (F2018:C8121).

    gcc/testsuite/ChangeLog:

            PR fortran/108453
            * gfortran.dg/common_27.f90: New test.

    (cherry picked from commit aba9ff8f30d4245294ea2583de1dc28f1c7ccf7b)

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:be8003ffcfb02dd8ef49ffec01bf96da2d973bc2

commit r11-10500-gbe8003ffcfb02dd8ef49ffec01bf96da2d973bc2
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jan 28 17:59:23 2023 +0100

    Fortran: diagnose USE associated symbols in COMMON blocks [PR108453]

    gcc/fortran/ChangeLog:

            PR fortran/108453
            * match.c (gfc_match_common): A USE associated name shall not
appear
            in a COMMON block (F2018:C8121).

    gcc/testsuite/ChangeLog:

            PR fortran/108453
            * gfortran.dg/common_27.f90: New test.

    (cherry picked from commit aba9ff8f30d4245294ea2583de1dc28f1c7ccf7b)

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:841e585ad936624f2d080512a9f6244b49e71969

commit r10-11192-g841e585ad936624f2d080512a9f6244b49e71969
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Sat Jan 28 17:59:23 2023 +0100

    Fortran: diagnose USE associated symbols in COMMON blocks [PR108453]

    gcc/fortran/ChangeLog:

            PR fortran/108453
            * match.c (gfc_match_common): A USE associated name shall not
appear
            in a COMMON block (F2018:C8121).

    gcc/testsuite/ChangeLog:

            PR fortran/108453
            * gfortran.dg/common_27.f90: New test.

    (cherry picked from commit aba9ff8f30d4245294ea2583de1dc28f1c7ccf7b)

[Bug fortran/108453] [10/11/12/13 Regression] ICE in gfc_trans_use_stmts, at fortran/trans-decl.cc:5361 since r6-3704-g2b3f52a2d0fb22ba

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108453

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!