[Bug c/108505] New: Arm: arm-none-eabi toolchain build failing with compiler error.

[Bug c/108505] New: Arm: arm-none-eabi toolchain build failing with compiler error.

[srinath.parvathaneni at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

            Bug ID: 108505
           Summary: Arm: arm-none-eabi toolchain build failing with
                    compiler error.
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: srinath.parvathaneni at arm dot com
  Target Milestone: ---

The latest arm-none-eabi build for gcc-trunk failing with following error:

/bin/bash /media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../move-if-change
tmp-constants.h insn-constants.h
/bin/bash /media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../move-if-change
tmp-enums.cc insn-enums.cc
echo timestamp > s-constants
echo timestamp > s-enums
/bin/bash /media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../move-if-change
tmp-options.h options.h
echo timestamp > s-options-h
build/gengtype  \
                    -S /media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc -I
gtyp-input.list -w tmp-gtype.state
g++ -c   -O0 -g3   -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Wconditionally-supported
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H  -DGENERATOR_FILE -I.
-Ibuild -I/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc
-I/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/build
-I/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../include 
-I/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../libcpp/include  \
        -o build/gencheck.o
/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/gencheck.cc
gtyp-input.list:19: file
/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/config/arm/arm-mlib.h
specified more than once for language (all)
g++   -O0 -g3   -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions
-fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -Wconditionally-supported
-Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H  -DGENERATOR_FILE
-static-libstdc++ -static-libgcc  -o build/gencheck \
    build/gencheck.o ../build-x86_64-pc-linux-gnu/libiberty/libiberty.a
build/gencheck > tmp-check.h
/bin/bash /media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../move-if-change
tmp-check.h tree-check.h
echo timestamp > s-check
make[1]: *** [Makefile:2823: s-gtype] Error 1
make[1]: *** Waiting for unfinished jobs....
/bin/bash /media/sripar01/2tb_work/trunk_gcc_13/src/gcc/gcc/../move-if-change
tmp-mlib.h multilib.h
echo timestamp > s-mlib
rm gcov.pod gcov-dump.pod gpl.pod cpp.pod gfdl.pod fsf-funding.pod gcc.pod
gcov-tool.pod lto-dump.pod
make[1]: Leaving directory
'/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/obj/gcc1/gcc'
make: *** [Makefile:4600: all-gcc] Error 2
make: Leaving directory
'/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/obj/gcc1'

And this build failure is due to following patch:

commit 3a0dd2cc28ee2833dc5bf1d4fb6d746a8c55ca4d
Author: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
Date:   Mon Jan 23 11:04:19 2023 +0000

    arm: Add pacbti related multilib support for armv8.1-m.main.

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
How did you configure GCC?

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[srinath.parvathaneni at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

--- Comment #2 from Srinath Parvathaneni <srinath.parvathaneni at arm dot com> ---
/media/sripar01/2tb_work/trunk_gcc_13/src/gcc/configure'  
'--target=arm-none-eabi'
'--prefix=/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/install'
'--with-gmp=/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/host-tools'
'--with-mpfr=/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/host-tools'
'--with-mpc=/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/host-tools'
'--with-isl=/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/host-tools'
'--disable-shared' '--disable-nls' '--disable-threads' '--disable-tls'
'--enable-checking=yes' '--without-cloog' '--without-isl' '--with-newlib'
'--without-headers' '--with-gnu-as' '--with-gnu-ld'
'--with-sysroot=/media/sripar01/2tb_work/trunk_gcc_13/build-arm-none-eabi/install/arm-none-eabi'
'--with-multilib-list=aprofile,rmprofile' '--with-pkgversion=unknown'
'target_alias=arm-none-eabi' 'CFLAGS=-O0 -g3' 'CXXFLAGS=-O0 -g3'
'--enable-languages=c,lto' $ac_configure_extra_args --no-create --no-recursion

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[srinath.parvathaneni at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

--- Comment #3 from Srinath Parvathaneni <srinath.parvathaneni at arm dot com> ---
I introduced the bug, working on the fix.

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-01-23
     Ever confirmed|0                           |1

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
>'--with-multilib-list=aprofile,rmprofile'

is the key here really.

The problem is there is a loop around the multilib list and 
                                                tm_file="$tm_file
arm/arm-mlib.h"

gets executed twice.
So you get arm/arm-mlib.h in the list twice and gengtype does not like that.

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by SRINATH PARVATHANENI
<sripar01@gcc.gnu.org>:

https://gcc.gnu.org/g:275820c09e5f397040cbff69c90012dc1e220faf

commit r13-5322-g275820c09e5f397040cbff69c90012dc1e220faf
Author: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
Date:   Tue Jan 24 09:57:52 2023 +0000

    arm: Fix inclusion of arm-mlib.h header more than once (pr108505).

    The patch fixes the build issue for arm-none-eabi target configured with
    --with-multilib-list=aprofile,rmprofile, in which case the header file
    arm/arm-mlib.h is being included more than once and the toolchain build
    is failing (PR108505).

    gcc/ChangeLog:

    2023-01-24  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

            PR target/108505
            * config.gcc (tm_file): Move the variable out of loop.

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[srinath.parvathaneni at arm dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

Srinath Parvathaneni <srinath.parvathaneni at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Srinath Parvathaneni <srinath.parvathaneni at arm dot com> ---
Fixed in gcc-trunk.

[Bug target/108505] [13 Regression] Arm: arm-none-eabi toolchain build failing with compiler error.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108505

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by SRINATH PARVATHANENI
<sripar01@gcc.gnu.org>:

https://gcc.gnu.org/g:2eeda82d6288fb2a8fbc302d98ed51337e01aaaa

commit r13-5744-g2eeda82d6288fb2a8fbc302d98ed51337e01aaaa
Author: Srinath Parvathaneni <srinath.parvathaneni@arm.com>
Date:   Wed Feb 8 18:39:06 2023 +0000

    arm: Optimize arm-mlib.h header inclusion [pr108505].

    I have committed a fix [1] into gcc trunk for a build
    issue mentioned in pr108505 and latter received few upstream
    comments proposing more robust fix for this issue.

    In this patch I'm addressing those comments and sending this
    as a followup patch.

    gcc/ChangeLog:

    2023-01-27  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

            PR target/108505
            * config.gcc (tm_mlib_file): Define new variable.