[Bug ipa/108509] New: [13 Regression] ICE in add, at hash-set.h:64

[Bug ipa/108509] New: [13 Regression] ICE in add, at hash-set.h:64

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108509

            Bug ID: 108509
           Summary: [13 Regression] ICE in add, at hash-set.h:64
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---

gcc 13.0.1 20230122 snapshot (g:844eab81da3f49da88e8bb02e2b1255ba88d02b0) ICEs
when compiling the following testcase, reduced from
test/CodeGenCXX/vtable-available-externally.cpp from the clang 15 test suite,
w/ -O1 -fdevirtualize -fno-tree-fre:

struct B {
  virtual void deref ();
};

struct RefPtr {
  B *p;

  RefPtr ()
  {
    p->deref ();
  }
};

void
f ()
{
  RefPtr b;
}

% g++-13 -O1 -fdevirtualize -fno-tree-fre -c ce52fpmj.cpp
during IPA pass: remove_symbols
ce52fpmj.cpp:18:1: internal compiler error: in add, at hash-set.h:64
   18 | }
      | ^
0x7fa104 hash_set<symtab_node*, false, default_hash_traits<symtab_node*>
>::add(symtab_node* const&)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/hash-set.h:64
0x7faaf4 hash_set<void*, false, default_hash_traits<void*> >::add(void* const&)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/tree.h:3644
0x7faaf4 walk_polymorphic_call_targets
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/ipa.cc:185
0x7faaf4 symbol_table::remove_unreachable_nodes(_IO_FILE*)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/ipa.cc:430
0x1108079 execute_todo
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/passes.cc:2159

[Bug ipa/108509] [13 Regression] ICE in add, at hash-set.h:64

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108509

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug ipa/108509] [13 Regression] ICE in add, at hash-set.h:64

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108509

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2023-01-24

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Pretty much the same as PR108330, let me fix it.

[Bug ipa/108509] [13 Regression] ICE in add, at hash-set.h:64

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108509

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
I'm testing a patch.

[Bug ipa/108509] [13 Regression] ICE in add, at hash-set.h:64

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108509

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:78589691ee158e689fa9bb7dec1165da475ea634

commit r13-5629-g78589691ee158e689fa9bb7dec1165da475ea634
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Jan 24 14:39:11 2023 +0100

    ipa: check if cache_token != NULL before hash_set::add call

    We should not insert an empty value to the container.

            PR ipa/108509

    gcc/ChangeLog:

            * cgraphunit.cc (walk_polymorphic_call_targets): Insert
            ony non-null values.
            * ipa.cc (walk_polymorphic_call_targets): Likewise.

    gcc/testsuite/ChangeLog:

            * g++.dg/ipa/pr108509.C: New test.

[Bug ipa/108509] [13 Regression] ICE in add, at hash-set.h:64

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108509

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.