[Bug target/108515] New: Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[Bug target/108515] New: Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

            Bug ID: 108515
           Summary: Fails to link fixincl with unresolvable
                    R_ARM_MOVW_ABS_NC reloca tion against symbol
                    `stderr@@GLIBC_2.4'
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

The build for armv7hl-gnueabi recently fails with

[  136s] gcc -c -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -funwind-tables
-fasyn
chronous-unwind-tables -fstack-clash-protection -Werror=return-type -g
-U_FORTIF
Y_SOURCE -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes
-Wold
-style-definition -Wmissing-format-attribute -Wno-overlength-strings -pedantic
-
Wno-long-long   -DHAVE_CONFIG_H -I. -I../../../fixincludes -I../include
-I../../
../fixincludes/../include ../../../fixincludes/fixincl.c
...
[  139s] gcc -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -funwind-tables
-fasynchr
onous-unwind-tables -fstack-clash-protection -Werror=return-type -g
-U_FORTIFY_S
OURCE  -o fixincl fixincl.o fixtests.o fixfixes.o server.o procopen.o fixlib.o
f
ixopts.o ../libiberty/libiberty.a
[  139s]
/usr/lib/gcc/armv7hl-suse-linux-gnueabi/12/../../../../armv7hl-suse-lin
ux-gnueabi/bin/ld: fixincl.o(.text+0x1ac): unresolvable R_ARM_MOVW_ABS_NC
reloca
tion against symbol `stderr@@GLIBC_2.4'
[  139s] collect2: error: ld returned 1 exit status

when configured as

[   63s] + ../configure --prefix=/usr --infodir=/usr/share/info
--mandir=/usr/share/man --libdir=/usr/lib --libexecdir=/usr/lib
--enable-languages=c,c++,objc,fortran,obj-c++,go,d,jit --enable-host-shared
--enable-checking=release --disable-werror
--with-gxx-include-dir=/usr/include/c++/13
--with-libstdcxx-zoneinfo=/usr/share/zoneinfo --enable-ssp --disable-libssp
--disable-libvtv --enable-cet=auto --disable-libcc1 --enable-plugin
--with-bugurl=https://bugs.opensuse.org/ '--with-pkgversion=SUSE Linux'
--with-slibdir=/lib --with-system-zlib --enable-libstdcxx-allocator=new
--disable-libstdcxx-pch --enable-libphobos
--enable-version-specific-runtime-libs --with-gcc-major-version-only
--enable-linker-build-id --enable-linux-futex --enable-gnu-indirect-function
--program-suffix=-13 --without-system-libunwind --with-cpu=generic-armv7-a
--with-float=hard --with-abi=aapcs-linux --with-fpu=vfpv3-d16
--disable-sjlj-exceptions --build=armv7hl-suse-linux-gnueabi
--host=armv7hl-suse-linux-gnueabi

and built with

[   74s] + make -Oline 'STAGE1_CFLAGS=-g -O2' 'BOOT_CFLAGS=-O2
-U_FORTIFY_SOURCE
 -D_FORTIFY_SOURCE=3 -funwind-tables -fasynchronous-unwind-tables
-fstack-clash-
protection -Werror=return-type -g -U_FORTIFY_SOURCE' -j6

where 'gcc' is GCC 12.2.1 as of r12-9008-ge4b5fec75aa8d0

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-01-24
     Ever confirmed|0                           |1
                 CC|                            |marxin at gcc dot gnu.org

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
binutils is 2.39 btw

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 54333
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54333&action=edit
preprocessed source, assembly and object

The linker error also reproduces (besides unresolved symbols) when only linking
the fixincl.o file.

It's compiled (with GCC 12.2) with

/usr/lib/gcc/armv7hl-suse-linux-gnueabi/12/cc1 -fpreprocessed fixincl.i -quiet
-dumpbase fixincl.c -dumpbase-ext .c -mcpu=generic-armv7-a -mfloat-abi=hard
-mfpu=vfpv3-d16 -mabi=aapcs-linux -mtls-dialect=gnu -marm -mlibarch=armv7-a+fp
-march=armv7-a+fp -g -O2 -Werror=return-type -Wextra -Wall -Wwrite-strings
-Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition
-Wsuggest-attribute=format -Wno-overlength-strings -Wpedantic -Wno-long-long
-version -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
-o fixincl.s

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|13.0                        |12.2.1

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
And the GCC 12 branch fails the same way for us (with the same GCC 12
compiler),
so probably an issue of the GCC 12 compiler (or binutils).

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
#include <stdio.h>
int main()
{
  printf("%p\n", stderr);
  return 0;
}

produces the same error

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Symbol table '.symtab' contains 16110 entries:
   Num:    Value  Size Type    Bind   Vis      Ndx Name
...
 14277: 00190df0     4 OBJECT  GLOBAL DEFAULT   31 stderr

and '31' is

  [31] .data             PROGBITS        001901b0 1801b0 000c50 00  WA  0   0 
8

nothing surprising I think.

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
same with

extern void *stderr;
int main()
{
  volatile void *x = stderr;
}

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #7 from Andreas Schwab <schwab@linux-m68k.org> ---
Are you sure this isn't due to the binutils patch?

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |matz at gcc dot gnu.org

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Andreas Schwab from comment #7)
> Are you sure this isn't due to the binutils patch?

There were successful builds in December, so I thought that
arm32-avoid-copyreloc.patch was already in?  Are you refering to that?

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #8)
> (In reply to Andreas Schwab from comment #7)
> > Are you sure this isn't due to the binutils patch?
> 
> There were successful builds in December, so I thought that
> arm32-avoid-copyreloc.patch was already in?  Are you refering to that?

This was added 4 days ago
https://build.opensuse.org/request/show/1060005

with the following comment:
I'll accept this, but note that the arm32 patch might be broken:
from https://sourceware.org/bugzilla/show_bug.cgi?id=16177 :

Nick Clifton 2022-10-17 10:34:16 UTC
The patch still suffers from the problem triggered by the example in comment
#12

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #10 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
Almost certainly this is related to the need for a copyreloc and presumably the
linker has not created one for some reason.  So I suspect this is most likely a
binutils issue rather than a compiler one.  The code generated for the simple
test is just

main:
        @ args = 0, pretend = 0, frame = 0
        @ frame_needed = 0, uses_anonymous_args = 0
        movw    r3, #:lower16:stderr
        movt    r3, #:upper16:stderr
        push    {r4, lr}
        movw    r0, #:lower16:.LC0
        movt    r0, #:upper16:.LC0
        ldr     r1, [r3]
        bl      printf
        mov     r0, #0
        pop     {r4, pc}

And the references to stderr will require the definition to be moved from the
shared library to the static image during linking.

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Richard Earnshaw from comment #10)
> Almost certainly this is related to the need for a copyreloc and presumably
> the linker has not created one for some reason.  So I suspect this is most
> likely a binutils issue rather than a compiler one.  The code generated for
> the simple test is just
> 
> main:
>         @ args = 0, pretend = 0, frame = 0
>         @ frame_needed = 0, uses_anonymous_args = 0
>         movw    r3, #:lower16:stderr
>         movt    r3, #:upper16:stderr
>         push    {r4, lr}
>         movw    r0, #:lower16:.LC0
>         movt    r0, #:upper16:.LC0
>         ldr     r1, [r3]
>         bl      printf
>         mov     r0, #0
>         pop     {r4, pc}
> 
> And the references to stderr will require the definition to be moved from
> the shared library to the static image during linking.

So eventually linking with -Wl,-z,nocopyreloc will fail?

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Reverting the linker patch gets past the failure point.

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |FIXED

--- Comment #13 from Richard Earnshaw <rearnsha at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #11)

> So eventually linking with -Wl,-z,nocopyreloc will fail?

If you want to avoid copyrelocs you'll need to compile with -fpie.

[Bug target/108515] Fails to link fixincl with unresolvable R_ARM_MOVW_ABS_NC reloca tion against symbol `stderr@@GLIBC_2.4'

[rearnsha at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108515

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |INVALID