[Bug c++/108525] New: [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[Bug c++/108525] New: [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

            Bug ID: 108525
           Summary: [13 Regression] ICE in write_method_parms, at
                    cp/mangle.cc:2864
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20220925 and 20221009 :
(ok without "static")


$ cat z1.cc
auto b = [](...) static { return 1; };


$ g++-13-20230122 -c z1.cc -std=c++23
z1.cc:1:10: internal compiler error: Segmentation fault
    1 | auto b = [](...) static { return 1; };
      |          ^
0xeb575f crash_signal
        ../../gcc/toplev.cc:314
0x871e8d write_method_parms
        ../../gcc/cp/mangle.cc:2864
0x86ea28 write_closure_type_name
        ../../gcc/cp/mangle.cc:1819
0x86ea28 write_unqualified_name
        ../../gcc/cp/mangle.cc:1511
0x876dd7 write_prefix
        ../../gcc/cp/mangle.cc:1257
0x86f764 write_nested_name
        ../../gcc/cp/mangle.cc:1167
0x872031 write_encoding
        ../../gcc/cp/mangle.cc:853
0x87212c write_mangled_name
        ../../gcc/cp/mangle.cc:799
0x8726e1 mangle_decl_string
        ../../gcc/cp/mangle.cc:4108
0x87290b get_mangled_id
        ../../gcc/cp/mangle.cc:4129
0x87290b mangle_decl(tree_node*)
        ../../gcc/cp/mangle.cc:4167
0x113e512 decl_assembler_name(tree_node*)
        ../../gcc/tree.cc:717
0xa9b23f symtab_node::get_comdat_group_id()
        ../../gcc/cgraph.h:254
0xa9b23f analyze_functions
        ../../gcc/cgraphunit.cc:1192
0xa9c3fd symbol_table::finalize_compilation_unit()
        ../../gcc/cgraphunit.cc:2547

[Bug c++/108525] [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-on-invalid-code         |ABI, ice-on-valid-code
     Ever confirmed|0                           |1
   Target Milestone|---                         |13.0
   Last reconfirmed|                            |2023-01-24
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is valid code in C++23.

[Bug c++/108525] [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with my r13-2892-g303976a6076f2839354702fd2caa049fa7cbbdc2

[Bug c++/108525] [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
           Priority|P3                          |P1

[Bug c++/108525] [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Most likely the ICE started when static operator() support (for C++23) came in
via r13-2892-g303976a6076f28 .

[Bug c++/108525] [13 Regression] ICE in write_method_parms, at cp/mangle.cc:2864

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 54339
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54339&action=edit
gcc13-pr108525.patch

Untested fix.

[Bug c++/108525] [13 Regression] ICE in write_method_parms with static on lambda with ... argument

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9d4c00cdaccc3decd07740e817387ce844ef3ac9

commit r13-5372-g9d4c00cdaccc3decd07740e817387ce844ef3ac9
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 25 15:13:30 2023 +0100

    c++: Fix up mangling of static lambdas [PR108525]

    Before the P1169R4 changes, operator () of a lambda was
    always a method, so it was fine to pass method_p = 1 unconditionally,
    but it isn't always the case, so this patch adds a check for whether
    it is a method or nor.

    2023-01-25  Jakub Jelinek  <jakub@redhat.com>

            PR c++/108525
            * mangle.cc (write_closure_type_name): Don't assume all
            lambda operator() fns are methods.

            * g++.dg/cpp23/static-operator-call5.C: New test.

[Bug c++/108525] [13 Regression] ICE in write_method_parms with static on lambda with ... argument

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.

[Bug c++/108525] [13 Regression] ICE in write_method_parms with static on lambda with ... argument

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108525

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a58a4a57f9a4445f93b495f776f45e1118777e88

commit r13-5737-ga58a4a57f9a4445f93b495f776f45e1118777e88
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 8 13:57:00 2023 +0100

    testsuite: Fix up PR108525 test [PR108525]

    Seems when committing the PR108525 fix I've missed that a test with
    the same name had been added a few hours before for PR108526.

    This patch separates the PR108525 test into a new file.

    2023-02-08  Jakub Jelinek  <jakub@redhat.com>

            PR c++/108525
            * g++.dg/cpp23/static-operator-call5.C: Move PR108525 testcase
            incorrectly applied into PR108526 testcase ...
            * g++.dg/cpp23/static-operator-call6.C: ... here.  New test.