public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/108545] [13 Regression] ICE in install_var_field, at omp-low.cc:799 since r13-2665-g23baa717c991d77f
Date: Wed, 01 Mar 2023 14:24:58 +0000	[thread overview]
Message-ID: <bug-108545-4-o8FwJgEd0f@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108545-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108545

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:3843dc1460259fbca1f336b0259f0b6b527d77ae

commit r13-6394-g3843dc1460259fbca1f336b0259f0b6b527d77ae
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Wed Mar 1 15:11:53 2023 +0100

    OpenMP: Ignore side-effects when finding struct comps [PR108545]

    With volatile, two 'x.data' comp refs aren't regarded as identical,
    causing that the two items in the first map of
      map(to:x.a, x.a.data) map(pset: x.a.data)
    end up in separate 'map(struct:x)', which will cause a later ICE.

    Solution: Ignore side effects when checking the operands in the hash
    for being equal. (Do so by creating a variant of tree_operand_hash
    that calls operand_equal_p with OEP_MATCH_SIDE_EFFECTS.)

    gcc/ChangeLog:

            PR middle-end/108545
            * gimplify.cc (struct tree_operand_hash_no_se): New.
            (omp_index_mapping_groups_1, omp_index_mapping_groups,
            omp_reindex_mapping_groups, omp_mapped_by_containing_struct,
            omp_tsort_mapping_groups_1, omp_tsort_mapping_groups,
            oacc_resolve_clause_dependencies, omp_build_struct_sibling_lists,
            gimplify_scan_omp_clauses): Use tree_operand_hash_no_se instead
            of tree_operand_hash.

    gcc/testsuite/ChangeLog:

            PR middle-end/108545
            * c-c++-common/gomp/map-8.c: New test.
            * gfortran.dg/gomp/map-9.f90: New test.

  parent reply	other threads:[~2023-03-01 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 17:50 [Bug fortran/108545] New: [13 Regression] ICE in install_var_field, at omp-low.cc:799 gscfq@t-online.de
2023-01-26  7:44 ` [Bug fortran/108545] " rguenth at gcc dot gnu.org
2023-01-26  9:41 ` [Bug fortran/108545] [13 Regression] ICE in install_var_field, at omp-low.cc:799 since r13-2665-g23baa717c991d77f marxin at gcc dot gnu.org
2023-02-21 12:57 ` [Bug middle-end/108545] " rguenth at gcc dot gnu.org
2023-02-24 14:19 ` burnus at gcc dot gnu.org
2023-02-24 14:46 ` burnus at gcc dot gnu.org
2023-02-24 15:53 ` burnus at gcc dot gnu.org
2023-02-28 11:24 ` burnus at gcc dot gnu.org
2023-03-01 14:24 ` cvs-commit at gcc dot gnu.org [this message]
2023-03-01 14:28 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108545-4-o8FwJgEd0f@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).