[Bug c++/108566] New: [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name, at cp/mangle.cc:1438

[Bug c++/108566] New: [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name, at cp/mangle.cc:1438

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

            Bug ID: 108566
           Summary: [11/12/13 Regression] ICE: tree check: expected tree
                    that contains 'decl with visibility' structure, have
                    'field_decl' in write_unqualified_name, at
                    cp/mangle.cc:1438
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc 13.0.1 20230122 snapshot (g:844eab81da3f49da88e8bb02e2b1255ba88d02b0) ICEs
when compiling the following testcase, extracted from
test/CodeGenCXX/mangle-nttp-anon-union.cpp from the clang 15 test suite, w/
-std=c++20:

template<typename T>
struct wrapper1 {
  union {
    struct {
      T RightName;
    };
  };
};

template<auto tparam> void dummy(){}

void uses() {
  dummy<wrapper1<double>{123.0}>();
}

% g++-13 -std=c++20 -c h6lcbgyp.cpp
h6lcbgyp.cpp: In function 'void uses()':
h6lcbgyp.cpp:13:33: internal compiler error: tree check: expected tree that
contains 'decl with visibility' structure, have 'field_decl' in
write_unqualified_name, at cp/mangle.cc:1438
   13 |   dummy<wrapper1<double>{123.0}>();
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
0x894b25 tree_contains_struct_check_failed(tree_node const*,
tree_node_structure_enum, char const*, int, char const*)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/tree.cc:9028
0x700b5b contains_struct_check(tree_node*, tree_node_structure_enum, char
const*, int, char const*)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/tree.h:3644
0x700b5b write_unqualified_name
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/mangle.cc:1438
0xa7b3b5 write_expression
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/mangle.cc:3424
0xa7b373 write_expression
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/mangle.cc:3430
0xa7e18a mangle_template_parm_object(tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/mangle.cc:4607
0xb6b6af create_template_parm_object
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/pt.cc:7227
0xb6b6af convert_nontype_argument
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/pt.cc:7734
0xb6b6af convert_template_argument
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/pt.cc:8659
0xb6c402 coerce_template_parms(tree_node*, tree_node*, tree_node*, int, bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/pt.cc:9151
0xb8bbc5 fn_type_unification(tree_node*, tree_node*, tree_node*, tree_node*
const*, unsigned int, tree_node*, unification_kind_t, int, conversion**, bool,
bool)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/pt.cc:22255
0x96c4a4 add_template_candidate_real
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/call.cc:3593
0x96d6b6 add_template_candidate
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/call.cc:3681
0x96d6b6 add_candidates
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/call.cc:6593
0x976811 add_candidates
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/call.cc:4891
0x976811 perform_overload_resolution
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/call.cc:4908
0x97b0c2 build_new_function_call(tree_node*, vec<tree_node*, va_gc,
vl_embed>**, int)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/call.cc:5015
0xbae6da finish_call_expr(tree_node*, vec<tree_node*, va_gc, vl_embed>**, bool,
bool, int)
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/semantics.cc:2923
0xb08fa8 cp_parser_postfix_expression
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/parser.cc:7957
0xaf02e4 cp_parser_binary_expression
       
/var/tmp/portage/sys-devel/gcc-13.0.1_p20230122/work/gcc-13-20230122/gcc/cp/parser.cc:10101

[Bug c++/108566] [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name, at cp/mangle.cc:1438

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.4

[Bug c++/108566] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13 Regression] ICE:  |ICE: tree check: expected
                   |tree check: expected tree   |tree that contains 'decl
                   |that contains 'decl with    |with visibility' structure,
                   |visibility' structure, have |have 'field_decl' in
                   |'field_decl' in             |write_unqualified_name with
                   |write_unqualified_name, at  |anonymous struct inside an
                   |cp/mangle.cc:1438           |anonymous union
   Target Milestone|11.4                        |---

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This didn't ICE in GCC 10 but was rejected instead.

[Bug c++/108566] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-01-27
     Ever confirmed|0                           |1

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug c++/108566] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note this is using a GCC extension so this might not be as important.
clang mangles the symbol as:
_Z5dummyIXtl8wrapper1IdEtlNS1_Ut_Edi9RightNametlNS2_Ut_ELd405ec00000000000EEEEEEvv

Which does demangle to:
void dummy<wrapper1<double>{wrapper1<double>::{unnamed
type#1}{.RightName={unnamed type#1}::{unnamed
type#1}{(double)[405ec00000000000]}}}>()


If you change it to:
```
template<typename T>
struct wrapper1 {
  union {
    struct {
      double hh;
      double hh1;
    };
  };
};

template<auto tparam> void dummy(){}

void uses() {
  dummy<wrapper1<double>{123.0, 123.0}>();
}

```
clang mangles the symbol as:
_Z5dummyIXtl8wrapper1IdEtlNS1_Ut_Edi2hhtlNS2_Ut_ELd405ec00000000000ELd405ec00000000000EEEEEEvv

Which demangles as:
void dummy<wrapper1<double>{wrapper1<double>::{unnamed type#1}{.hh={unnamed
type#1}::{unnamed type#1}{(double)[405ec00000000000],
(double)[405ec00000000000]}}}>()

But takes the name of the struct from the first field ...
Which might be what GCC is trying to do but it fails.


Here is a more complex test (wrapper1 does not need to be a template to get the
crash):
struct wrapper1 {
  union {
    struct {
       union {
      double hh;
      double hh1;
      };
    };
  };
};

template<auto tparam> void dummy(){}

void uses() {
  dummy<wrapper1{123.0}>();
}

clang's mangled named:
_Z5dummyIXtl8wrapper1tlNS0_Ut_Edi2hhtlNS1_Ut_EtlNS2_Ut_Edi2hhLd405ec00000000000EEEEEEEvv

Which demangles as:
void dummy<wrapper1{wrapper1::{unnamed type#1}{.hh={unnamed type#1}::{unnamed
type#1}{wrapper1::{unnamed type#1}::{unnamed
type#1}{.hh=((double)[405ec00000000000])}}}}>()

Notice the use of the first field's name.

[Bug c++/108566] [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE: tree check: expected   |[11/12/13 Regression] ICE:
                   |tree that contains 'decl    |tree check: expected tree
                   |with visibility' structure, |that contains 'decl with
                   |have 'field_decl' in        |visibility' structure, have
                   |write_unqualified_name with |'field_decl' in
                   |anonymous struct inside an  |write_unqualified_name with
                   |anonymous union             |anonymous struct inside an
                   |                            |anonymous union since
                   |                            |r11-2016-g6324c52bba490baa
                 CC|                            |jason at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-2016-g6324c52bba490baa.

[Bug c++/108566] [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

[Bug c++/108566] [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> ---
This is https://github.com/itanium-cxx-abi/cxx-abi/issues/139

[Bug c++/108566] [11/12/13 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:e1c8cf9006bd278e969ab7ed35178067ce128f32

commit r13-6582-ge1c8cf9006bd278e969ab7ed35178067ce128f32
Author: Jason Merrill <jason@redhat.com>
Date:   Thu Mar 9 23:33:43 2023 -0500

    c++: class NTTP and nested anon union [PR108566]

    We were failing to come up with the name for the anonymous union.  It seems
    like unfortunate redundancy, but the ABI does say that the name of an
    anonymous union is its first named member.

            PR c++/108566

    gcc/cp/ChangeLog:

            * mangle.cc (anon_aggr_naming_decl): New.
            (write_unqualified_name): Use it.

    gcc/testsuite/ChangeLog:

            * g++.dg/abi/anon6.C: New test.

[Bug c++/108566] [11/12 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13 Regression] ICE:  |[11/12 Regression] ICE:
                   |tree check: expected tree   |tree check: expected tree
                   |that contains 'decl with    |that contains 'decl with
                   |visibility' structure, have |visibility' structure, have
                   |'field_decl' in             |'field_decl' in
                   |write_unqualified_name with |write_unqualified_name with
                   |anonymous struct inside an  |anonymous struct inside an
                   |anonymous union since       |anonymous union since
                   |r11-2016-g6324c52bba490baa  |r11-2016-g6324c52bba490baa

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for GCC 13 so far.

[Bug c++/108566] [11/12 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |13.0
           Priority|P3                          |P2
   Target Milestone|---                         |11.4

[Bug c++/108566] [11/12 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:f483dc1367294d02581e2d98c5f84be4dd67f26b

commit r12-9431-gf483dc1367294d02581e2d98c5f84be4dd67f26b
Author: Jason Merrill <jason@redhat.com>
Date:   Thu Mar 9 23:33:43 2023 -0500

    c++: class NTTP and nested anon union [PR108566]

    We were failing to come up with the name for the anonymous union.  It seems
    like unfortunate redundancy, but the ABI does say that the name of an
    anonymous union is its first named member.

            PR c++/108566

    gcc/cp/ChangeLog:

            * mangle.cc (anon_aggr_naming_decl): New.
            (write_unqualified_name): Use it.

    gcc/testsuite/ChangeLog:

            * g++.dg/abi/anon6.C: New test.

[Bug c++/108566] [11 Regression] ICE: tree check: expected tree that contains 'decl with visibility' structure, have 'field_decl' in write_unqualified_name with anonymous struct inside an anonymous union since r11-2016-g6324c52bba490baa

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108566

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.4                        |11.5

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 11.4 is being released, retargeting bugs to GCC 11.5.