public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108601] [13 Regression] vector peeling ICEs with VLA in gcc_r in SPEC2017 since g:c13223b790bbc5e4a3f5605e057eac59b61b2c85
Date: Wed, 01 Feb 2023 08:41:37 +0000	[thread overview]
Message-ID: <bug-108601-4-AKyreuLGSj@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108601-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108601

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Tamar Christina from comment #7)
> (In reply to Andrew Pinski from comment #1)
> > So here is how I would tackle this:
> > Put all the needed .i/.ii files in a response file.
> > 
> > 
> > $CC -c @files @options
> > $CC -r -o file.o @fileso @options 
> > 
> > Since this is only at profile generated stage it is not as hard ...
> > Then start by reducing the needed .o files in `fileso` .
> > When that is finished. Update `files` to match `fileso`.
> > and then run delta (or another automated reducer) over the files in `files`.
> > Maybe even change -flto=auto etc.
> 
> Thanks! Managed to reduce it to something fairly simple.
> 
> Repro:
> 
> ----
> 
> decode_options() {
>   int flag = 1;
>   for (; flag <= 1 << 21; flag <<= 1)
>     ;
> }
> 
> ----
> 
> compile with gcc -fprofile-generate -mcpu=neoverse-v1 -Ofast opts.i

OK so after _very_ many analyses we get

t.c:3:15: note:  ***** Choosing vector mode VNx2DI
t.c:3:15: note:  ***** Re-trying epilogue analysis with vector mode VNx2DI
...

but then vect_can_advance_ivs_p should return false for the VNx2DI mode
vectorized loop and thus no epilogue peeling possible?

We also do not choose any epilogue vector mode in the end, so the issue
isn't really epilogue vectorization related.  I suppose the
VNx2DI vector loop doesn't use fully masked vectorization but we should
have forced that because we cannot create an epilogue.

That boils down to vect_can_peel_nonlinear_iv_p but oddly enough that's
called from vectorizable_nonlinear_induction itself, possibly because
it calls vect_peel_nonlinear_iv_init.  But then this should never happen
because peeling should be disabled if not possible (but in this context
we don't know whether we actually need to peel).

I think we should remove the vect_can_peel_nonlinear_iv_p call from
vectorizable_nonlinear_induction and adjust vect_can_peel_nonlinear_iv_p
to require a .is_constant () VF.

  parent reply	other threads:[~2023-02-01  8:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 15:43 [Bug tree-optimization/108601] New: [13 Regression] vector peeling ICEs with PGO + LTO + IPA inlining in gcc_r in SPEC2017 tnfchris at gcc dot gnu.org
2023-01-30 16:05 ` [Bug tree-optimization/108601] " pinskia at gcc dot gnu.org
2023-01-31  7:25 ` rguenth at gcc dot gnu.org
2023-01-31  7:29 ` rguenth at gcc dot gnu.org
2023-01-31  7:49 ` crazylht at gmail dot com
2023-01-31  8:28 ` crazylht at gmail dot com
2023-01-31  9:05 ` tnfchris at gcc dot gnu.org
2023-01-31 20:24 ` [Bug tree-optimization/108601] [13 Regression] vector peeling ICEs with VLA in gcc_r in SPEC2017 since g:c13223b790bbc5e4a3f5605e057eac59b61b2c85 tnfchris at gcc dot gnu.org
2023-01-31 21:08 ` tnfchris at gcc dot gnu.org
2023-02-01  5:32 ` crazylht at gmail dot com
2023-02-01  7:29 ` crazylht at gmail dot com
2023-02-01  7:32 ` rguenther at suse dot de
2023-02-01  7:46 ` crazylht at gmail dot com
2023-02-01  8:41 ` rguenth at gcc dot gnu.org [this message]
2023-02-01  9:07 ` crazylht at gmail dot com
2023-02-02  9:02 ` cvs-commit at gcc dot gnu.org
2023-02-03  8:05 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108601-4-AKyreuLGSj@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).