public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tnfchris at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108601] [13 Regression] vector peeling ICEs with VLA in gcc_r in SPEC2017 since g:c13223b790bbc5e4a3f5605e057eac59b61b2c85
Date: Tue, 31 Jan 2023 20:24:32 +0000 [thread overview]
Message-ID: <bug-108601-4-ePAK7aSQF8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108601-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108601
Tamar Christina <tnfchris at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target| |aarch64*
Summary|[13 Regression] vector |[13 Regression] vector
|peeling ICEs with PGO + LTO |peeling ICEs with VLA in
|+ IPA inlining in gcc_r in |gcc_r in SPEC2017 since
|SPEC2017 |g:c13223b790bbc5e4a3f5605e0
| |57eac59b61b2c85
--- Comment #7 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #1)
> So here is how I would tackle this:
> Put all the needed .i/.ii files in a response file.
>
>
> $CC -c @files @options
> $CC -r -o file.o @fileso @options
>
> Since this is only at profile generated stage it is not as hard ...
> Then start by reducing the needed .o files in `fileso` .
> When that is finished. Update `files` to match `fileso`.
> and then run delta (or another automated reducer) over the files in `files`.
> Maybe even change -flto=auto etc.
Thanks! Managed to reduce it to something fairly simple.
Repro:
----
decode_options() {
int flag = 1;
for (; flag <= 1 << 21; flag <<= 1)
;
}
----
compile with gcc -fprofile-generate -mcpu=neoverse-v1 -Ofast opts.i
I also did a bisect and indeed it landed on
commit c13223b790bbc5e4a3f5605e057eac59b61b2c85
Author: liuhongt <hongtao.liu@intel.com>
Date: Thu Aug 4 09:04:22 2022 +0800
Extend vectorizer to handle nonlinear induction for neg, mul/lshift/rshift
with a constant.
For neg, the patch create a vec_init as [ a, -a, a, -a, ... ] and no
vec_step is needed to update vectorized iv since vf is always multiple
of 2(negative * negative is positive).
For shift, the patch create a vec_init as [ a, a >> c, a >> 2*c, ..]
as vec_step as [ c * nunits, c * nunits, c * nunits, ... ], vectorized iv
is
updated as vec_def = vec_init >>/<< vec_step.
For mul, the patch create a vec_init as [ a, a * c, a * pow(c, 2), ..]
as vec_step as [ pow(c,nunits), pow(c,nunits),...] iv is updated as vec_def
=
vec_init * vec_step.
The patch handles nonlinear iv for
1. Integer type only, floating point is not handled.
2. No slp_node.
3. iv_loop should be same as vector loop, not nested loop.
4. No UD is created, for mul, use unsigned mult to avoid UD, for
shift, shift count should be less than type precision.
next prev parent reply other threads:[~2023-01-31 20:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 15:43 [Bug tree-optimization/108601] New: [13 Regression] vector peeling ICEs with PGO + LTO + IPA inlining in gcc_r in SPEC2017 tnfchris at gcc dot gnu.org
2023-01-30 16:05 ` [Bug tree-optimization/108601] " pinskia at gcc dot gnu.org
2023-01-31 7:25 ` rguenth at gcc dot gnu.org
2023-01-31 7:29 ` rguenth at gcc dot gnu.org
2023-01-31 7:49 ` crazylht at gmail dot com
2023-01-31 8:28 ` crazylht at gmail dot com
2023-01-31 9:05 ` tnfchris at gcc dot gnu.org
2023-01-31 20:24 ` tnfchris at gcc dot gnu.org [this message]
2023-01-31 21:08 ` [Bug tree-optimization/108601] [13 Regression] vector peeling ICEs with VLA in gcc_r in SPEC2017 since g:c13223b790bbc5e4a3f5605e057eac59b61b2c85 tnfchris at gcc dot gnu.org
2023-02-01 5:32 ` crazylht at gmail dot com
2023-02-01 7:29 ` crazylht at gmail dot com
2023-02-01 7:32 ` rguenther at suse dot de
2023-02-01 7:46 ` crazylht at gmail dot com
2023-02-01 8:41 ` rguenth at gcc dot gnu.org
2023-02-01 9:07 ` crazylht at gmail dot com
2023-02-02 9:02 ` cvs-commit at gcc dot gnu.org
2023-02-03 8:05 ` rguenth at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-108601-4-ePAK7aSQF8@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).