public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/108646] nonnull attribute does not detect variables that are NULL being passed Date: Fri, 03 Feb 2023 09:23:53 +0000 [thread overview] Message-ID: <bug-108646-4-OZdifcOkw8@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108646-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108646 --- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> --- It already does detect it: n.c: In function ‘test’: n.c:6:2: warning: argument 1 null where non-null expected [-Wnonnull] 6 | mem2(dest); | ^~~~~~~~~~ n.c:2:8: note: in a call to function ‘mem2’ declared ‘nonnull’ 2 | void * mem2(void *dest) __attribute__((nonnull)); | ^~~~ You need to enable optimization, otherwise there is no data flow analysis. Without optimization, it detects it with -fanalyzer n.c: In function ‘void test()’: n.c:6:6: warning: use of NULL ‘dest’ where non-null expected [CWE-476] [-Wanalyzer-null-argument] 6 | mem2(dest); | ~~~~^~~~~~ ‘void test()’: events 1-2 | | 5 | char *dest = NULL; | | ^~~~ | | | | | (1) ‘dest’ is NULL | 6 | mem2(dest); | | ~~~~~~~~~~ | | | | | (2) argument 1 (‘dest’) NULL where non-null expected | n.c:2:8: note: argument 1 of ‘void* mem2(void*)’ must be non-null 2 | void * mem2(void *dest) __attribute__((nonnull)); | ^~~~ And it's also detected at runtime using -fsanitize=undefined: n.c:6:6: runtime error: null pointer passed as argument 1, which is declared to never be null
next prev parent reply other threads:[~2023-02-03 9:23 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-02 21:00 [Bug c++/108646] New: " jg at jguk dot org 2023-02-02 22:26 ` [Bug c++/108646] " pinskia at gcc dot gnu.org 2023-02-03 9:23 ` redi at gcc dot gnu.org [this message] 2023-02-03 12:08 ` jg at jguk dot org 2023-02-03 17:58 ` redi at gcc dot gnu.org 2023-02-07 12:19 ` jg at jguk dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108646-4-OZdifcOkw8@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).