public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jg at jguk dot org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/108646] New: nonnull attribute does not detect variables that are NULL being passed
Date: Thu, 02 Feb 2023 21:00:54 +0000	[thread overview]
Message-ID: <bug-108646-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108646

            Bug ID: 108646
           Summary: nonnull attribute does not detect variables that are
                    NULL being passed
           Product: gcc
           Version: 12.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jg at jguk dot org
  Target Milestone: ---

If we pass NULL directly, there is a good warning (pasted below from today on
Godblot.org latest gcc trunk)

However, there is no error if passing a variable set to NULL.
Could gcc detect this situation?



#include <cstddef>
void * mem2(void *dest) __attribute__((nonnull));
void test(void)
{
 char *dest = NULL;
 mem2(dest); 
 }



This is the warning when NULL is passed directly:

<source>: In function 'void test()':
<source>:6:6: warning: argument 1 null where non-null expected [-Wnonnull]
    6 |  mem2(NULL);
      |  ~~~~^~~~~~
<source>:2:8: note: in a call to function 'void* mem2(void*)' declared
'nonnull'
    2 | void * mem2(void *dest) __attribute__((nonnull));
      |        ^~~~
Compiler returned: 0

             reply	other threads:[~2023-02-02 21:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 21:00 jg at jguk dot org [this message]
2023-02-02 22:26 ` [Bug c++/108646] " pinskia at gcc dot gnu.org
2023-02-03  9:23 ` redi at gcc dot gnu.org
2023-02-03 12:08 ` jg at jguk dot org
2023-02-03 17:58 ` redi at gcc dot gnu.org
2023-02-07 12:19 ` jg at jguk dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108646-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).