[Bug fortran/108663] New: Accepts invalid bug with pdtXXX

[Bug fortran/108663] New: Accepts invalid bug with pdtXXX

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108663

            Bug ID: 108663
           Summary: Accepts invalid bug with pdtXXX
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: accepts-invalid, ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
                CC: aoliva at gcc dot gnu.org, gscfq@t-online.de,
                    jakub at gcc dot gnu.org, kargl at gcc dot gnu.org,
                    marxin at gcc dot gnu.org, unassigned at gcc dot gnu.org
        Depends on: 108451
  Target Milestone: ---

The PR108451 testcase is accepted even when it should be rejected.

+++ This bug was initially created as a clone of Bug #108451 +++

Started recently between 20221218 and 20230108, with special name pdtt :
(gcc configured with --enable-checking=yes)


$ cat z1.f90
module m
   type t(n)
      integer, len :: n
      integer :: a(n)
   end type
contains
   subroutine s(x)
      type(t(2)) :: x
   end
end
program p
   use m, only: t, pdtt, s
   type(t(2)) :: y
   call s(y)
end


$ gfortran-13-20221218 -c z1.f90   # missing error
$
$ gfortran-13-20230115 -c z1.f90
z1.f90:12:7:

   12 |    use m, only: t, pdtt, s
      |       1
internal compiler error: in check_complete_insertion, at hash-table.h:578
0x92fc0b hash_table<module_decl_hasher, false,
xcallocator>::check_complete_insertion() const
        ../../gcc/hash-table.h:578
0x92fc0b hash_table<module_decl_hasher, false,
xcallocator>::find_slot_with_hash(char const* const&, unsigned int,
insert_option)
        ../../gcc/hash-table.h:1042
0x92c57e gfc_trans_use_stmts
        ../../gcc/fortran/trans-decl.cc:5329
0x92d3a6 gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.cc:7837
0x89ef8e translate_all_program_units
        ../../gcc/fortran/parse.cc:6721
0x89ef8e gfc_parse_file()
        ../../gcc/fortran/parse.cc:7027
0x8ed3af gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:229


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108451
[Bug 108451] [13 Regression] ICE in check_complete_insertion, at
hash-table.h:578

[Bug fortran/108663] Accepts invalid bug with pdtXXX

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108663

--- Comment #1 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
> $ gfortran-13-20221218 -c z1.f90   # missing error
> $
> $ gfortran-13-20230115 -c z1.f90
> z1.f90:12:7:
> 
>    12 |    use m, only: t, pdtt, s
>       |       1
> internal compiler error: in check_complete_insertion, at hash-table.h:578

For the record, the entity 'pdtt' is not specified
in the module.  It is constructed by gfortran in 
decl.cc(gfc_get_pdt_instance) when parsing a parameterized
derived type.  The symbol pdtt means PDT type t, and it
appears to inserted into the namespace.  A likely better
name would have been _PDT_t, because the leading underscore
means the name cannot conflict with a user's code and
gfortran downcases all parsed code so PDT shows that the
symbol is artificial.

[Bug fortran/108663] Accepts invalid bug with pdtXXX

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108663

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
             Blocks|                            |82173

--- Comment #2 from Paul Thomas <pault at gcc dot gnu.org> ---
Added to PDT meta-bug


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82173
[Bug 82173] [meta-bug] [PDT] Parameterized derived type errors