public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C
@ 2023-02-04 3:04 hp at gcc dot gnu.org
2023-02-04 17:39 ` [Bug libstdc++/108672] " cvs-commit at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: hp at gcc dot gnu.org @ 2023-02-04 3:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108672
Bug ID: 108672
Summary: [13 Regression] g++.dg/modules/xtreme-header-2_a.H,
_b.C, _c.C
Product: gcc
Version: 13.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: hp at gcc dot gnu.org
Target Milestone: ---
Target: cris-elf, pru-elf
Tl;DR: not a dup of PR98531, but a bug in libstdc++-v3. Also, a regression.
For cris-elf, these failures appeared with a commit in the range
r13-2740-gd812e8cb2a920f..r13-2748-g59f6dea963b5f7:
Build log:
Running /x/gcc/testsuite/g++.dg/modules/modules.exp ...
<...removing non-regression FAILs...>
FAIL: g++.dg/modules/xtreme-header-2_a.H -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_a.H module-cmi
(gcm.cache/$srcdir/g++.dg/modules/xtreme-header-2_a.H.gcm)
FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_c.C -std=c++17 (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_a.H -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_a.H module-cmi
(gcm.cache/$srcdir/g++.dg/modules/xtreme-header-2_a.H.gcm)
FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_c.C -std=c++2a (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_a.H -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_a.H module-cmi
(gcm.cache/$srcdir/g++.dg/modules/xtreme-header-2_a.H.gcm)
FAIL: g++.dg/modules/xtreme-header-2_b.C -std=c++2b (test for excess errors)
FAIL: g++.dg/modules/xtreme-header-2_c.C -std=c++2b (test for excess errors)
They don't appear for {s390x, powerpc64, i686, x86_64, aarch64, arm}-linux-gnu.
They're there for pru-elf where the context looks the same as for cris-elf:
(https://gcc.gnu.org/pipermail/gcc-testresults/2023-January/775193.html).
The commit exposing the failure appears to be r13-2745-gc77f556741ded4, "c++:
xtreme-header modules tests cleanups", due to the '+#include <execution>'.
In g++.log for cris-elf, we can see that they all fail either fail
similarly as follows:
In file included from /x/gcc/libstdc++-v3/include/pstl/memory_impl.h:15,
from /x/gcc/libstdc++-v3/include/pstl/algorithm_impl.h:20,
from
/x/gccobj/cris-elf/libstdc++-v3/include/pstl/glue_execution_defs.h:50,
from /x/gccobj/cris-elf/libstdc++-v3/include/execution:34,
from /x/gcc/gcc/testsuite/g++.dg/modules/xtreme-header-2.h:4,
from
/x/gcc/gcc/testsuite/g++.dg/modules/xtreme-header-2_a.H:4:
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h: In function 'bool
__pstl::__unseq_backend::__simd_or(_Index, _Di\
fferenceType, _Pred)':
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:77:9: error: 'int32_t'
was not declared in this scope
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:77:9: note: 'int32_t' is
defined in header '<cstdint>'; did you f\
orget to '#include <cstdint>'?
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:81:17: error: '__flag'
was not declared in this scope
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:82:14: error: '__flag'
was not declared in this scope
/x/gcc/gcc/testsuite/g++.dg/modules/xtreme-header-2_a.H: At global scope:
/x/gcc/gcc/testsuite/g++.dg/modules/xtreme-header-2_a.H: warning: not writing
module '/x/gcc/gcc/testsuite/g++.dg/modul\
es/xtreme-header-2_a.H' due to errors
compiler exited with status 1
FAIL: g++.dg/modules/xtreme-header-2_a.H -std=c++17 (test for excess errors)
Excess errors:
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:77:9: error: 'int32_t'
was not declared in this scope
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:81:17: error: '__flag'
was not declared in this scope
/x/gcc/libstdc++-v3/include/pstl/unseq_backend_simd.h:82:14: error: '__flag'
was not declared in this scope
/x/gcc/gcc/testsuite/g++.dg/modules/xtreme-header-2_a.H: warning: not writing
module '/x/gcc/gcc/testsuite/g++.dg/modul\
es/xtreme-header-2_a.H' due to errors
FAIL: g++.dg/modules/xtreme-header-2_a.H module-cmi
(gcm.cache/$srcdir/g++.dg/modules/xtreme-header-2_a.H.gcm)
The error for cris-elf seems to be a "naked" use of int32_t; not having
a fitting #include: stdint.h or cstdint or inttypes.h or whatever, for
use in libstdc++-v3/include/pstl/unseq_backend_simd.h. This is not
exposed on e.g. native x86_64-pc-linux-gnu, because there, it's included
as an effect of including stdlib.h in cstdlib (follow the trace in
xtreme-header-2_a.ii with glibc-2.31-13+deb11u5). Will submit patch shortly.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/108672] [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C
2023-02-04 3:04 [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C hp at gcc dot gnu.org
@ 2023-02-04 17:39 ` cvs-commit at gcc dot gnu.org
2023-02-05 22:33 ` hp at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-04 17:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108672
--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hans-Peter Nilsson <hp@gcc.gnu.org>:
https://gcc.gnu.org/g:72058eea9d407edc85558efc76cde5ceb1d06b0a
commit r13-5702-g72058eea9d407edc85558efc76cde5ceb1d06b0a
Author: Hans-Peter Nilsson <hp@axis.com>
Date: Sat Feb 4 18:38:45 2023 +0100
libstdc++: Avoid use of naked int32_t in unseq_backend_simd.h, PR108672
The use of a "naked" int32_t (i.e. without a fitting #include:
stdint.h or cstdint or inttypes.h or an equivalent internal header),
in libstdc++-v3/include/pstl/unseq_backend_simd.h, caused an error for
cris-elf and apparently pru-elf and I guess all "newlib targets".
(Unfortunately, there's a lack of other *-elf targets in recent months
of gcc-testresults archives.)
This does not manifest on e.g. native x86_64-pc-linux-gnu, because
there, a definition is included as an effect of including stdlib.h in
cstdlib (following the trace in native xtreme-header-2_a.ii with
glibc-2.31-13+deb11u5). Maybe better than chasing the right #includes
is to directly use the built-in type, like so:
libstdc++-v3:
PR libstdc++/108672
* include/pstl/unseq_backend_simd.h (__simd_or): Use __INT32_TYPE__
instead of int32_t.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/108672] [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C
2023-02-04 3:04 [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C hp at gcc dot gnu.org
2023-02-04 17:39 ` [Bug libstdc++/108672] " cvs-commit at gcc dot gnu.org
@ 2023-02-05 22:33 ` hp at gcc dot gnu.org
2023-06-30 3:09 ` hp at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: hp at gcc dot gnu.org @ 2023-02-05 22:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108672
Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #2 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/108672] [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C
2023-02-04 3:04 [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C hp at gcc dot gnu.org
2023-02-04 17:39 ` [Bug libstdc++/108672] " cvs-commit at gcc dot gnu.org
2023-02-05 22:33 ` hp at gcc dot gnu.org
@ 2023-06-30 3:09 ` hp at gcc dot gnu.org
2023-06-30 3:27 ` cvs-commit at gcc dot gnu.org
2023-06-30 3:58 ` hp at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: hp at gcc dot gnu.org @ 2023-06-30 3:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108672
Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Ever confirmed|0 |1
Last reconfirmed| |2023-06-30
Status|RESOLVED |REOPENED
--- Comment #3 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
I'm briefly reopening this PR so my next commit makes sense, as
r14-2109-g3162ca09dbdc2e overwrote the fix from February, making the fails
re-appear. I'll re-commit the fix shortly.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/108672] [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C
2023-02-04 3:04 [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C hp at gcc dot gnu.org
` (2 preceding siblings ...)
2023-06-30 3:09 ` hp at gcc dot gnu.org
@ 2023-06-30 3:27 ` cvs-commit at gcc dot gnu.org
2023-06-30 3:58 ` hp at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-06-30 3:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108672
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Hans-Peter Nilsson <hp@gcc.gnu.org>:
https://gcc.gnu.org/g:b22cf5f0321f6425a357c06647a4366d99ddac61
commit r14-2206-gb22cf5f0321f6425a357c06647a4366d99ddac61
Author: Hans-Peter Nilsson <hp@axis.com>
Date: Sat Feb 4 18:38:45 2023 +0100
libstdc++: Re-apply PR108672 fix (avoid use of naked int32_t in
unseq_backend_simd.h)
The fix was overwritten by r14-2109-g3162ca09dbdc2e "libstdc++:
Synchronize PSTL with upstream".
libstdc++-v3:
PR libstdc++/108672
* include/pstl/unseq_backend_simd.h (__simd_or): Re-apply using
__INT32_TYPE__ instead of int32_t.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/108672] [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C
2023-02-04 3:04 [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C hp at gcc dot gnu.org
` (3 preceding siblings ...)
2023-06-30 3:27 ` cvs-commit at gcc dot gnu.org
@ 2023-06-30 3:58 ` hp at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: hp at gcc dot gnu.org @ 2023-06-30 3:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108672
Hans-Peter Nilsson <hp at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #5 from Hans-Peter Nilsson <hp at gcc dot gnu.org> ---
Re-fixed and re-closed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-30 3:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-04 3:04 [Bug libstdc++/108672] New: [13 Regression] g++.dg/modules/xtreme-header-2_a.H, _b.C, _c.C hp at gcc dot gnu.org
2023-02-04 17:39 ` [Bug libstdc++/108672] " cvs-commit at gcc dot gnu.org
2023-02-05 22:33 ` hp at gcc dot gnu.org
2023-06-30 3:09 ` hp at gcc dot gnu.org
2023-06-30 3:27 ` cvs-commit at gcc dot gnu.org
2023-06-30 3:58 ` hp at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).