public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/108695] [13 Regression] Wrong code since r13-5215-gb1f30bf42d8d47 for dd_rescue package
Date: Wed, 08 Feb 2023 15:28:32 +0000	[thread overview]
Message-ID: <bug-108695-4-01YvCPGrZZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108695-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108695

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #10)
> > where the XOR16 is implemented as:
> > 
> > #define XORN(in1,in2,out,len)	\
> > do {				\
> > 	uint _i;		\
> > 	for (_i = 0; _i < len/sizeof(ulong); ++_i)	\
> > 		*((ulong*)(out)+_i) = *((ulong*)(in1)+_i) ^ *((ulong*)(in2)+_i);	\
> > } while(0)
> 
> I can confirm that changing that to:
> 
> #define XORN(in1, in2, out, len)                  \
> 	do                                            \
> 	{                                             \
> 		uint _i;                                  \
> 		for (_i = 0; _i < len; ++_i)              \
> 			*(out + _i) = *(in1 + _i) ^ *(in2 + _i); \
> 	} while (0)
> 
> fixes the problem. It seems very close to what I saw here:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83201#c13

It depends on if those arrays were stored as ulong or will be later read as
ulong or something else.
One could also use typedef ulong ulong_alias __attribute__((may_alias));
and use ulong_alias* above, or memcpy to/out of ulong temporaries.

  parent reply	other threads:[~2023-02-08 15:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 12:56 [Bug ipa/108695] New: " marxin at gcc dot gnu.org
2023-02-07 12:56 ` [Bug ipa/108695] " marxin at gcc dot gnu.org
2023-02-07 15:17 ` pinskia at gcc dot gnu.org
2023-02-07 15:18 ` pinskia at gcc dot gnu.org
2023-02-08  7:24 ` marxin at gcc dot gnu.org
2023-02-08  7:25 ` marxin at gcc dot gnu.org
2023-02-08  7:38 ` pinskia at gcc dot gnu.org
2023-02-08 11:16 ` marxin at gcc dot gnu.org
2023-02-08 11:29 ` jakub at gcc dot gnu.org
2023-02-08 14:50 ` marxin at gcc dot gnu.org
2023-02-08 15:09 ` marxin at gcc dot gnu.org
2023-02-08 15:18 ` marxin at gcc dot gnu.org
2023-02-08 15:24 ` sam at gentoo dot org
2023-02-08 15:25 ` marxin at gcc dot gnu.org
2023-02-08 15:27 ` marxin at gcc dot gnu.org
2023-02-08 15:28 ` jakub at gcc dot gnu.org [this message]
2023-02-08 15:52 ` marxin at gcc dot gnu.org
2023-02-23 21:04 ` kurt at garloff dot de
2023-02-23 22:04 ` kurt at garloff dot de
2023-02-24 12:24 ` kurt at garloff dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108695-4-01YvCPGrZZ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).