public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/108695] [13 Regression] Wrong code since r13-5215-gb1f30bf42d8d47 for dd_rescue package
Date: Wed, 08 Feb 2023 15:09:12 +0000	[thread overview]
Message-ID: <bug-108695-4-Rf3BlijvyP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108695-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108695

--- Comment #9 from Martin Liška <marxin at gcc dot gnu.org> ---
Actually, looking at the tree dumps before and after the revision, it's leading
to a different place:

First difference happens in:
test_aes.ltrans0.ltrans.116t.dse2

   <bb 4> [local count: 8687547526]:
-  _118 = MEM[(ulong *)iv_4(D)];
-  _120 = MEM[(ulong *)input_19];
-  _121 = _118 ^ _120;
-  MEM[(ulong *)iv_4(D)] = _121;
-  _129 = MEM[(ulong *)iv_4(D) + 8B];
-  _131 = MEM[(ulong *)input_19 + 8B];
-  _132 = _129 ^ _131;
-  MEM[(ulong *)iv_4(D) + 8B] = _132;

(there's one more optimized out block like this. Which maps to:

int  AES_Gen_CBC_Enc(AES_Crypt_Blk_fn *cryptfn,
                     const uchar* rkeys, uint rounds,
                     uchar *iv, uint pad,
                     const uchar *input, uchar *output,
                     ssize_t len, ssize_t *olen)
{
        *olen = len;
        while (len >= 16) {
                XOR16(iv, input, iv);
                cryptfn(rkeys, rounds, iv, iv);
                memcpy(output, iv, 16);
                len -= 16; input += 16; output += 16;
        }
        if (len || pad == PAD_ALWAYS) {
                uchar *in = crypto->blkbuf2;
                fill_blk(input, in, len, pad);
                XOR16(iv, in, iv);
                cryptfn(rkeys, rounds, iv, output);
                /* Store last IV */
                memcpy(iv, output, 16);
                *olen += 16-(len&15);
                //memset(in, 0, 16);
                //LFENCE;
        }
        return (pad == PAD_ALWAYS || (len&15))? 16-(len&15): 0;
}

where the XOR16 is implemented as:

#define XORN(in1,in2,out,len)   \
do {                            \
        uint _i;                \
        for (_i = 0; _i < len/sizeof(ulong); ++_i)      \
                *((ulong*)(out)+_i) = *((ulong*)(in1)+_i) ^
*((ulong*)(in2)+_i);        \
} while(0)

  parent reply	other threads:[~2023-02-08 15:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 12:56 [Bug ipa/108695] New: " marxin at gcc dot gnu.org
2023-02-07 12:56 ` [Bug ipa/108695] " marxin at gcc dot gnu.org
2023-02-07 15:17 ` pinskia at gcc dot gnu.org
2023-02-07 15:18 ` pinskia at gcc dot gnu.org
2023-02-08  7:24 ` marxin at gcc dot gnu.org
2023-02-08  7:25 ` marxin at gcc dot gnu.org
2023-02-08  7:38 ` pinskia at gcc dot gnu.org
2023-02-08 11:16 ` marxin at gcc dot gnu.org
2023-02-08 11:29 ` jakub at gcc dot gnu.org
2023-02-08 14:50 ` marxin at gcc dot gnu.org
2023-02-08 15:09 ` marxin at gcc dot gnu.org [this message]
2023-02-08 15:18 ` marxin at gcc dot gnu.org
2023-02-08 15:24 ` sam at gentoo dot org
2023-02-08 15:25 ` marxin at gcc dot gnu.org
2023-02-08 15:27 ` marxin at gcc dot gnu.org
2023-02-08 15:28 ` jakub at gcc dot gnu.org
2023-02-08 15:52 ` marxin at gcc dot gnu.org
2023-02-23 21:04 ` kurt at garloff dot de
2023-02-23 22:04 ` kurt at garloff dot de
2023-02-24 12:24 ` kurt at garloff dot de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108695-4-Rf3BlijvyP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).